Message ID | 20230406111033.6e26de93@gandalf.local.home |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1123727vqo; Thu, 6 Apr 2023 08:46:06 -0700 (PDT) X-Google-Smtp-Source: AKy350YypHRJ709momKmjXXeOwhoByZ+6f6d2N5ZdvCfREUqeCBXUOWggetY//DXobxxePd6Mqsp X-Received: by 2002:a17:902:fa84:b0:1a1:ad52:4060 with SMTP id lc4-20020a170902fa8400b001a1ad524060mr9158498plb.20.1680795966375; Thu, 06 Apr 2023 08:46:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680795966; cv=none; d=google.com; s=arc-20160816; b=FL7EoWqwFfs7qypMk80UInExIIlKWM1l9zVY6bPLCpEmHjMLGLqZulAKHdrD2BXFqA O0CRGPCnMC0hzW1Q7eoKbGbJczdLPSkdNyubTdmW1yyq1sQjIorD3RzkOYC1f/+erMsT rZ/9eQ/EKCHl2SgwK94s48AlEv4EMWhgO8uvQ+zjopfLPt0VbSARREyEZ7LbPYGSstvf s6a0etPVXtx+pWkBUfc9W25LyLulI0SLK5Z4wwEHGL2eMKDYEj90e/BltNpKHe+aD5on rTbqMj63SjGZH1kN8OPDsZwmKVgTkFytRGJeVh2cIiPrnV/o/+4BUPuve8Grz6V0Bkgp zjeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:cc:to:from:date; bh=cpTIiXBpHWIacKP3RWBw8lGjAwbLxG07F1SorQ2cjyQ=; b=TLB5ayUuNDhs9BcyoxjDKO1Co4SxxVhgQCDJ5kJQdb2HquPW4lGyiU96HWGrduKJlJ wTkmhzkMbgK4HS0WR1bRfvTSXxCBWdAQMuaeq/yIHEbrqd51akvvbvYpQ94ymI6P480k 2kwJAsB0b1nD1/lx+W/38tcxMzaUF+NuOP9AA/GwhEWfkxsvq2F5ELBfjBMBTRRocUSR 4OO7sjNEcqylwPHOOy5hXfOtMt1DPx4EGwnSNpUv95agQzWQyYxfV+HYeg3+y7gDQVbJ XvgsPzaIdTv+4B7imR3UIdFdI91WNw2a3PoHksylbeDyXRtSF2TunU+mbNhyf3wGxqoe KoPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c24-20020a631c58000000b0051367d9cf70si1551896pgm.93.2023.04.06.08.45.53; Thu, 06 Apr 2023 08:46:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239657AbjDFPLK (ORCPT <rfc822;lkml4gm@gmail.com> + 99 others); Thu, 6 Apr 2023 11:11:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238832AbjDFPLH (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 6 Apr 2023 11:11:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAC25189; Thu, 6 Apr 2023 08:11:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4F12A64634; Thu, 6 Apr 2023 15:10:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09B5FC433EF; Thu, 6 Apr 2023 15:10:34 +0000 (UTC) Date: Thu, 6 Apr 2023 11:10:33 -0400 From: Steven Rostedt <rostedt@goodmis.org> To: LKML <linux-kernel@vger.kernel.org>, Linux Trace Kernel <linux-trace-kernel@vger.kernel.org> Cc: Masami Hiramatsu <mhiramat@kernel.org>, Mark Rutland <mark.rutland@arm.com>, kernel test robot <lkp@intel.com>, Tze-nan Wu <Tze-nan.Wu@mediatek.com> Subject: [PATCH] tracing/synthetic: Make lastcmd_mutex static Message-ID: <20230406111033.6e26de93@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762442311318353808?= X-GMAIL-MSGID: =?utf-8?q?1762442311318353808?= |
Series |
tracing/synthetic: Make lastcmd_mutex static
|
|
Commit Message
Steven Rostedt
April 6, 2023, 3:10 p.m. UTC
From: "Steven Rostedt (Google)" <rostedt@goodmis.org> The lastcmd_mutex is only used in trace_events_synth.c and should be static. Link: https://lore.kernel.org/linux-trace-kernel/202304062033.cRStgOuP-lkp@intel.com/ Fixes: 4ccf11c4e8a8e ("tracing/synthetic: Fix races on freeing last_cmd") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> --- kernel/trace/trace_events_synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 4/6/2023 8:40 PM, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" <rostedt@goodmis.org> > > The lastcmd_mutex is only used in trace_events_synth.c and should be > static. > > Link: https://lore.kernel.org/linux-trace-kernel/202304062033.cRStgOuP-lkp@intel.com/ > > Fixes: 4ccf11c4e8a8e ("tracing/synthetic: Fix races on freeing last_cmd") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> You have just beat me in pushing this. Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com> -- Mukesh > --- > kernel/trace/trace_events_synth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c > index f0ff730125bf..d6a70aff2410 100644 > --- a/kernel/trace/trace_events_synth.c > +++ b/kernel/trace/trace_events_synth.c > @@ -44,7 +44,7 @@ enum { ERRORS }; > > static const char *err_text[] = { ERRORS }; > > -DEFINE_MUTEX(lastcmd_mutex); > +static DEFINE_MUTEX(lastcmd_mutex); > static char *last_cmd; > > static int errpos(const char *str)
diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c index f0ff730125bf..d6a70aff2410 100644 --- a/kernel/trace/trace_events_synth.c +++ b/kernel/trace/trace_events_synth.c @@ -44,7 +44,7 @@ enum { ERRORS }; static const char *err_text[] = { ERRORS }; -DEFINE_MUTEX(lastcmd_mutex); +static DEFINE_MUTEX(lastcmd_mutex); static char *last_cmd; static int errpos(const char *str)