diff mbox series

dt-bindings: net: dsa: brcm,sf2: Drop unneeded "#address-cells/#size-cells"

Message ID 20230404204152.635400-1-robh@kernel.org
State New
Headers
Series dt-bindings: net: dsa: brcm,sf2: Drop unneeded "#address-cells/#size-cells" |

Commit Message

Rob Herring April 4, 2023, 8:41 p.m. UTC 
  There's no need for "#address-cells/#size-cells" in the brcm,sf2 node as
no immediate child nodes have an address. What was probably intended was
to put them in the 'ports' node, but that's not necessary as that is
covered by ethernet-switch.yaml via dsa.yaml.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/net/dsa/brcm,sf2.yaml          | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Vladimir Oltean April 5, 2023, 11:30 a.m. UTC | #1 
On Tue, Apr 04, 2023 at 03:41:52PM -0500, Rob Herring wrote:
> There's no need for "#address-cells/#size-cells" in the brcm,sf2 node as
> no immediate child nodes have an address. What was probably intended was
> to put them in the 'ports' node, but that's not necessary as that is
> covered by ethernet-switch.yaml via dsa.yaml.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Florian Fainelli April 5, 2023, 12:24 p.m. UTC | #2 
On 4/4/2023 1:41 PM, Rob Herring wrote:
> There's no need for "#address-cells/#size-cells" in the brcm,sf2 node as
> no immediate child nodes have an address. What was probably intended was
> to put them in the 'ports' node, but that's not necessary as that is
> covered by ethernet-switch.yaml via dsa.yaml.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Jakub Kicinski April 6, 2023, 12:54 a.m. UTC | #3 
On Tue,  4 Apr 2023 15:41:52 -0500 Rob Herring wrote:
> There's no need for "#address-cells/#size-cells" in the brcm,sf2 node as
> no immediate child nodes have an address. What was probably intended was
> to put them in the 'ports' node, but that's not necessary as that is
> covered by ethernet-switch.yaml via dsa.yaml.

There was an application fuzz on this one, FWIW. 
Hope I'm not messing up...
patchwork-bot+netdevbpf@kernel.org April 6, 2023, 1 a.m. UTC | #4 
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  4 Apr 2023 15:41:52 -0500 you wrote:
> There's no need for "#address-cells/#size-cells" in the brcm,sf2 node as
> no immediate child nodes have an address. What was probably intended was
> to put them in the 'ports' node, but that's not necessary as that is
> covered by ethernet-switch.yaml via dsa.yaml.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> 
> [...]

Here is the summary with links:
  - dt-bindings: net: dsa: brcm,sf2: Drop unneeded "#address-cells/#size-cells"
    https://git.kernel.org/netdev/net-next/c/f03789766905

You are awesome, thank you!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/dsa/brcm,sf2.yaml b/Documentation/devicetree/bindings/net/dsa/brcm,sf2.yaml
index eed16e216fb6..72623cfc8c2d 100644
--- a/Documentation/devicetree/bindings/net/dsa/brcm,sf2.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/brcm,sf2.yaml
@@ -76,12 +76,6 @@  properties:
       supports reporting the number of packets in-flight in a switch queue
     type: boolean
 
-  "#address-cells":
-    const: 1
-
-  "#size-cells":
-    const: 0
-
   ports:
     type: object
 
@@ -99,8 +93,6 @@  properties:
 required:
   - reg
   - interrupts
-  - "#address-cells"
-  - "#size-cells"
 
 allOf:
   - $ref: "dsa.yaml#"
@@ -145,8 +137,6 @@  examples:
   - |
     switch@f0b00000 {
             compatible = "brcm,bcm7445-switch-v4.0";
-            #address-cells = <1>;
-            #size-cells = <0>;
             reg = <0xf0b00000 0x40000>,
                   <0xf0b40000 0x110>,
                   <0xf0b40340 0x30>,