diff mbox series

[1/9] tty: n_gsm: fix redundant assignment of gsm->encoding

Message ID	20230405054730.3850-1-daniel.starke@siemens.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: "D. Starke" <daniel.starke@siemens.com> To: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: linux-kernel@vger.kernel.org, Daniel Starke <daniel.starke@siemens.com> Subject: [PATCH 1/9] tty: n_gsm: fix redundant assignment of gsm->encoding Date: Wed, 5 Apr 2023 07:47:22 +0200 Message-Id: <20230405054730.3850-1-daniel.starke@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Feedback-ID: 519:519-314044:519-21489:flowmailer Precedence: bulk
Series	[1/9] tty: n_gsm: fix redundant assignment of gsm->encoding \| [1/9] tty: n_gsm: fix redundant assignment of gsm->encoding [2/9] tty: n_gsm: add restart parameter to DLC specific ioctl config [3/9] tty: n_gsm: add missing description to gsm_config [4/9] tty: n_gsm: fix unneeded initialization of ret in gsm_dlci_config [5/9] tty: n_gsm: add open_error counter to gsm_mux [6/9] tty: n_gsm: increase malformed counter for malformed control frames [7/9] tty: n_gsm: increase gsm_mux unsupported counted where appropriate [8/9] tty: n_gsm: add DLCI specific rx/tx statistics [9/9] tty: n_gsm: cleanup gsm_control_command and gsm_control_reply

Commit Message

D. Starke April 5, 2023, 5:47 a.m. UTC

  From: Daniel Starke <daniel.starke@siemens.com>

The function gsmld_open() contains a redundant assignment of gsm->encoding.
The same value of GSM_ADV_OPT is already assigned to it during the
initialization of the struct in gsm_alloc_mux() a few lines earlier.

Fix this by removing the redundant second assignment of gsm->encoding in
gsmld_open().

Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
---
 drivers/tty/n_gsm.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Ilpo Järvinen April 5, 2023, 8:16 a.m. UTC | #1

On Wed, 5 Apr 2023, D. Starke wrote:

> From: Daniel Starke <daniel.starke@siemens.com>
> 
> The function gsmld_open() contains a redundant assignment of gsm->encoding.
> The same value of GSM_ADV_OPT is already assigned to it during the
> initialization of the struct in gsm_alloc_mux() a few lines earlier.
> 
> Fix this by removing the redundant second assignment of gsm->encoding in
> gsmld_open().
> 
> Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
> Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
> ---
>  drivers/tty/n_gsm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index b7e1369a035c..c42c8b89fd46 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -3585,7 +3585,6 @@ static int gsmld_open(struct tty_struct *tty)
>  	tty->receive_room = 65536;
>  
>  	/* Attach the initial passive connection */
> -	gsm->encoding = GSM_ADV_OPT;
>  	gsmld_attach_gsm(tty, gsm);
>  
>  	/* The mux will not be activated yet, we wait for correct
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

diff mbox series

Patch

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index b7e1369a035c..c42c8b89fd46 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -3585,7 +3585,6 @@  static int gsmld_open(struct tty_struct *tty)
 	tty->receive_room = 65536;
 
 	/* Attach the initial passive connection */
-	gsm->encoding = GSM_ADV_OPT;
 	gsmld_attach_gsm(tty, gsm);
 
 	/* The mux will not be activated yet, we wait for correct