Message ID | 20230324073813.22158-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp441497vqo; Fri, 24 Mar 2023 00:41:26 -0700 (PDT) X-Google-Smtp-Source: AK7set9hfaWSK+j8J2xwVb1H3QQaif06nMuB1dZypEWI+6pt8gnHVD+H6qal/SYKHtNaMqDuBR5r X-Received: by 2002:a05:6a20:a829:b0:d5:ac2b:7e01 with SMTP id cb41-20020a056a20a82900b000d5ac2b7e01mr2138868pzb.34.1679643685874; Fri, 24 Mar 2023 00:41:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679643685; cv=none; d=google.com; s=arc-20160816; b=X2UYLRZ5rGD20iNEJClUKG7gN2OQYhbJZAamfuO+Kve1UE0MtXSWwxnjf7yEZhGOGQ 2ldbl77WVo8gAvS+p43MZhCrSphY0C3HDUKSmwcfMNsPHE0KhxWGa2yhrWzxH6BTNZgA 3WNeUDSaiqz1AOYkLzFeVJWoOnfwlSNYdotx4dXZIXz4yE2w3mN5//RHllcAvJ4bHVYf UFovdhMVypct5/fvfo46GLgg0RjqSty/avtmKFmvViaiqmfHXRLUJqFbsp/bAl4RHj98 4RAeKQEMpJtzGHe8wI6pQ9na953W4w8Iz2tkjc7CMu5wt/cjuPPBnW9+JNnTsIfrMdsb pzmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=SbAf2latoavh3eJGtio+qW5pAyTQGPmQap6Xic0WdfE=; b=R+nYyblbBOXs/LPzcG79zQwNBljgeUoCiBmWbOOkjq8QJxnMgCKsTfVn1VRomnfVPe Ca98QNSvcXc5+rirEW4nqGChjYSzZnxE3MGhGh6kjjOTWqdu4aLgEioIDhOOjfPFjViX 8lNSaiZOFWBnd694Jy4fUHqrkqKQD74DeMEm8/puUWoP1nXAhOgRL6nB6FyaCkCpXl92 xSnblYxaWCQgynYWnlCOuWdVx5bsxOI/HVVw5u/MfyTyvUvCDKoDjOqlnXiP85ao34bn e3LBvKiHymaK/3U0XD7jw9HLFgPH/nIlkUg3hTPVvaIN0wH1a4hAnS6xXctAnDnO6ozC k4aQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="zekak/ON"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a631209000000b0050bfa82c24asi19834574pgl.647.2023.03.24.00.41.13; Fri, 24 Mar 2023 00:41:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="zekak/ON"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231770AbjCXHia (ORCPT <rfc822;ezelljr.billy@gmail.com> + 99 others); Fri, 24 Mar 2023 03:38:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231786AbjCXHiX (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 24 Mar 2023 03:38:23 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DB9E1BF2 for <linux-kernel@vger.kernel.org>; Fri, 24 Mar 2023 00:38:17 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id h8so4315109ede.8 for <linux-kernel@vger.kernel.org>; Fri, 24 Mar 2023 00:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679643496; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SbAf2latoavh3eJGtio+qW5pAyTQGPmQap6Xic0WdfE=; b=zekak/ONVgjfkGs+GlAg8GR6owU2/Cc3+zOgWnMNaRiAykx2X4PoKiKOj5kHsWUeeS XSH1LEg86fIUf+QT7bSZF8RXXZjwFQT07iW6XkvG9fJUaR3DFMYE7IL03DN19FHLNJP1 mgNg8SeHiJYLaFkYxJ7nrsnAZqybETbNqpnbgotwcFOQFs/YQyFOfxd+xfhE56UYw687 rAMoqF3FmLmXpKGiN93dinnBNvM2xB3eDFVqdtikOWHlKZOnRlHRRbTY13XowRyNL8o/ qFtZ7e2oSIIHVXSwBguWoXRXJFN2yFLy6AwDe6+yo8PMZIAUAzh5nx0LUZUwPhYhpoyJ oFKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679643496; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SbAf2latoavh3eJGtio+qW5pAyTQGPmQap6Xic0WdfE=; b=LidErEaSfgifT8FPWOIctqZoNIvr2WbF8EnCmDaBuywuYtXSCE4kPRTKWCI90iUHy3 N44LZ+FNyL5AymBchqPuG8Soj3rSYqU/xa+j0o1DkIqfEg/AQLYZS2omsM43p3vpOvr9 mzwrgoHM/yCaFo+o8gYaCFoXt052LB13ZYggSkpCVwzm2Lldhavl05Ye1RWHOvMIiux/ RhBckSgLCMJcP3BKRw4D3RMYNQsaa4ppLmI4ORuAnySGzYbrL2qX1SfJoQiRxZwdSbU4 khisidSY8AsnDaX5FwseJFDh6LW7gsJNfZgbFto3btVeDUMF+WpG+e3tfhEe4Qgmo4JM lOJQ== X-Gm-Message-State: AAQBX9dAG0h8LSdefeajZ+s93EbbSIZmRIzQHboX61xLE3I3tzOakc47 IEokBf9NrXeRgvg+hrRi23JoPH/f2M5l7KQQrl8= X-Received: by 2002:a17:906:fa0b:b0:8b8:c06e:52d8 with SMTP id lo11-20020a170906fa0b00b008b8c06e52d8mr1500716ejb.36.1679643496002; Fri, 24 Mar 2023 00:38:16 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:ce50:243f:54cc:5373]) by smtp.gmail.com with ESMTPSA id rh26-20020a17090720fa00b00930ba362216sm9970429ejb.176.2023.03.24.00.38.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 00:38:15 -0700 (PDT) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Neil Armstrong <neil.armstrong@linaro.org> Subject: [PATCH 1/6] arm64: dts: qcom: sm8250: drop incorrect domain idle states properties Date: Fri, 24 Mar 2023 08:38:08 +0100 Message-Id: <20230324073813.22158-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761234057371035815?= X-GMAIL-MSGID: =?utf-8?q?1761234057371035815?= |
Series |
[1/6] arm64: dts: qcom: sm8250: drop incorrect domain idle states properties
|
|
Commit Message
Krzysztof Kozlowski
March 24, 2023, 7:38 a.m. UTC
Domain idle states do not use 'idle-state-name' and 'local-timer-stop':
sm8250-hdk.dtb: domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+'
Reported-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/all/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-4-3ead1e418fe4@linaro.org/
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 --
1 file changed, 2 deletions(-)
Comments
On 24/03/2023 09:38, Krzysztof Kozlowski wrote: > Domain idle states do not use 'idle-state-name' and 'local-timer-stop': > > sm8250-hdk.dtb: domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+' > > Reported-by: Neil Armstrong <neil.armstrong@linaro.org> > Link: https://lore.kernel.org/all/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-4-3ead1e418fe4@linaro.org/ > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 79d67b466856..9cf2de87c632 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -354,12 +354,10 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 { > domain-idle-states { > CLUSTER_SLEEP_0: cluster-sleep-0 { > compatible = "domain-idle-state"; > - idle-state-name = "cluster-llcc-off"; > arm,psci-suspend-param = <0x4100c244>; > entry-latency-us = <3264>; > exit-latency-us = <6562>; > min-residency-us = <9987>; > - local-timer-stop; Hmm, so we support setting the broadcast timer when using plain PSCI idle states, but not when using the domain-based idle states. Ulf, Rafael, Daniel, is that an omission for the domain-based idle support? Or is it handled in some other way? > }; > }; > };
On Wed, 29 Mar 2023 at 00:51, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On 24/03/2023 09:38, Krzysztof Kozlowski wrote: > > Domain idle states do not use 'idle-state-name' and 'local-timer-stop': > > > > sm8250-hdk.dtb: domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+' > > > > Reported-by: Neil Armstrong <neil.armstrong@linaro.org> > > Link: https://lore.kernel.org/all/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-4-3ead1e418fe4@linaro.org/ > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > > index 79d67b466856..9cf2de87c632 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > > @@ -354,12 +354,10 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 { > > domain-idle-states { > > CLUSTER_SLEEP_0: cluster-sleep-0 { > > compatible = "domain-idle-state"; > > - idle-state-name = "cluster-llcc-off"; > > arm,psci-suspend-param = <0x4100c244>; > > entry-latency-us = <3264>; > > exit-latency-us = <6562>; > > min-residency-us = <9987>; > > - local-timer-stop; > > Hmm, so we support setting the broadcast timer when using plain PSCI > idle states, but not when using the domain-based idle states. > > Ulf, Rafael, Daniel, is that an omission for the domain-based idle > support? Or is it handled in some other way? I am not sure that we need a DT binding specifically for this, or do we? So far, the timer is managed from platform specific code. For some Qcom based platforms, the timer should be managed in rpmh_rsc_write_next_wakeup(), which makes use of dev_pm_genpd_get_next_hrtimer(). [...] Kind regards Uffe
On Fri, 24 Mar 2023 at 08:38, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Domain idle states do not use 'idle-state-name' and 'local-timer-stop': > > sm8250-hdk.dtb: domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+' > > Reported-by: Neil Armstrong <neil.armstrong@linaro.org> > Link: https://lore.kernel.org/all/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-4-3ead1e418fe4@linaro.org/ > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 79d67b466856..9cf2de87c632 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -354,12 +354,10 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 { > domain-idle-states { > CLUSTER_SLEEP_0: cluster-sleep-0 { > compatible = "domain-idle-state"; > - idle-state-name = "cluster-llcc-off"; FYI: If someone wants to add support for this property, I wouldn't mind. > arm,psci-suspend-param = <0x4100c244>; > entry-latency-us = <3264>; > exit-latency-us = <6562>; > min-residency-us = <9987>; > - local-timer-stop; > }; > }; > }; > -- > 2.34.1 > Kind regards Uffe
On 29/03/2023 12:45, Ulf Hansson wrote: > On Wed, 29 Mar 2023 at 00:51, Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: >> >> On 24/03/2023 09:38, Krzysztof Kozlowski wrote: >>> Domain idle states do not use 'idle-state-name' and 'local-timer-stop': >>> >>> sm8250-hdk.dtb: domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+' >>> >>> Reported-by: Neil Armstrong <neil.armstrong@linaro.org> >>> Link: https://lore.kernel.org/all/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-4-3ead1e418fe4@linaro.org/ >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi >>> index 79d67b466856..9cf2de87c632 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi >>> @@ -354,12 +354,10 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 { >>> domain-idle-states { >>> CLUSTER_SLEEP_0: cluster-sleep-0 { >>> compatible = "domain-idle-state"; >>> - idle-state-name = "cluster-llcc-off"; >>> arm,psci-suspend-param = <0x4100c244>; >>> entry-latency-us = <3264>; >>> exit-latency-us = <6562>; >>> min-residency-us = <9987>; >>> - local-timer-stop; >> >> Hmm, so we support setting the broadcast timer when using plain PSCI >> idle states, but not when using the domain-based idle states. >> >> Ulf, Rafael, Daniel, is that an omission for the domain-based idle >> support? Or is it handled in some other way? > > I am not sure that we need a DT binding specifically for this, or do we? > > So far, the timer is managed from platform specific code. For some > Qcom based platforms, the timer should be managed in > rpmh_rsc_write_next_wakeup(), which makes use of > dev_pm_genpd_get_next_hrtimer(). I'm not sure whether I fully follow this (I might lack some understanding here). I thought that with "local-timer-stop" (well, CPUIDLE_FLAG_TIMER_STOP), we were switching to the broadcast timer before a core/cluster goes into idle state with no local timer, while with rpmh_rsc_write_next_wakeup() we write that only before shutting down the last core (see the comment at rpmh_flush()). This might be an expected thing, I probably don't have enough understanding of the cpuidle internals to judge this. > > [...] > > Kind regards > Uffe
On Fri, 24 Mar 2023 08:38:08 +0100, Krzysztof Kozlowski wrote: > Domain idle states do not use 'idle-state-name' and 'local-timer-stop': > > sm8250-hdk.dtb: domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+' > > Applied, thanks! [1/6] arm64: dts: qcom: sm8250: drop incorrect domain idle states properties commit: dffc4b5c086cf1d3dae4761427122a56b9d1253a [2/6] arm64: dts: qcom: sdm845: drop incorrect domain idle states properties commit: 1766e9155d086cd238c24113a7be9740d35c2ebe [3/6] arm64: dts: qcom: sm6375: drop incorrect domain idle states properties commit: ac7944f01b771af7718a81793ca5b38b0e3a0c21 [4/6] arm64: dts: qcom: sm8150: drop incorrect domain idle states properties commit: 770f85c19536fde3591f4f2f70ac32f33d86b975 [5/6] arm64: dts: qcom: sm8350: drop incorrect domain idle states properties commit: 7983224c6a6cea77aa0b9b4e23bb7651241df961 [6/6] arm64: dts: qcom: sc8280xp: drop incorrect domain idle states properties commit: ea1811e2614cd66608961ae3c5a9ee6038fc424b Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index 79d67b466856..9cf2de87c632 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -354,12 +354,10 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 { domain-idle-states { CLUSTER_SLEEP_0: cluster-sleep-0 { compatible = "domain-idle-state"; - idle-state-name = "cluster-llcc-off"; arm,psci-suspend-param = <0x4100c244>; entry-latency-us = <3264>; exit-latency-us = <6562>; min-residency-us = <9987>; - local-timer-stop; }; }; };