Message ID | fd4cf33c68fd103228cf4e6d76959827b187230b.1680273039.git.geert+renesas@glider.be |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp631952vqo; Fri, 31 Mar 2023 08:07:30 -0700 (PDT) X-Google-Smtp-Source: AKy350bFfFa+MfnQJ4YPDFiOKUfS44CJs4GUlbvkFKyF6EfzQ288wULQEcmh5lnknbLGkdDkMsFn X-Received: by 2002:a17:906:5d0b:b0:930:2e3c:c6aa with SMTP id g11-20020a1709065d0b00b009302e3cc6aamr5693152ejt.49.1680275250218; Fri, 31 Mar 2023 08:07:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680275250; cv=none; d=google.com; s=arc-20160816; b=F4yJ59R/J7jUupxZ7sI2lTowy4XXhUKOZN6z/JuthDUzbVj49f4RAAccKKx519l7za 09jNospQpxMqBRMWa0AkFvWQV41DG9kOtLHHVAInyiFmJCoFAzB5fImhYw+eCyaCAD5V E4P6MwRqgBa7bWbKXugDSq46HfHwfJVXlrcvJ6Ek20j2zbeyMTZzE/XVSR7ocMxlp3Wm akQWo99CowwWD1NOM6vuU8LV/NLH8QSi2bvk4g1cstCTiHWRMo67d5raPdTIQ6UjzX0m jyeqwcd3az6+2r/bg8IxwFKMukp76Le9ffyMcV4p3GI5su+ZkCiZZJJInbwwsGpoI7o5 XXGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=hcldYcPvb5eICcimV07zzAuH999B6OHbZRHEfjdu/CY=; b=BjGuqXxCbMCgg9tHvbJCKB2+kmXIr5Hib8CICq4aZFWf4I+vHd1ZleP4AayUXTlnWV tuQFceM/b7lzdL9qxCSIP7i+H7C5xTkoS0mTmsZKStAKJxoW76+n9JKl2icZE4xkNsaP zvKgP7B/rjwxyjIgW2BP25zB0oMWWivbg7XvJHgAdEE6PXGQ5LZmPDEyvxH6QN166dpa mGs5SwRoWqCH07rpGeUuW+eDJOXUcEC9ZEYItWNYjinv70cXdxXjc4x1F/ux0xyhreLo Sj1IbWwrQ0eOVRgPdN//2nKzfkXb1STLpRWWwaSBD+Oor/ZAuT0ivCoF6PRVLyZ9XrXa ZBtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f23-20020a1709062c5700b009474ed68236si1570563ejh.687.2023.03.31.08.07.06; Fri, 31 Mar 2023 08:07:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233103AbjCaOx0 (ORCPT <rfc822;dexuan.linux@gmail.com> + 99 others); Fri, 31 Mar 2023 10:53:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233002AbjCaOxG (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 31 Mar 2023 10:53:06 -0400 Received: from michel.telenet-ops.be (michel.telenet-ops.be [IPv6:2a02:1800:110:4::f00:18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DED4620C12 for <linux-kernel@vger.kernel.org>; Fri, 31 Mar 2023 07:52:41 -0700 (PDT) Received: from ramsan.of.borg ([84.195.187.55]) by michel.telenet-ops.be with bizsmtp id f2se2900k1C8whw062seLc; Fri, 31 Mar 2023 16:52:39 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1piG2N-00FUgj-5w; Fri, 31 Mar 2023 16:48:16 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1piG36-008fIe-Jm; Fri, 31 Mar 2023 16:48:16 +0200 From: Geert Uytterhoeven <geert+renesas@glider.be> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Subject: [PATCH 4/5] drm: shmobile: Add missing call to drm_fbdev_generic_setup() Date: Fri, 31 Mar 2023 16:48:10 +0200 Message-Id: <fd4cf33c68fd103228cf4e6d76959827b187230b.1680273039.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: <cover.1680273039.git.geert+renesas@glider.be> References: <cover.1680273039.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.4 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761896300735799222?= X-GMAIL-MSGID: =?utf-8?q?1761896300735799222?= |
Series |
drm: shmobile: Fixes and enhancements
|
|
Commit Message
Geert Uytterhoeven
March 31, 2023, 2:48 p.m. UTC
Set up generic fbdev emulation, to enable support for the Linux console.
Use 16 as the preferred depth, as that is a good compromise between
colorfulness and resource utilization, and the default of the fbdev
driver.
Suggested-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/gpu/drm/shmobile/shmob_drm_drv.c | 3 +++
1 file changed, 3 insertions(+)
Comments
Hi Geert, Thank you for the patch. On Fri, Mar 31, 2023 at 04:48:10PM +0200, Geert Uytterhoeven wrote: > Set up generic fbdev emulation, to enable support for the Linux console. > > Use 16 as the preferred depth, as that is a good compromise between > colorfulness and resource utilization, and the default of the fbdev > driver. > > Suggested-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > index faacfee24763b1d4..30493ce874192e3e 100644 > --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > @@ -16,6 +16,7 @@ > #include <linux/slab.h> > > #include <drm/drm_drv.h> > +#include <drm/drm_fbdev_generic.h> > #include <drm/drm_gem_dma_helper.h> > #include <drm/drm_module.h> > #include <drm/drm_probe_helper.h> > @@ -271,6 +272,8 @@ static int shmob_drm_probe(struct platform_device *pdev) > if (ret < 0) > goto err_irq_uninstall; > > + drm_fbdev_generic_setup(ddev, 16); > + > return 0; > > err_irq_uninstall:
diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c index faacfee24763b1d4..30493ce874192e3e 100644 --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c @@ -16,6 +16,7 @@ #include <linux/slab.h> #include <drm/drm_drv.h> +#include <drm/drm_fbdev_generic.h> #include <drm/drm_gem_dma_helper.h> #include <drm/drm_module.h> #include <drm/drm_probe_helper.h> @@ -271,6 +272,8 @@ static int shmob_drm_probe(struct platform_device *pdev) if (ret < 0) goto err_irq_uninstall; + drm_fbdev_generic_setup(ddev, 16); + return 0; err_irq_uninstall: