Message ID | 20230329125558.255239-2-juri.lelli@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp399300vqo; Wed, 29 Mar 2023 06:08:36 -0700 (PDT) X-Google-Smtp-Source: AKy350Yfx1Rv52+CfIMmBP6zLF5oxq2nzStyH8yMi+VdNLzmJx4Php2w1kx31lX3InoKb+t1kguP X-Received: by 2002:a17:906:3449:b0:930:9197:24d1 with SMTP id d9-20020a170906344900b00930919724d1mr2436415ejb.6.1680095315880; Wed, 29 Mar 2023 06:08:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680095315; cv=none; d=google.com; s=arc-20160816; b=Hx6FwgqNQ+RaQ5+CkeIWgMJfF8JiFnvbuPul8Xih+ysl50E1YhLB02wLHJJv0DP7ZL d8rOM1qMFNOQCrgtR+pNGKyBSFyw/1ckH5ux/HKwwJW/3vS/+wFq43J9cjccFFTfmEMG hc3WEBeFs7VgZVXmlQB0TqziwKCwDvVYqIZRx/1ckROfmzNACK6RyznblZRu/GWuz7ei nqJLpfRwLL745/dZMcZm2skHSUjjECJf746zo+bDb+U+5YEnTy7LAhjdfU78/mhoDhTA A17qvCvN7KKzt9mqXSUm/ZTVenjV+83QnHzq8fGA8+aC69FTQJww3y06x+td/D6aoKA2 TYkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=e9wz52Em0oDIrgIoF+9rhsFOYzetLxtv432sbjV9gOo=; b=LT7CpnHg3aWHrHfIP99pnDhoLK24RvNgkeJpy2CQz4R9A/Z7ppZtNiEHCNdWyT/rN/ /dPmbcP+qHYkFD7mnRsnCR+xc5ucohs6EArsEEb5uITzYHHHaasl3ZB6AD2AXauQoZjm E+9NReen+A+NMCwkON1RImc4zcoSLL/Hs6oCzA7fTuHFEjkiwCpWwWqh31pxwvZGNK30 YsXgywmoUz/qTOWpwX5wD2/OlepwSuq4vUBwvX6Wk6JdHQOQCcQxIcsY1EQLB2n9YRDF Xr00Jq6F735/8lEz6gXFFz5gGSslV7jPlI0UY6WzT0acVPEHGUlZSClQ/adTtCYfmiqR CslQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ns2R2OLW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i15-20020a1709061ccf00b0092b97d144d0si34958160ejh.157.2023.03.29.06.08.12; Wed, 29 Mar 2023 06:08:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ns2R2OLW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229870AbjC2M5Q (ORCPT <rfc822;rua109.linux@gmail.com> + 99 others); Wed, 29 Mar 2023 08:57:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbjC2M5M (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 29 Mar 2023 08:57:12 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34E5FBA for <linux-kernel@vger.kernel.org>; Wed, 29 Mar 2023 05:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680094583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e9wz52Em0oDIrgIoF+9rhsFOYzetLxtv432sbjV9gOo=; b=Ns2R2OLWTs3HMHv2jcd78K9hSapl5vU1nvEvjikL9EVtLtNCzrWX0DzkXrChfsFCUh/JaL WYnGzbAzgnShVPAzn35UL1yXso0WU5SGKR+7bXUoFGU6zDw3b321aUNP2Yba2id0jXsAO0 Juq8yO/6KkGOosG1u00ypW0DvQzXQr4= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-201-GuScjsHvOp-Ws1NCqnLC6Q-1; Wed, 29 Mar 2023 08:56:22 -0400 X-MC-Unique: GuScjsHvOp-Ws1NCqnLC6Q-1 Received: by mail-qt1-f200.google.com with SMTP id b11-20020ac87fcb000000b003e37d72d532so10163924qtk.18 for <linux-kernel@vger.kernel.org>; Wed, 29 Mar 2023 05:56:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680094581; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e9wz52Em0oDIrgIoF+9rhsFOYzetLxtv432sbjV9gOo=; b=ZPB/9ASJbGRhhi9tQuWV68bWT2zPWb9AMIucoob2NQdwTTPaTffGeT/TE6y56K4USu eXu3UWt3fX3stGzU7ydqdaBo5FxxRYWNg7EJ8Y0SqEOj9MyDrYvAZA1F6uhzYqrKTRWu GM+J5cQxeB2kcphnnIJ/HZ0OKHgxDTA17wVXQPqooZJ2Jjf/P2EoeferdykcRxxltF1i WA0NWXjqB2guoJx9H1hTiv4PuLANHeXKsz4jbmOU9J2fv1o8f3cc5HcaglAtWw7DcfLC CLzl02TBRM+U/+xZZxxYJrGc1Me+K9YQEVhW6dbIcRrlUJDQ0bSXv/f8X2D5lKahOgrx /RSA== X-Gm-Message-State: AAQBX9dW9dpQ1AovKbmUiSM4f0dZu/vV2sy22PmkjPOIpM2Rvv7wPkdO JoLIFb1vSsuRRoG/P3U8b0sfI2Te54MWq0VK+cKEE/kwkOH2elI6iXtyuv5eENGESMDOUPdxru2 aGkmjalFU2vJqKR8J60aLgfpo X-Received: by 2002:a05:6214:194b:b0:5df:450b:8002 with SMTP id q11-20020a056214194b00b005df450b8002mr11421701qvk.31.1680094581746; Wed, 29 Mar 2023 05:56:21 -0700 (PDT) X-Received: by 2002:a05:6214:194b:b0:5df:450b:8002 with SMTP id q11-20020a056214194b00b005df450b8002mr11421668qvk.31.1680094581447; Wed, 29 Mar 2023 05:56:21 -0700 (PDT) Received: from localhost.localdomain.com ([151.29.151.163]) by smtp.gmail.com with ESMTPSA id c23-20020a379a17000000b007436d0e9408sm13527134qke.127.2023.03.29.05.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 05:56:21 -0700 (PDT) From: Juri Lelli <juri.lelli@redhat.com> To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Qais Yousef <qyousef@layalina.io>, Waiman Long <longman@redhat.com>, Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>, Johannes Weiner <hannes@cmpxchg.org>, Hao Luo <haoluo@google.com> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>, Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it, claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it, bristot@redhat.com, mathieu.poirier@linaro.org, cgroups@vger.kernel.org, Vincent Guittot <vincent.guittot@linaro.org>, Wei Wang <wvw@google.com>, Rick Yiu <rickyiu@google.com>, Quentin Perret <qperret@google.com>, Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Alexander Gordeev <agordeev@linux.ibm.com>, Sudeep Holla <sudeep.holla@arm.com>, Juri Lelli <juri.lelli@redhat.com> Subject: [PATCH 1/6] cgroup/cpuset: Rename functions dealing with DEADLINE accounting Date: Wed, 29 Mar 2023 14:55:53 +0200 Message-Id: <20230329125558.255239-2-juri.lelli@redhat.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230329125558.255239-1-juri.lelli@redhat.com> References: <20230329125558.255239-1-juri.lelli@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761707625872639825?= X-GMAIL-MSGID: =?utf-8?q?1761707625872639825?= |
Series |
sched/deadline: cpuset: Rework DEADLINE bandwidth restoration
|
|
Commit Message
Juri Lelli
March 29, 2023, 12:55 p.m. UTC
rebuild_root_domains() and update_tasks_root_domain() have neutral
names, but actually deal with DEADLINE bandwidth accounting.
Rename them to use 'dl_' prefix so that intent is more clear.
No functional change.
Suggested-by: Qais Yousef <qyousef@layalina.io>
Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
---
kernel/cgroup/cpuset.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Comments
On 03/29/23 14:55, Juri Lelli wrote: > rebuild_root_domains() and update_tasks_root_domain() have neutral > names, but actually deal with DEADLINE bandwidth accounting. > > Rename them to use 'dl_' prefix so that intent is more clear. > > No functional change. > > Suggested-by: Qais Yousef <qyousef@layalina.io> > Signed-off-by: Juri Lelli <juri.lelli@redhat.com> > --- Reviewed-by: Qais Yousef <qyousef@layalina.io> Tested-by: Qais Yousef <qyousef@layalina.io> Thanks! -- Qais Yousef > kernel/cgroup/cpuset.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index 636f1c682ac0..501913bc2805 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -1066,7 +1066,7 @@ static int generate_sched_domains(cpumask_var_t **domains, > return ndoms; > } > > -static void update_tasks_root_domain(struct cpuset *cs) > +static void dl_update_tasks_root_domain(struct cpuset *cs) > { > struct css_task_iter it; > struct task_struct *task; > @@ -1079,7 +1079,7 @@ static void update_tasks_root_domain(struct cpuset *cs) > css_task_iter_end(&it); > } > > -static void rebuild_root_domains(void) > +static void dl_rebuild_rd_accounting(void) > { > struct cpuset *cs = NULL; > struct cgroup_subsys_state *pos_css; > @@ -1107,7 +1107,7 @@ static void rebuild_root_domains(void) > > rcu_read_unlock(); > > - update_tasks_root_domain(cs); > + dl_update_tasks_root_domain(cs); > > rcu_read_lock(); > css_put(&cs->css); > @@ -1121,7 +1121,7 @@ partition_and_rebuild_sched_domains(int ndoms_new, cpumask_var_t doms_new[], > { > mutex_lock(&sched_domains_mutex); > partition_sched_domains_locked(ndoms_new, doms_new, dattr_new); > - rebuild_root_domains(); > + dl_rebuild_rd_accounting(); > mutex_unlock(&sched_domains_mutex); > } > > -- > 2.39.2 >
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 636f1c682ac0..501913bc2805 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -1066,7 +1066,7 @@ static int generate_sched_domains(cpumask_var_t **domains, return ndoms; } -static void update_tasks_root_domain(struct cpuset *cs) +static void dl_update_tasks_root_domain(struct cpuset *cs) { struct css_task_iter it; struct task_struct *task; @@ -1079,7 +1079,7 @@ static void update_tasks_root_domain(struct cpuset *cs) css_task_iter_end(&it); } -static void rebuild_root_domains(void) +static void dl_rebuild_rd_accounting(void) { struct cpuset *cs = NULL; struct cgroup_subsys_state *pos_css; @@ -1107,7 +1107,7 @@ static void rebuild_root_domains(void) rcu_read_unlock(); - update_tasks_root_domain(cs); + dl_update_tasks_root_domain(cs); rcu_read_lock(); css_put(&cs->css); @@ -1121,7 +1121,7 @@ partition_and_rebuild_sched_domains(int ndoms_new, cpumask_var_t doms_new[], { mutex_lock(&sched_domains_mutex); partition_sched_domains_locked(ndoms_new, doms_new, dattr_new); - rebuild_root_domains(); + dl_rebuild_rd_accounting(); mutex_unlock(&sched_domains_mutex); }