diff mbox series

MAINTAINERS: qcom: Add reviewer for Qualcomm Chromebooks

Message ID 20230330141051.1.If8eb4f30cb53a00a5bef1b7d3cc645c3536615ec@changeid
State New
Headers
Series MAINTAINERS: qcom: Add reviewer for Qualcomm Chromebooks |

Commit Message

Doug Anderson March 30, 2023, 9:11 p.m. UTC 
  Developers on the ChromeOS team generally want to be notified to
review changes that affect Chromebook device tree files. While we
could individually add developers, the set of developers and the time
each one has available to review patches will change over time. Let's
try adding a group list as a reviewer and see if that's an effective
way to manage things.

A few notes:
* Though this email address is actually backed by a mailing list, I'm
  adding it as "R"eviewer and not "L"ist since it's not a publicly
  readable mailing list and it's intended just to have a few people on
  it. This also hopefully conveys a little more responisbility for the
  people that are part of this group.
* I've added all sc7180 and sc7280 files here. At the moment I'm not
  aware of any non-Chromebooks being supported that use these
  chips. If later something shows up then we can try to narrow down.
* I've added "sdm845-cheza" to this list but not the rest of
  "sdm845". Cheza never shipped but some developers still find the old
  developer boards useful and thus it continues to get minimal
  maintenance. Most sdm845 device tree work, however, seems to be for
  non-Chromebooks.

Cc: Stephen Boyd <swboyd@chromium.org>
Cc: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Konrad Dybcio April 4, 2023, 5:46 p.m. UTC | #1 
On 30.03.2023 23:11, Douglas Anderson wrote:
> Developers on the ChromeOS team generally want to be notified to
> review changes that affect Chromebook device tree files. While we
> could individually add developers, the set of developers and the time
> each one has available to review patches will change over time. Let's
> try adding a group list as a reviewer and see if that's an effective
> way to manage things.
> 
> A few notes:
> * Though this email address is actually backed by a mailing list, I'm
>   adding it as "R"eviewer and not "L"ist since it's not a publicly
>   readable mailing list and it's intended just to have a few people on
>   it. This also hopefully conveys a little more responisbility for the
>   people that are part of this group.
> * I've added all sc7180 and sc7280 files here. At the moment I'm not
>   aware of any non-Chromebooks being supported that use these
>   chips. If later something shows up then we can try to narrow down.
IMO it'd be good if you could keep an eye on all of them, especially
with the quite numerous ways that CrOS fw differs! You're the main
users of the SC7xxx SoCs so it only sounds logical.

> * I've added "sdm845-cheza" to this list but not the rest of
>   "sdm845". Cheza never shipped but some developers still find the old
>   developer boards useful and thus it continues to get minimal
>   maintenance. Most sdm845 device tree work, however, seems to be for
>   non-Chromebooks.
Seems to also still be used in mesa CI

> 
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> 
>  MAINTAINERS | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8d5bc223f305..b4e9c5bda234 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2604,6 +2604,12 @@ F:	include/dt-bindings/*/qcom*
>  F:	include/linux/*/qcom*
>  F:	include/linux/soc/qcom/
>  
> +ARM/QUALCOMM CHROMEBOOK SUPPORT
> +R:	cros-qcom-dts-watchers@chromium.org
> +F:	arch/arm64/boot/dts/qcom/sc7180*
> +F:	arch/arm64/boot/dts/qcom/sc7280*
> +F:	arch/arm64/boot/dts/qcom/sdm845-cheza*
> +
>  ARM/RDA MICRO ARCHITECTURE
>  M:	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>  L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
Stephen Boyd April 4, 2023, 8:17 p.m. UTC | #2 
Quoting Douglas Anderson (2023-03-30 14:11:00)
> Developers on the ChromeOS team generally want to be notified to
> review changes that affect Chromebook device tree files. While we
> could individually add developers, the set of developers and the time
> each one has available to review patches will change over time. Let's
> try adding a group list as a reviewer and see if that's an effective
> way to manage things.
>
> A few notes:
> * Though this email address is actually backed by a mailing list, I'm
>   adding it as "R"eviewer and not "L"ist since it's not a publicly
>   readable mailing list and it's intended just to have a few people on
>   it. This also hopefully conveys a little more responisbility for the
>   people that are part of this group.
> * I've added all sc7180 and sc7280 files here. At the moment I'm not
>   aware of any non-Chromebooks being supported that use these
>   chips. If later something shows up then we can try to narrow down.
> * I've added "sdm845-cheza" to this list but not the rest of
>   "sdm845". Cheza never shipped but some developers still find the old
>   developer boards useful and thus it continues to get minimal
>   maintenance. Most sdm845 device tree work, however, seems to be for
>   non-Chromebooks.
>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Bjorn Andersson April 7, 2023, 5:41 p.m. UTC | #3 
On Thu, 30 Mar 2023 14:11:00 -0700, Douglas Anderson wrote:
> Developers on the ChromeOS team generally want to be notified to
> review changes that affect Chromebook device tree files. While we
> could individually add developers, the set of developers and the time
> each one has available to review patches will change over time. Let's
> try adding a group list as a reviewer and see if that's an effective
> way to manage things.
> 
> [...]

Applied, thanks!

[1/1] MAINTAINERS: qcom: Add reviewer for Qualcomm Chromebooks
      commit: cb5d1dd3a74a7c7c3ad31d5fa2cc00e86c209dcc

Best regards,
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 8d5bc223f305..b4e9c5bda234 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2604,6 +2604,12 @@  F:	include/dt-bindings/*/qcom*
 F:	include/linux/*/qcom*
 F:	include/linux/soc/qcom/
 
+ARM/QUALCOMM CHROMEBOOK SUPPORT
+R:	cros-qcom-dts-watchers@chromium.org
+F:	arch/arm64/boot/dts/qcom/sc7180*
+F:	arch/arm64/boot/dts/qcom/sc7280*
+F:	arch/arm64/boot/dts/qcom/sdm845-cheza*
+
 ARM/RDA MICRO ARCHITECTURE
 M:	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)