diff mbox series

[-next] EDAC/amd64: clean up some inconsistent indentings

Message ID 20230330012057.114811-1-yang.lee@linux.alibaba.com
State New
Headers
Series [-next] EDAC/amd64: clean up some inconsistent indentings |

Commit Message

Yang Li March 30, 2023, 1:20 a.m. UTC 
  drivers/edac/amd64_edac.c:1279 umc_determine_edac_cap() warn: inconsistent indenting

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4639
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/edac/amd64_edac.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Yazen Ghannam April 3, 2023, 5:02 p.m. UTC | #1 
On 3/29/23 21:20, Yang Li wrote:
> drivers/edac/amd64_edac.c:1279 umc_determine_edac_cap() warn: inconsistent indenting
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4639
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---

Hi Yang,

Thanks for the patch.

It looks like this issue was introduced with the following commit.

f6a4b4a1aa16 ("EDAC/amd64: Split determine_edac_cap() into dct/umc functions")

Can you please include a Fixes tag and describe your changes in the commit message?

Thanks,
Yazen
diff mbox series

Patch

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 6dad0f1064c0..5c4292e65b96 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -1276,19 +1276,19 @@  static unsigned long umc_determine_edac_cap(struct amd64_pvt *pvt)
 	u8 i, umc_en_mask = 0, dimm_ecc_en_mask = 0;
 	unsigned long edac_cap = EDAC_FLAG_NONE;
 
-		for_each_umc(i) {
-			if (!(pvt->umc[i].sdp_ctrl & UMC_SDP_INIT))
-				continue;
+	for_each_umc(i) {
+		if (!(pvt->umc[i].sdp_ctrl & UMC_SDP_INIT))
+			continue;
 
-			umc_en_mask |= BIT(i);
+		umc_en_mask |= BIT(i);
 
-			/* UMC Configuration bit 12 (DimmEccEn) */
-			if (pvt->umc[i].umc_cfg & BIT(12))
-				dimm_ecc_en_mask |= BIT(i);
-		}
+		/* UMC Configuration bit 12 (DimmEccEn) */
+		if (pvt->umc[i].umc_cfg & BIT(12))
+			dimm_ecc_en_mask |= BIT(i);
+	}
 
-		if (umc_en_mask == dimm_ecc_en_mask)
-			edac_cap = EDAC_FLAG_SECDED;
+	if (umc_en_mask == dimm_ecc_en_mask)
+		edac_cap = EDAC_FLAG_SECDED;
 
 	return edac_cap;
 }