Message ID | 20221021170605.85163-1-sebastian.reichel@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp809424wrr; Fri, 21 Oct 2022 10:09:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4oEu6CvJYM8VeEFVkzOSxpj1b2cFvAaomfFXfO3XXzCGc6FdlQZFthwOvlrfCNZ7GAtLuO X-Received: by 2002:a17:906:7621:b0:750:c4a3:8fcd with SMTP id c1-20020a170906762100b00750c4a38fcdmr17273561ejn.180.1666372152092; Fri, 21 Oct 2022 10:09:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666372152; cv=none; d=google.com; s=arc-20160816; b=PXlLnsLbftJtBxHbDqG8n3oqAoqH0D+gNF4tieClCdEHFHZIu7Y4t6adR3ryeszKWW JtmOfK35pU7zH+AVlkKBZygA/uWzy6Q5YkEmxFyyb9/Jm1UsxS5ihlXlSbOlaXZzuNgf 6PP8Oz6aaUyv4eEaO7nbflYVrrcmMkFc+0q6q0n4wDvasMSL2RAQxX/oB29uoxmABBaH De3nmEhCEt7GMKwXAPJnQDj0BQ8vwjg4/9CVYZVWsFUcHVHnMzRmo7k9KpofwD6MF2Lr HL+Mrg3deqYIDPgWfOGOuaR3BTxAmY6e+rVvuhxpwIFzFrH8kyTVC3olwImYZs0s3145 53ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Wh5gQLi365Ywt8rDrQSue3SfrTvZ4aU/qLZNYWoStgQ=; b=VG/DETE4aQuwT/78MV95DO6D9ZHmC/61pszSu7VEHWcR8wxeeIzFNvWRKY5qLStT0W YijxM6+WmyqOVeQirktv0wXOYGBFgbMTMQL/0g8AfEXqhcRj5ktsUiOw9NT6HYb70Ra9 PdCW+6Pf+//HEZcTrlPyiGyeOGasZazTTknoH2ZuA3guyYk5voC2kKv+Be4uMZsfWB3n eoV8FJ111LsYJqOIuj1MdvxMgcOSSEtaHMCIc73dzyO/s35xt+YD71iVSQQlfnBbFgb7 5+56uScNFXl0v6OAqy2hQsEHOtm9B1992emO5WMGQnPeDB/lRsxBSenBS5wrqQmM313v FVwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=JyJVvVvI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hq15-20020a1709073f0f00b0078dcd8dfac5si20501211ejc.467.2022.10.21.10.08.35; Fri, 21 Oct 2022 10:09:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=JyJVvVvI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229679AbiJURGt (ORCPT <rfc822;mntrajkot1@gmail.com> + 99 others); Fri, 21 Oct 2022 13:06:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229565AbiJURGo (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 21 Oct 2022 13:06:44 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59FDB17A9D; Fri, 21 Oct 2022 10:06:41 -0700 (PDT) Received: from jupiter.universe (dyndsl-037-138-189-087.ewe-ip-backbone.de [37.138.189.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id C3A8C6602379; Fri, 21 Oct 2022 18:06:39 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666371999; bh=sw1g18/yluc+d5C+pFtuJQ2w1P1wFFgeoQWxi4j7g18=; h=From:To:Cc:Subject:Date:From; b=JyJVvVvIxHtP5Mbeqt8SLO3+c+P9j7Qg0/sS8HVUMW+x0hZr48N01/w/kR70CRBzb gfbWHOKXsuL2vNFYu7ULTvqFq0RJm4xcBklA2pWpJfqbWQwhJSJWt5/qlhgIBWlQ5z L5+8ofW1UWUZB14XiCGzxM5jQ0D/ewq1xs8onqw2Tz0lN1iXFXFEP+dWc7kPERX1e7 kOKrAgKzWO43thKIAYdC2F8j2bZuCLUOU6bNFvty+to2XJMbmMM89vAspVE674w9UH Q6Ii9eWefZ94tJvHpgVAsV9ALV4Q6fMZj96o5jLAOilzYlhmU/NVxYCLF/9nQeMLqW 9vsAhouisNNTA== Received: by jupiter.universe (Postfix, from userid 1000) id AEECF48082E; Fri, 21 Oct 2022 19:06:37 +0200 (CEST) From: Sebastian Reichel <sebastian.reichel@collabora.com> To: Alexandre Belloni <alexandre.belloni@bootlin.com>, Alessandro Zummo <a.zummo@towertech.it>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel <sebastian.reichel@collabora.com>, kernel@collabora.com Subject: [PATCH 1/1] dt-bindings: rtc: convert hym8563 bindings to json-schema Date: Fri, 21 Oct 2022 19:06:05 +0200 Message-Id: <20221021170605.85163-1-sebastian.reichel@collabora.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747317845756282596?= X-GMAIL-MSGID: =?utf-8?q?1747317845756282596?= |
Series |
[1/1] dt-bindings: rtc: convert hym8563 bindings to json-schema
|
|
Commit Message
Sebastian Reichel
Oct. 21, 2022, 5:06 p.m. UTC
Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree
Schema format.
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
.../devicetree/bindings/rtc/haoyu,hym8563.txt | 30 ----------
.../bindings/rtc/haoyu,hym8563.yaml | 55 +++++++++++++++++++
2 files changed, 55 insertions(+), 30 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt
create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
Comments
On Fri, 21 Oct 2022 19:06:05 +0200, Sebastian Reichel wrote: > Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree > Schema format. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > .../devicetree/bindings/rtc/haoyu,hym8563.txt | 30 ---------- > .../bindings/rtc/haoyu,hym8563.yaml | 55 +++++++++++++++++++ > 2 files changed, 55 insertions(+), 30 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ hym8563@51: $nodename:0: 'hym8563@51' does not match '^rtc(@.*|-[0-9a-f])*$' arch/arm64/boot/dts/rockchip/rk3368-orion-r68-meta.dtb arch/arm64/boot/dts/rockchip/rk3368-r88.dtb arch/arm64/boot/dts/rockchip/rk3399pro-rock-pi-n10.dtb arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dtb arch/arm/boot/dts/rk3036-evb.dtb arch/arm/boot/dts/rk3288-evb-act8846.dtb arch/arm/boot/dts/rk3288-firefly-beta.dtb arch/arm/boot/dts/rk3288-firefly.dtb arch/arm/boot/dts/rk3288-firefly-reload.dtb arch/arm/boot/dts/rk3288-miqi.dtb arch/arm/boot/dts/rk3288-rock2-square.dtb hym8563@51: Unevaluated properties are not allowed ('clock-frequency' was unexpected) arch/arm64/boot/dts/rockchip/rk3368-orion-r68-meta.dtb arch/arm64/boot/dts/rockchip/rk3368-r88.dtb arch/arm64/boot/dts/rockchip/rk3399pro-rock-pi-n10.dtb arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dtb arch/arm/boot/dts/rk3036-evb.dtb arch/arm/boot/dts/rk3288-firefly-beta.dtb arch/arm/boot/dts/rk3288-firefly.dtb arch/arm/boot/dts/rk3288-firefly-reload.dtb arch/arm/boot/dts/rk3288-miqi.dtb arch/arm/boot/dts/rk3288-rock2-square.dtb rtc@51: Unevaluated properties are not allowed ('clock-frequency' was unexpected) arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dtb arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dtb arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dtb arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dtb arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb arch/arm/boot/dts/rk3288-rock-pi-n8.dtb
On 21/10/2022 13:06, Sebastian Reichel wrote: > Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree > Schema format. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > .../devicetree/bindings/rtc/haoyu,hym8563.txt | 30 ---------- > .../bindings/rtc/haoyu,hym8563.yaml | 55 +++++++++++++++++++ > 2 files changed, 55 insertions(+), 30 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > deleted file mode 100644 > index a8934fe2ab4c..000000000000 > --- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > +++ /dev/null > @@ -1,30 +0,0 @@ > -Haoyu Microelectronics HYM8563 Real Time Clock > - > -The HYM8563 provides basic rtc and alarm functionality > -as well as a clock output of up to 32kHz. > - > -Required properties: > -- compatible: should be: "haoyu,hym8563" > -- reg: i2c address > -- #clock-cells: the value should be 0 > - > -Optional properties: > -- clock-output-names: From common clock binding > -- interrupts: rtc alarm/event interrupt > - > -Example: > - > -hym8563: hym8563@51 { > - compatible = "haoyu,hym8563"; > - reg = <0x51>; > - > - interrupts = <13 IRQ_TYPE_EDGE_FALLING>; > - > - #clock-cells = <0>; > -}; > - > -device { > -... > - clocks = <&hym8563>; > -... > -}; > diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > new file mode 100644 > index 000000000000..b0b6126b12dd > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license please. I don't think you copied any content from original bindings... unless the example? > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/haoyu,hym8563.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Haoyu Microelectronics HYM8563 RTC > + > +maintainers: > + - Alexandre Belloni <alexandre.belloni@bootlin.com> > + > +properties: > + compatible: > + const: haoyu,hym8563 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + "#clock-cells": > + const: 0 > + > + clock-output-names: > + description: From common clock binding to override the default output clock name. You need maxItems for this. > + > + wakeup-source: > + description: Enables wake up of host system on alarm. > + > +allOf: > + - $ref: rtc.yaml > + > +unevaluatedProperties: false > + Would be great if you could also correct DTS using these bindings (see warning from Rob). Best regards, Krzysztof
On Fri, Oct 21, 2022 at 07:59:26PM -0400, Krzysztof Kozlowski wrote: > On 21/10/2022 13:06, Sebastian Reichel wrote: > > Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree > > Schema format. > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > --- > > .../devicetree/bindings/rtc/haoyu,hym8563.txt | 30 ---------- > > .../bindings/rtc/haoyu,hym8563.yaml | 55 +++++++++++++++++++ > > 2 files changed, 55 insertions(+), 30 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > > create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > > > > diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > > deleted file mode 100644 > > index a8934fe2ab4c..000000000000 > > --- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > > +++ /dev/null > > @@ -1,30 +0,0 @@ > > -Haoyu Microelectronics HYM8563 Real Time Clock > > - > > -The HYM8563 provides basic rtc and alarm functionality > > -as well as a clock output of up to 32kHz. > > - > > -Required properties: > > -- compatible: should be: "haoyu,hym8563" > > -- reg: i2c address > > -- #clock-cells: the value should be 0 > > - > > -Optional properties: > > -- clock-output-names: From common clock binding > > -- interrupts: rtc alarm/event interrupt > > - > > -Example: > > - > > -hym8563: hym8563@51 { > > - compatible = "haoyu,hym8563"; > > - reg = <0x51>; > > - > > - interrupts = <13 IRQ_TYPE_EDGE_FALLING>; > > - > > - #clock-cells = <0>; > > -}; > > - > > -device { > > -... > > - clocks = <&hym8563>; > > -... > > -}; > > diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > > new file mode 100644 > > index 000000000000..b0b6126b12dd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > > @@ -0,0 +1,55 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > Dual license please. I don't think you copied any content from original > bindings... unless the example? > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/rtc/haoyu,hym8563.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Haoyu Microelectronics HYM8563 RTC > > + > > +maintainers: > > + - Alexandre Belloni <alexandre.belloni@bootlin.com> > > + > > +properties: > > + compatible: > > + const: haoyu,hym8563 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + "#clock-cells": > > + const: 0 > > + > > + clock-output-names: > > + description: From common clock binding to override the default output clock name. > > You need maxItems for this. > > > + > > + wakeup-source: > > + description: Enables wake up of host system on alarm. > > + > > +allOf: > > + - $ref: rtc.yaml > > + > > +unevaluatedProperties: false > > + > > Would be great if you could also correct DTS using these bindings (see > warning from Rob). It looked to me like 'clock-frequency' should be added to the schema. Rob
Hi, On Mon, Oct 24, 2022 at 01:50:49PM -0500, Rob Herring wrote: > On Fri, Oct 21, 2022 at 07:59:26PM -0400, Krzysztof Kozlowski wrote: > > On 21/10/2022 13:06, Sebastian Reichel wrote: > > > Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree > > > Schema format. > > > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > > --- > > > .../devicetree/bindings/rtc/haoyu,hym8563.txt | 30 ---------- > > > .../bindings/rtc/haoyu,hym8563.yaml | 55 +++++++++++++++++++ > > > 2 files changed, 55 insertions(+), 30 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > > > create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > > > deleted file mode 100644 > > > index a8934fe2ab4c..000000000000 > > > --- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > > > +++ /dev/null > > > @@ -1,30 +0,0 @@ > > > -Haoyu Microelectronics HYM8563 Real Time Clock > > > - > > > -The HYM8563 provides basic rtc and alarm functionality > > > -as well as a clock output of up to 32kHz. > > > - > > > -Required properties: > > > -- compatible: should be: "haoyu,hym8563" > > > -- reg: i2c address > > > -- #clock-cells: the value should be 0 > > > - > > > -Optional properties: > > > -- clock-output-names: From common clock binding > > > -- interrupts: rtc alarm/event interrupt > > > - > > > -Example: > > > - > > > -hym8563: hym8563@51 { > > > - compatible = "haoyu,hym8563"; > > > - reg = <0x51>; > > > - > > > - interrupts = <13 IRQ_TYPE_EDGE_FALLING>; > > > - > > > - #clock-cells = <0>; > > > -}; > > > - > > > -device { > > > -... > > > - clocks = <&hym8563>; > > > -... > > > -}; > > > diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > > > new file mode 100644 > > > index 000000000000..b0b6126b12dd > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > > > @@ -0,0 +1,55 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > > Dual license please. I don't think you copied any content from original > > bindings... unless the example? > > > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/rtc/haoyu,hym8563.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Haoyu Microelectronics HYM8563 RTC > > > + > > > +maintainers: > > > + - Alexandre Belloni <alexandre.belloni@bootlin.com> > > > + > > > +properties: > > > + compatible: > > > + const: haoyu,hym8563 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + "#clock-cells": > > > + const: 0 > > > + > > > + clock-output-names: > > > + description: From common clock binding to override the default output clock name. > > > > You need maxItems for this. > > > > > + > > > + wakeup-source: > > > + description: Enables wake up of host system on alarm. > > > + > > > +allOf: > > > + - $ref: rtc.yaml > > > + > > > +unevaluatedProperties: false > > > + > > > > Would be great if you could also correct DTS using these bindings (see > > warning from Rob). > > It looked to me like 'clock-frequency' should be added to the schema. I've sent PATCHv2, which removes clock-frequency from all hym8563 users. My reasoning is, that the old txt binding does not describe it and the current Linux driver does not handle it as far as I can see. https://lore.kernel.org/all/20221024165549.74574-1-sebastian.reichel@collabora.com/ -- Sebastian
On 10/25/22 00:05, Sebastian Reichel wrote: > Hi, > > On Mon, Oct 24, 2022 at 01:50:49PM -0500, Rob Herring wrote: >> On Fri, Oct 21, 2022 at 07:59:26PM -0400, Krzysztof Kozlowski wrote: >>> On 21/10/2022 13:06, Sebastian Reichel wrote: >>>> Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree >>>> Schema format. >>>> >>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> >>>> --- >>>> .../devicetree/bindings/rtc/haoyu,hym8563.txt | 30 ---------- >>>> .../bindings/rtc/haoyu,hym8563.yaml | 55 +++++++++++++++++++ >>>> 2 files changed, 55 insertions(+), 30 deletions(-) >>>> delete mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt >>>> create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt >>>> deleted file mode 100644 >>>> index a8934fe2ab4c..000000000000 >>>> --- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt >>>> +++ /dev/null >>>> @@ -1,30 +0,0 @@ >>>> -Haoyu Microelectronics HYM8563 Real Time Clock >>>> - >>>> -The HYM8563 provides basic rtc and alarm functionality >>>> -as well as a clock output of up to 32kHz. >>>> - >>>> -Required properties: >>>> -- compatible: should be: "haoyu,hym8563" >>>> -- reg: i2c address >>>> -- #clock-cells: the value should be 0 >>>> - >>>> -Optional properties: >>>> -- clock-output-names: From common clock binding >>>> -- interrupts: rtc alarm/event interrupt >>>> - >>>> -Example: >>>> - >>>> -hym8563: hym8563@51 { >>>> - compatible = "haoyu,hym8563"; >>>> - reg = <0x51>; >>>> - >>>> - interrupts = <13 IRQ_TYPE_EDGE_FALLING>; >>>> - >>>> - #clock-cells = <0>; >>>> -}; >>>> - >>>> -device { >>>> -... >>>> - clocks = <&hym8563>; >>>> -... >>>> -}; >>>> diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml >>>> new file mode 100644 >>>> index 000000000000..b0b6126b12dd >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml >>>> @@ -0,0 +1,55 @@ >>>> +# SPDX-License-Identifier: GPL-2.0 >>> >>> Dual license please. I don't think you copied any content from original >>> bindings... unless the example? >>> >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/rtc/haoyu,hym8563.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Haoyu Microelectronics HYM8563 RTC >>>> + >>>> +maintainers: >>>> + - Alexandre Belloni <alexandre.belloni@bootlin.com> >>>> + >>>> +properties: >>>> + compatible: >>>> + const: haoyu,hym8563 >>>> + >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + interrupts: >>>> + maxItems: 1 >>>> + >>>> + "#clock-cells": >>>> + const: 0 >>>> + >>>> + clock-output-names: >>>> + description: From common clock binding to override the default output clock name. >>> >>> You need maxItems for this. >>> >>>> + >>>> + wakeup-source: >>>> + description: Enables wake up of host system on alarm. >>>> + >>>> +allOf: >>>> + - $ref: rtc.yaml >>>> + >>>> +unevaluatedProperties: false >>>> + >>> >>> Would be great if you could also correct DTS using these bindings (see >>> warning from Rob). >> >> It looked to me like 'clock-frequency' should be added to the schema. > > I've sent PATCHv2, which removes clock-frequency from all hym8563 > users. My reasoning is, that the old txt binding does not describe > it and the current Linux driver does not handle it as far as I can > see. Didn't note you were doing a conversion as well... From my abandonment patch serie clock-frequency: enum: [1, 32, 1024, 32768] The data sheet shows that it can generate 4 different frequencies. Rockchip mostly uses 32768, but that doesn't mean someone else is not alowed to set what he/she prefers. Johan > > https://lore.kernel.org/all/20221024165549.74574-1-sebastian.reichel@collabora.com/ > > -- Sebastian
Hi, On Thu, Oct 27, 2022 at 06:11:19PM +0200, Johan Jonker wrote: > On 10/25/22 00:05, Sebastian Reichel wrote: > > On Mon, Oct 24, 2022 at 01:50:49PM -0500, Rob Herring wrote: > >> On Fri, Oct 21, 2022 at 07:59:26PM -0400, Krzysztof Kozlowski wrote: > >>> On 21/10/2022 13:06, Sebastian Reichel wrote: > >>>> Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree > >>>> Schema format. > >>>> > >>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > >>>> --- > >>>> .../devicetree/bindings/rtc/haoyu,hym8563.txt | 30 ---------- > >>>> .../bindings/rtc/haoyu,hym8563.yaml | 55 +++++++++++++++++++ > >>>> 2 files changed, 55 insertions(+), 30 deletions(-) > >>>> delete mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > >>>> create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > >>>> deleted file mode 100644 > >>>> index a8934fe2ab4c..000000000000 > >>>> --- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > >>>> +++ /dev/null > >>>> @@ -1,30 +0,0 @@ > >>>> -Haoyu Microelectronics HYM8563 Real Time Clock > >>>> - > >>>> -The HYM8563 provides basic rtc and alarm functionality > >>>> -as well as a clock output of up to 32kHz. > >>>> - > >>>> -Required properties: > >>>> -- compatible: should be: "haoyu,hym8563" > >>>> -- reg: i2c address > >>>> -- #clock-cells: the value should be 0 > >>>> - > >>>> -Optional properties: > >>>> -- clock-output-names: From common clock binding > >>>> -- interrupts: rtc alarm/event interrupt > >>>> - > >>>> -Example: > >>>> - > >>>> -hym8563: hym8563@51 { > >>>> - compatible = "haoyu,hym8563"; > >>>> - reg = <0x51>; > >>>> - > >>>> - interrupts = <13 IRQ_TYPE_EDGE_FALLING>; > >>>> - > >>>> - #clock-cells = <0>; > >>>> -}; > >>>> - > >>>> -device { > >>>> -... > >>>> - clocks = <&hym8563>; > >>>> -... > >>>> -}; > >>>> diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > >>>> new file mode 100644 > >>>> index 000000000000..b0b6126b12dd > >>>> --- /dev/null > >>>> +++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > >>>> @@ -0,0 +1,55 @@ > >>>> +# SPDX-License-Identifier: GPL-2.0 > >>> > >>> Dual license please. I don't think you copied any content from original > >>> bindings... unless the example? > >>> > >>>> +%YAML 1.2 > >>>> +--- > >>>> +$id: http://devicetree.org/schemas/rtc/haoyu,hym8563.yaml# > >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>>> + > >>>> +title: Haoyu Microelectronics HYM8563 RTC > >>>> + > >>>> +maintainers: > >>>> + - Alexandre Belloni <alexandre.belloni@bootlin.com> > >>>> + > >>>> +properties: > >>>> + compatible: > >>>> + const: haoyu,hym8563 > >>>> + > >>>> + reg: > >>>> + maxItems: 1 > >>>> + > >>>> + interrupts: > >>>> + maxItems: 1 > >>>> + > >>>> + "#clock-cells": > >>>> + const: 0 > >>>> + > >>>> + clock-output-names: > >>>> + description: From common clock binding to override the default output clock name. > >>> > >>> You need maxItems for this. > >>> > >>>> + > >>>> + wakeup-source: > >>>> + description: Enables wake up of host system on alarm. > >>>> + > >>>> +allOf: > >>>> + - $ref: rtc.yaml > >>>> + > >>>> +unevaluatedProperties: false > >>>> + > >>> > > >>> Would be great if you could also correct DTS using these bindings (see > >>> warning from Rob). > >> > >> It looked to me like 'clock-frequency' should be added to the schema. > > > > I've sent PATCHv2, which removes clock-frequency from all hym8563 > > users. My reasoning is, that the old txt binding does not describe > > it and the current Linux driver does not handle it as far as I can > > see. > > Didn't note you were doing a conversion as well... > From my abandonment patch serie > > clock-frequency: > enum: [1, 32, 1024, 32768] > > The data sheet shows that it can generate 4 different frequencies. > Rockchip mostly uses 32768, but that doesn't mean someone else is > not alowed to set what he/she prefers. As far as I can tell 32768 has been cargo copied by everyone, but the driver is not parsing this at all and I would expect the clock API to be used for requesting a specific frequency. -- Sebastian
On 10/27/22 18:26, Sebastian Reichel wrote: > Hi, > > On Thu, Oct 27, 2022 at 06:11:19PM +0200, Johan Jonker wrote: >> On 10/25/22 00:05, Sebastian Reichel wrote: >>> On Mon, Oct 24, 2022 at 01:50:49PM -0500, Rob Herring wrote: >>>> On Fri, Oct 21, 2022 at 07:59:26PM -0400, Krzysztof Kozlowski wrote: >>>>> On 21/10/2022 13:06, Sebastian Reichel wrote: >>>>>> Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree >>>>>> Schema format. >>>>>> >>>>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> >>>>>> --- >>>>>> .../devicetree/bindings/rtc/haoyu,hym8563.txt | 30 ---------- >>>>>> .../bindings/rtc/haoyu,hym8563.yaml | 55 +++++++++++++++++++ >>>>>> 2 files changed, 55 insertions(+), 30 deletions(-) >>>>>> delete mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt >>>>>> create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt >>>>>> deleted file mode 100644 >>>>>> index a8934fe2ab4c..000000000000 >>>>>> --- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt >>>>>> +++ /dev/null >>>>>> @@ -1,30 +0,0 @@ >>>>>> -Haoyu Microelectronics HYM8563 Real Time Clock >>>>>> - >>>>>> -The HYM8563 provides basic rtc and alarm functionality >>>>>> -as well as a clock output of up to 32kHz. >>>>>> - >>>>>> -Required properties: >>>>>> -- compatible: should be: "haoyu,hym8563" >>>>>> -- reg: i2c address >>>>>> -- #clock-cells: the value should be 0 >>>>>> - >>>>>> -Optional properties: >>>>>> -- clock-output-names: From common clock binding >>>>>> -- interrupts: rtc alarm/event interrupt >>>>>> - >>>>>> -Example: >>>>>> - >>>>>> -hym8563: hym8563@51 { >>>>>> - compatible = "haoyu,hym8563"; >>>>>> - reg = <0x51>; >>>>>> - >>>>>> - interrupts = <13 IRQ_TYPE_EDGE_FALLING>; >>>>>> - >>>>>> - #clock-cells = <0>; >>>>>> -}; >>>>>> - >>>>>> -device { >>>>>> -... >>>>>> - clocks = <&hym8563>; >>>>>> -... >>>>>> -}; >>>>>> diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml >>>>>> new file mode 100644 >>>>>> index 000000000000..b0b6126b12dd >>>>>> --- /dev/null >>>>>> +++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml >>>>>> @@ -0,0 +1,55 @@ >>>>>> +# SPDX-License-Identifier: GPL-2.0 >>>>> >>>>> Dual license please. I don't think you copied any content from original >>>>> bindings... unless the example? >>>>> >>>>>> +%YAML 1.2 >>>>>> +--- >>>>>> +$id: http://devicetree.org/schemas/rtc/haoyu,hym8563.yaml# >>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>>> + >>>>>> +title: Haoyu Microelectronics HYM8563 RTC >>>>>> + >>>>>> +maintainers: >>>>>> + - Alexandre Belloni <alexandre.belloni@bootlin.com> >>>>>> + >>>>>> +properties: >>>>>> + compatible: >>>>>> + const: haoyu,hym8563 >>>>>> + >>>>>> + reg: >>>>>> + maxItems: 1 >>>>>> + >>>>>> + interrupts: >>>>>> + maxItems: 1 >>>>>> + >>>>>> + "#clock-cells": >>>>>> + const: 0 >>>>>> + >>>>>> + clock-output-names: >>>>>> + description: From common clock binding to override the default output clock name. >>>>> >>>>> You need maxItems for this. >>>>> >>>>>> + >>>>>> + wakeup-source: >>>>>> + description: Enables wake up of host system on alarm. >>>>>> + >>>>>> +allOf: >>>>>> + - $ref: rtc.yaml >>>>>> + >>>>>> +unevaluatedProperties: false >>>>>> + >>>>> >> >>>>> Would be great if you could also correct DTS using these bindings (see >>>>> warning from Rob). >>>> >>>> It looked to me like 'clock-frequency' should be added to the schema. >>> >>> I've sent PATCHv2, which removes clock-frequency from all hym8563 >>> users. My reasoning is, that the old txt binding does not describe >>> it and the current Linux driver does not handle it as far as I can >>> see. >> >> Didn't note you were doing a conversion as well... >> From my abandonment patch serie >> >> clock-frequency: >> enum: [1, 32, 1024, 32768] >> >> The data sheet shows that it can generate 4 different frequencies. >> Rockchip mostly uses 32768, but that doesn't mean someone else is >> not alowed to set what he/she prefers. > > As far as I can tell 32768 has been cargo copied by everyone, but > the driver is not parsing this at all and I would expect the clock > API to be used for requesting a specific frequency. DT and Linux driver support are 2 different things. What Linux currently doesn't support might be needed elsewhere. Johan > > -- Sebastian
On 27/10/2022 18:29:51+0200, Johan Jonker wrote: > > > On 10/27/22 18:26, Sebastian Reichel wrote: > > Hi, > > > > On Thu, Oct 27, 2022 at 06:11:19PM +0200, Johan Jonker wrote: > >> On 10/25/22 00:05, Sebastian Reichel wrote: > >>> On Mon, Oct 24, 2022 at 01:50:49PM -0500, Rob Herring wrote: > >>>> On Fri, Oct 21, 2022 at 07:59:26PM -0400, Krzysztof Kozlowski wrote: > >>>>> On 21/10/2022 13:06, Sebastian Reichel wrote: > >>>>>> Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree > >>>>>> Schema format. > >>>>>> > >>>>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > >>>>>> --- > >>>>>> .../devicetree/bindings/rtc/haoyu,hym8563.txt | 30 ---------- > >>>>>> .../bindings/rtc/haoyu,hym8563.yaml | 55 +++++++++++++++++++ > >>>>>> 2 files changed, 55 insertions(+), 30 deletions(-) > >>>>>> delete mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > >>>>>> create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > >>>>>> > >>>>>> diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > >>>>>> deleted file mode 100644 > >>>>>> index a8934fe2ab4c..000000000000 > >>>>>> --- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > >>>>>> +++ /dev/null > >>>>>> @@ -1,30 +0,0 @@ > >>>>>> -Haoyu Microelectronics HYM8563 Real Time Clock > >>>>>> - > >>>>>> -The HYM8563 provides basic rtc and alarm functionality > >>>>>> -as well as a clock output of up to 32kHz. > >>>>>> - > >>>>>> -Required properties: > >>>>>> -- compatible: should be: "haoyu,hym8563" > >>>>>> -- reg: i2c address > >>>>>> -- #clock-cells: the value should be 0 > >>>>>> - > >>>>>> -Optional properties: > >>>>>> -- clock-output-names: From common clock binding > >>>>>> -- interrupts: rtc alarm/event interrupt > >>>>>> - > >>>>>> -Example: > >>>>>> - > >>>>>> -hym8563: hym8563@51 { > >>>>>> - compatible = "haoyu,hym8563"; > >>>>>> - reg = <0x51>; > >>>>>> - > >>>>>> - interrupts = <13 IRQ_TYPE_EDGE_FALLING>; > >>>>>> - > >>>>>> - #clock-cells = <0>; > >>>>>> -}; > >>>>>> - > >>>>>> -device { > >>>>>> -... > >>>>>> - clocks = <&hym8563>; > >>>>>> -... > >>>>>> -}; > >>>>>> diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > >>>>>> new file mode 100644 > >>>>>> index 000000000000..b0b6126b12dd > >>>>>> --- /dev/null > >>>>>> +++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > >>>>>> @@ -0,0 +1,55 @@ > >>>>>> +# SPDX-License-Identifier: GPL-2.0 > >>>>> > >>>>> Dual license please. I don't think you copied any content from original > >>>>> bindings... unless the example? > >>>>> > >>>>>> +%YAML 1.2 > >>>>>> +--- > >>>>>> +$id: http://devicetree.org/schemas/rtc/haoyu,hym8563.yaml# > >>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>>>>> + > >>>>>> +title: Haoyu Microelectronics HYM8563 RTC > >>>>>> + > >>>>>> +maintainers: > >>>>>> + - Alexandre Belloni <alexandre.belloni@bootlin.com> > >>>>>> + > >>>>>> +properties: > >>>>>> + compatible: > >>>>>> + const: haoyu,hym8563 > >>>>>> + > >>>>>> + reg: > >>>>>> + maxItems: 1 > >>>>>> + > >>>>>> + interrupts: > >>>>>> + maxItems: 1 > >>>>>> + > >>>>>> + "#clock-cells": > >>>>>> + const: 0 > >>>>>> + > >>>>>> + clock-output-names: > >>>>>> + description: From common clock binding to override the default output clock name. > >>>>> > >>>>> You need maxItems for this. > >>>>> > >>>>>> + > >>>>>> + wakeup-source: > >>>>>> + description: Enables wake up of host system on alarm. > >>>>>> + > >>>>>> +allOf: > >>>>>> + - $ref: rtc.yaml > >>>>>> + > >>>>>> +unevaluatedProperties: false > >>>>>> + > >>>>> > >> > >>>>> Would be great if you could also correct DTS using these bindings (see > >>>>> warning from Rob). > >>>> > >>>> It looked to me like 'clock-frequency' should be added to the schema. > >>> > >>> I've sent PATCHv2, which removes clock-frequency from all hym8563 > >>> users. My reasoning is, that the old txt binding does not describe > >>> it and the current Linux driver does not handle it as far as I can > >>> see. > >> > >> Didn't note you were doing a conversion as well... > >> From my abandonment patch serie > >> > >> clock-frequency: > >> enum: [1, 32, 1024, 32768] > >> > >> The data sheet shows that it can generate 4 different frequencies. > >> Rockchip mostly uses 32768, but that doesn't mean someone else is > >> not alowed to set what he/she prefers. > > > > As far as I can tell 32768 has been cargo copied by everyone, but > > the driver is not parsing this at all and I would expect the clock > > API to be used for requesting a specific frequency. > > DT and Linux driver support are 2 different things. > What Linux currently doesn't support might be needed elsewhere. > Yes but being a clock provider is enough for any OS.
diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt deleted file mode 100644 index a8934fe2ab4c..000000000000 --- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt +++ /dev/null @@ -1,30 +0,0 @@ -Haoyu Microelectronics HYM8563 Real Time Clock - -The HYM8563 provides basic rtc and alarm functionality -as well as a clock output of up to 32kHz. - -Required properties: -- compatible: should be: "haoyu,hym8563" -- reg: i2c address -- #clock-cells: the value should be 0 - -Optional properties: -- clock-output-names: From common clock binding -- interrupts: rtc alarm/event interrupt - -Example: - -hym8563: hym8563@51 { - compatible = "haoyu,hym8563"; - reg = <0x51>; - - interrupts = <13 IRQ_TYPE_EDGE_FALLING>; - - #clock-cells = <0>; -}; - -device { -... - clocks = <&hym8563>; -... -}; diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml new file mode 100644 index 000000000000..b0b6126b12dd --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/haoyu,hym8563.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Haoyu Microelectronics HYM8563 RTC + +maintainers: + - Alexandre Belloni <alexandre.belloni@bootlin.com> + +properties: + compatible: + const: haoyu,hym8563 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + "#clock-cells": + const: 0 + + clock-output-names: + description: From common clock binding to override the default output clock name. + + wakeup-source: + description: Enables wake up of host system on alarm. + +allOf: + - $ref: rtc.yaml + +unevaluatedProperties: false + +required: + - compatible + - reg + - "#clock-cells" + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + rtc@51 { + compatible = "haoyu,hym8563"; + reg = <0x51>; + interrupts = <13 IRQ_TYPE_EDGE_FALLING>; + #clock-cells = <0>; + }; + };