diff mbox series

scsi: qedf: remove unused num_handled variable

Message ID 20230330203444.1842425-1-trix@redhat.com
State New
Headers
Series scsi: qedf: remove unused num_handled variable |

Commit Message

Tom Rix March 30, 2023, 8:34 p.m. UTC 
  clang with W=1 reports
drivers/scsi/qedf/qedf_main.c:2227:6: error: variable
  'num_handled' set but not used [-Werror,-Wunused-but-set-variable]
        int num_handled = 0;
            ^
This variable is not used so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/scsi/qedf/qedf_main.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Martin K. Petersen April 3, 2023, 1:45 a.m. UTC | #1 
Tom,

> clang with W=1 reports
> drivers/scsi/qedf/qedf_main.c:2227:6: error: variable
>   'num_handled' set but not used [-Werror,-Wunused-but-set-variable]
>         int num_handled = 0;
>             ^
> This variable is not used so remove it.

Applied to 6.4/scsi-staging, thanks!
Martin K. Petersen April 12, 2023, 2:04 a.m. UTC | #2 
On Thu, 30 Mar 2023 16:34:44 -0400, Tom Rix wrote:

> clang with W=1 reports
> drivers/scsi/qedf/qedf_main.c:2227:6: error: variable
>   'num_handled' set but not used [-Werror,-Wunused-but-set-variable]
>         int num_handled = 0;
>             ^
> This variable is not used so remove it.
> 
> [...]

Applied to 6.4/scsi-queue, thanks!

[1/1] scsi: qedf: remove unused num_handled variable
      https://git.kernel.org/mkp/scsi/c/7866e03b9825
diff mbox series

Patch

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index e7f2560b9f7d..3b64de81ea0d 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -2224,7 +2224,6 @@  static bool qedf_process_completions(struct qedf_fastpath *fp)
 	u16 prod_idx;
 	struct fcoe_cqe *cqe;
 	struct qedf_io_work *io_work;
-	int num_handled = 0;
 	unsigned int cpu;
 	struct qedf_ioreq *io_req = NULL;
 	u16 xid;
@@ -2247,7 +2246,6 @@  static bool qedf_process_completions(struct qedf_fastpath *fp)
 
 	while (new_cqes) {
 		fp->completions++;
-		num_handled++;
 		cqe = &que->cq[que->cq_cons_idx];
 
 		comp_type = (cqe->cqe_data >> FCOE_CQE_CQE_TYPE_SHIFT) &