[v2,1/1] dt-bindings: firmware: qcom: scm: Updating VMID list

Message ID 20230330165117.26348-1-quic_gokukris@quicinc.com
State New
Headers
Series [v2,1/1] dt-bindings: firmware: qcom: scm: Updating VMID list |

Commit Message

Gokul krishna Krishnakumar March 30, 2023, 4:51 p.m. UTC
  Adding the full list of VMID's, which are used by different clients to
pass to the secure world.

Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com>
---
V2 Fixed allignment issues in [1]

[1] https://lore.kernel.org/lkml/20230328214703.12093-1-quic_gokukris@quicinc.com/
---
 include/dt-bindings/firmware/qcom,scm.h | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
  

Comments

Konrad Dybcio March 30, 2023, 10:56 p.m. UTC | #1
On 30.03.2023 18:51, Gokul krishna Krishnakumar wrote:
> Adding the full list of VMID's, which are used by different clients to
> pass to the secure world.
> 
> Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com>
> ---
> V2 Fixed allignment issues in [1]
> 
> [1] https://lore.kernel.org/lkml/20230328214703.12093-1-quic_gokukris@quicinc.com/
> ---
They're weirdly ordered now.. I think Dmitry's comment was
just about the usage of space/tab such that git would not get
confused. With that fixed, you should be able to get a diff like:

+#define QCOM_SCM_VMID_LPASS		0x16
#define QCOM_SCM_VMID_WLAN_CE		0x19
+#define QCOM_SCM_VMID_CP_SPSS_SP	0x1A
[...]
+#define QCOM_SCM_VMID_CP_CDSP		0x2A
#define QCOM_SCM_VMID_NAV		0x2B
+#define QCOM_SCM_VMID_TVM		0x2D

Still, I really appreciate you providing that information to the kernel!

Konrad

>  include/dt-bindings/firmware/qcom,scm.h | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/include/dt-bindings/firmware/qcom,scm.h b/include/dt-bindings/firmware/qcom,scm.h
> index 1a4e68fa0744..7ad6cbe623d3 100644
> --- a/include/dt-bindings/firmware/qcom,scm.h
> +++ b/include/dt-bindings/firmware/qcom,scm.h
> @@ -2,6 +2,7 @@
>  /*
>   * Copyright (c) 2010-2015, 2018-2019 The Linux Foundation. All rights reserved.
>   * Copyright (C) 2015 Linaro Ltd.
> + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
>   */
>  
>  #ifndef _DT_BINDINGS_FIRMWARE_QCOM_SCM_H
> @@ -13,4 +14,25 @@
>  #define QCOM_SCM_VMID_WLAN_CE		0x19
>  #define QCOM_SCM_VMID_NAV		0x2B
>  
> +#define QCOM_SCM_VMID_TZ		0x1
> +#define QCOM_SCM_VMID_CP_TOUCH		0x8
> +#define QCOM_SCM_VMID_CP_BITSTREAM	0x9
> +#define QCOM_SCM_VMID_CP_PIXEL		0xA
> +#define QCOM_SCM_VMID_CP_NON_PIXEL	0xB
> +#define QCOM_SCM_VMID_CP_CAMERA		0xD
> +#define QCOM_SCM_VMID_HLOS_FREE		0xE
> +#define QCOM_SCM_VMID_MSS_NONMSA	0x10
> +#define QCOM_SCM_VMID_CP_SEC_DISPLAY	0x11
> +#define QCOM_SCM_VMID_CP_APP		0x12
> +#define QCOM_SCM_VMID_LPASS		0x16
> +#define QCOM_SCM_VMID_CP_SPSS_SP	0x1A
> +#define QCOM_SCM_VMID_CP_CAMERA_PREVIEW	0x1D
> +#define QCOM_SCM_VMID_CDSP		0x1E
> +#define QCOM_SCM_VMID_CP_SPSS_SP_SHARED	0x22
> +#define QCOM_SCM_VMID_CP_SPSS_HLOS_SHARED	0x24
> +#define QCOM_SCM_VMID_ADSP_HEAP		0x25
> +#define QCOM_SCM_VMID_CP_CDSP		0x2A
> +#define QCOM_SCM_VMID_TVM		0x2D
> +#define QCOM_SCM_VMID_OEMVM		0x31
> +
>  #endif
  
Dmitry Baryshkov March 31, 2023, 4:17 a.m. UTC | #2
On Fri, 31 Mar 2023 at 01:57, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 30.03.2023 18:51, Gokul krishna Krishnakumar wrote:
> > Adding the full list of VMID's, which are used by different clients to
> > pass to the secure world.
> >
> > Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com>
> > ---
> > V2 Fixed allignment issues in [1]
> >
> > [1] https://lore.kernel.org/lkml/20230328214703.12093-1-quic_gokukris@quicinc.com/
> > ---
> They're weirdly ordered now.. I think Dmitry's comment was
> just about the usage of space/tab such that git would not get
> confused. With that fixed, you should be able to get a diff like:
>
> +#define QCOM_SCM_VMID_LPASS            0x16
> #define QCOM_SCM_VMID_WLAN_CE           0x19
> +#define QCOM_SCM_VMID_CP_SPSS_SP       0x1A
> [...]
> +#define QCOM_SCM_VMID_CP_CDSP          0x2A
> #define QCOM_SCM_VMID_NAV               0x2B
> +#define QCOM_SCM_VMID_TVM              0x2D

Yes. Konrad is correct here. Please keep them sorted. I just asked to
keep old lines intact so that we see what was really changed and what
was left intact.

>
> Still, I really appreciate you providing that information to the kernel!
>
> Konrad
>
> >  include/dt-bindings/firmware/qcom,scm.h | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >
> > diff --git a/include/dt-bindings/firmware/qcom,scm.h b/include/dt-bindings/firmware/qcom,scm.h
> > index 1a4e68fa0744..7ad6cbe623d3 100644
> > --- a/include/dt-bindings/firmware/qcom,scm.h
> > +++ b/include/dt-bindings/firmware/qcom,scm.h
> > @@ -2,6 +2,7 @@
> >  /*
> >   * Copyright (c) 2010-2015, 2018-2019 The Linux Foundation. All rights reserved.
> >   * Copyright (C) 2015 Linaro Ltd.
> > + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
> >   */
> >
> >  #ifndef _DT_BINDINGS_FIRMWARE_QCOM_SCM_H
> > @@ -13,4 +14,25 @@
> >  #define QCOM_SCM_VMID_WLAN_CE                0x19
> >  #define QCOM_SCM_VMID_NAV            0x2B
> >
> > +#define QCOM_SCM_VMID_TZ             0x1
> > +#define QCOM_SCM_VMID_CP_TOUCH               0x8
> > +#define QCOM_SCM_VMID_CP_BITSTREAM   0x9
> > +#define QCOM_SCM_VMID_CP_PIXEL               0xA
> > +#define QCOM_SCM_VMID_CP_NON_PIXEL   0xB
> > +#define QCOM_SCM_VMID_CP_CAMERA              0xD
> > +#define QCOM_SCM_VMID_HLOS_FREE              0xE
> > +#define QCOM_SCM_VMID_MSS_NONMSA     0x10
> > +#define QCOM_SCM_VMID_CP_SEC_DISPLAY 0x11
> > +#define QCOM_SCM_VMID_CP_APP         0x12
> > +#define QCOM_SCM_VMID_LPASS          0x16
> > +#define QCOM_SCM_VMID_CP_SPSS_SP     0x1A
> > +#define QCOM_SCM_VMID_CP_CAMERA_PREVIEW      0x1D
> > +#define QCOM_SCM_VMID_CDSP           0x1E
> > +#define QCOM_SCM_VMID_CP_SPSS_SP_SHARED      0x22
> > +#define QCOM_SCM_VMID_CP_SPSS_HLOS_SHARED    0x24
> > +#define QCOM_SCM_VMID_ADSP_HEAP              0x25
> > +#define QCOM_SCM_VMID_CP_CDSP                0x2A
> > +#define QCOM_SCM_VMID_TVM            0x2D
> > +#define QCOM_SCM_VMID_OEMVM          0x31
> > +
> >  #endif
  

Patch

diff --git a/include/dt-bindings/firmware/qcom,scm.h b/include/dt-bindings/firmware/qcom,scm.h
index 1a4e68fa0744..7ad6cbe623d3 100644
--- a/include/dt-bindings/firmware/qcom,scm.h
+++ b/include/dt-bindings/firmware/qcom,scm.h
@@ -2,6 +2,7 @@ 
 /*
  * Copyright (c) 2010-2015, 2018-2019 The Linux Foundation. All rights reserved.
  * Copyright (C) 2015 Linaro Ltd.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  */
 
 #ifndef _DT_BINDINGS_FIRMWARE_QCOM_SCM_H
@@ -13,4 +14,25 @@ 
 #define QCOM_SCM_VMID_WLAN_CE		0x19
 #define QCOM_SCM_VMID_NAV		0x2B
 
+#define QCOM_SCM_VMID_TZ		0x1
+#define QCOM_SCM_VMID_CP_TOUCH		0x8
+#define QCOM_SCM_VMID_CP_BITSTREAM	0x9
+#define QCOM_SCM_VMID_CP_PIXEL		0xA
+#define QCOM_SCM_VMID_CP_NON_PIXEL	0xB
+#define QCOM_SCM_VMID_CP_CAMERA		0xD
+#define QCOM_SCM_VMID_HLOS_FREE		0xE
+#define QCOM_SCM_VMID_MSS_NONMSA	0x10
+#define QCOM_SCM_VMID_CP_SEC_DISPLAY	0x11
+#define QCOM_SCM_VMID_CP_APP		0x12
+#define QCOM_SCM_VMID_LPASS		0x16
+#define QCOM_SCM_VMID_CP_SPSS_SP	0x1A
+#define QCOM_SCM_VMID_CP_CAMERA_PREVIEW	0x1D
+#define QCOM_SCM_VMID_CDSP		0x1E
+#define QCOM_SCM_VMID_CP_SPSS_SP_SHARED	0x22
+#define QCOM_SCM_VMID_CP_SPSS_HLOS_SHARED	0x24
+#define QCOM_SCM_VMID_ADSP_HEAP		0x25
+#define QCOM_SCM_VMID_CP_CDSP		0x2A
+#define QCOM_SCM_VMID_TVM		0x2D
+#define QCOM_SCM_VMID_OEMVM		0x31
+
 #endif