Message ID | 0229879ee3e2d8828707d291cddbb89ac18a10c2.1666945731.git.geert@linux-m68k.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp745971wru; Fri, 28 Oct 2022 03:36:33 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4UwuwyarnLAfuVYFvDn44OMV7NJiUYXDWXhh+qOaCLcRG/6n8n03+9HPdE4G3gYp+drSVZ X-Received: by 2002:a17:906:8458:b0:7ac:a48d:a680 with SMTP id e24-20020a170906845800b007aca48da680mr16171712ejy.105.1666953383060; Fri, 28 Oct 2022 03:36:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666953383; cv=none; d=google.com; s=arc-20160816; b=qX3dHiVkdlafyvCqcLRDcc/cpbQwnur+4pX/uR6sO5FmbX/bewl5YOYFcBCXA6Kut3 Dc3qFKR/viOj4ELsw/iSqTfdiLR7oqscsaAK1BzVoyMeoxVWN3MackHYzskAyxoPEmJi jxw3+b++ZqhjPkC7hzqLmf8EtEH/SDm1LEo6yU6v7eCt6aqg8RZ1bmfXNt9jHmR9F5IK j5K8t/WnJwai8Xwd36SEOpJnQDR9xZLNV9lrucz2jNc350S8qoe3jYmcpwinSaprVYBz XVdvanIaj5Vu+laJQOvFmb1aMY9/bH/ddErjXGEJeEVd+5J1TrtJpL11zRuNmoeBDAjY hJiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ugtHb3I4pn3MhmF1W2WaMWT2PCYg6prOUyeqwoNGBKk=; b=lYhb3iCR5fnW/jzovWAfEp2pONppW2SC0e/Q1WNL8+HJylEx4WmZK9ZJeSQ+YsdB+D T/S6NZsF5f9oiBsj9SEJLRj841jBj8hqSwSeTlw1PO7JsWD56wkgnRjAdZdzrQTD1U2/ BXTvaQwqoVeafsATJHx3IfjEGJuA3l7YsI5VCuQRAtU49t61hnsgEO40rpEJOY6U19pM WldwSZJ41L7k6sxe62Z/p+PNJBllqX1cmKu5rGwXMUtRQiKiaVGCIzCbjmPZ+xINps/w R4DV/xO7asAkDhiRG7HIfznCXkg0XrVZ+ckC3yFlwYLW58PZgL1iCEFwZlHLaaM+1r74 BIIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hz5-20020a1709072ce500b007ab1b8b719csi3972606ejc.0.2022.10.28.03.35.59; Fri, 28 Oct 2022 03:36:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229875AbiJ1K3k (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Fri, 28 Oct 2022 06:29:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229744AbiJ1K3h (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 28 Oct 2022 06:29:37 -0400 Received: from laurent.telenet-ops.be (laurent.telenet-ops.be [IPv6:2a02:1800:110:4::f00:19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47FAA5598 for <linux-kernel@vger.kernel.org>; Fri, 28 Oct 2022 03:29:30 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed10:53a:31ee:412:433f]) by laurent.telenet-ops.be with bizsmtp id dNVV2800V5LQXpN01NVVUY; Fri, 28 Oct 2022 12:29:29 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from <geert@linux-m68k.org>) id 1ooMJq-001vO6-8p; Fri, 28 Oct 2022 12:10:30 +0200 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from <geert@linux-m68k.org>) id 1ooKl1-00GUW4-28; Fri, 28 Oct 2022 10:30:27 +0200 From: Geert Uytterhoeven <geert@linux-m68k.org> To: linux-m68k@lists.linux-m68k.org Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org>, Michael Schmitz <schmitzmic@gmail.com> Subject: [PATCH] m68k: mac: Reword comment using double "in" Date: Fri, 28 Oct 2022 10:30:26 +0200 Message-Id: <0229879ee3e2d8828707d291cddbb89ac18a10c2.1666945731.git.geert@linux-m68k.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747927310702023490?= X-GMAIL-MSGID: =?utf-8?q?1747927310702023490?= |
Series |
m68k: mac: Reword comment using double "in"
|
|
Commit Message
Geert Uytterhoeven
Oct. 28, 2022, 8:30 a.m. UTC
People keep on sending (incorrect) patches to remove the second
occurrence of the word "in". Reword the comment to stop the inflood.
Suggested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
To be queued in the m68k branch for v6.2.
arch/m68k/mac/misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Oct 28, 2022 at 10:30:26AM +0200, Geert Uytterhoeven wrote: > People keep on sending (incorrect) patches to remove the second > occurrence of the word "in". Reword the comment to stop the inflood. > Ah! People who aren't fluent in English think that duplicated "in" below isn't OK, which after stripping that become nonsense without reading the actual code. > Suggested-by: Michael Schmitz <schmitzmic@gmail.com> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > To be queued in the m68k branch for v6.2. Should this patch be Cc: stable'ed so that no more trivial patches as you mentioned? > > arch/m68k/mac/misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c > index 4fab3479175865d4..c7cb29f0ff016360 100644 > --- a/arch/m68k/mac/misc.c > +++ b/arch/m68k/mac/misc.c > @@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data) > > reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData); > > - /* The bits of the byte go in in MSB order */ > + /* The bits of the byte go into the RTC in MSB order */ > LGTM, thanks. Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
Hi Bagas, On Fri, Oct 28, 2022 at 3:01 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote: > On Fri, Oct 28, 2022 at 10:30:26AM +0200, Geert Uytterhoeven wrote: > > People keep on sending (incorrect) patches to remove the second > > occurrence of the word "in". Reword the comment to stop the inflood. > > Ah! People who aren't fluent in English think that duplicated "in" below > isn't OK, which after stripping that become nonsense without reading the > actual code. > > > Suggested-by: Michael Schmitz <schmitzmic@gmail.com> > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > --- > > To be queued in the m68k branch for v6.2. > > Should this patch be Cc: stable'ed so that no more trivial patches as > you mentioned? People should not be sending patches against stable in the first place. Once this makes it upstream, the inflow should stop (hopefully ;-) > Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c index 4fab3479175865d4..c7cb29f0ff016360 100644 --- a/arch/m68k/mac/misc.c +++ b/arch/m68k/mac/misc.c @@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data) reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData); - /* The bits of the byte go in in MSB order */ + /* The bits of the byte go into the RTC in MSB order */ for (i = 0 ; i < 8 ; i++) { bit = data & 0x80? 1 : 0;