Message ID | 20230320142103.3440-1-linmengbo0689@protonmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1247911wrt; Mon, 20 Mar 2023 07:27:39 -0700 (PDT) X-Google-Smtp-Source: AK7set9QymP48ed0V2f9y1ikbI2gs68kKqJAPyAGI648RNLCtiFGvZl2muPgMvlm0zSNpFYcIxoT X-Received: by 2002:a17:90a:1950:b0:23f:e48:8bde with SMTP id 16-20020a17090a195000b0023f0e488bdemr18645623pjh.27.1679322459534; Mon, 20 Mar 2023 07:27:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679322459; cv=none; d=google.com; s=arc-20160816; b=s+oQVuIXLc3JYl01hVN0l5aRPrc85UDm49lvZuU+ZUb/hW5Tx9OJqaH9qFTMy3Cgby t+hiXhZ4o79D6g6fQkqk75BWMDBRokCdU8TZkl+AeZySvdUfzRwp+BY/glpdZAO2ftyD NYrCRDwXQOc+26CBZClG9/Ha5KY0Ku2JazEF74urqm8WteTkiM2UA4sEOCj4NLKEVK5M StXXVNHJvYv6UFX846ME++GnJE7uN1w2hIiPwqfd4R0uNiLzKreLSnp3JuVcrb4ajMRs FdzNundTWj0GKrpwQmUmdrxDE1c7ZbU8NRcFhIZOp2B1bWzuM41CtAXXUSaPoXcKHDX+ B+5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :feedback-id:references:in-reply-to:message-id:subject:cc:from:to :dkim-signature:date; bh=PyBkroZpp5Idh5EiLvqP12MWQHI/I6jk1Thl/HtlRy0=; b=V23C9kkPX64HuFY9HVPl5n9iw+tvpir1CWxbqtU9UE7RG+OD3JN9bdwVqkgsfjxR4q 6YlT2PY+gnuW8qbyY9YYVSopawcAhwR2JY7z611eJzvfYKEEuWLIYt8bRehiRZQpvUYR mOI9e37F5U06dZnuO3AtnIcuHfUcnaiqQQ3zce6hwVWKzouiwZuSVUMFA4sT53QvZX/j IUrbSj5w2mpVYSfMFiZvW9LwJRWICoROptFg4EXDcGRczltzUyIjZB3zp4/LIzgdCVy7 iJGQtSSQ0UdpYeXjQGGOCMzplCnUnS/w+joKmq58PqzkuRdf8uXGo6m0wyHCD+up/hGR BZfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=q2mL4lvg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q67-20020a17090a1b4900b00233e50c1117si9992949pjq.71.2023.03.20.07.27.26; Mon, 20 Mar 2023 07:27:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=q2mL4lvg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231239AbjCTOWo (ORCPT <rfc822;pusanteemu@gmail.com> + 99 others); Mon, 20 Mar 2023 10:22:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231625AbjCTOWl (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 20 Mar 2023 10:22:41 -0400 Received: from mail-0201.mail-europe.com (mail-0201.mail-europe.com [51.77.79.158]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A3232203D; Mon, 20 Mar 2023 07:22:38 -0700 (PDT) Date: Mon, 20 Mar 2023 14:22:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1679322154; x=1679581354; bh=PyBkroZpp5Idh5EiLvqP12MWQHI/I6jk1Thl/HtlRy0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=q2mL4lvgqq6/UT0kzVkGmepQtIBR6RAoGnxho6bvKGLlC4mnjndRTyRybHHjkrQG9 o3/KldHRayXXuqnvLQWQNJEuS0hX722OevRqQksAJ7Dj/Tmv+UBcmjjJGSsvjb+e3B BSxTABGUPWgHtLcgChRVgth7FvhxLgwf2ncmf7YSw8UzuXN9Jvh1WSJwKjF7yeST21 kEp1TTmxo/zZXvjexnHrXq1SHs9pnpKn5CohBY9Kv6UrGQ3FPDWfhux0OCQlaCh++l QhR+Jgad6PLbRbBq0pY6wyQ4myRQT7qygFd3qNEo2fOvu8OHbgecHZpMEyw8N1gBW5 hpXXhAuZahOpw== To: linux-kernel@vger.kernel.org From: "Lin, Meng-Bo" <linmengbo0689@protonmail.com> Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Nikita Travkin <nikita@trvn.ru>, Stephan Gerhold <stephan@gerhold.net>, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: [PATCH 1/2] dt-bindings: leds: aw2013: Document vdd-supply Message-ID: <20230320142103.3440-1-linmengbo0689@protonmail.com> In-Reply-To: <20230320141638.3378-1-linmengbo0689@protonmail.com> References: <20230320141638.3378-1-linmengbo0689@protonmail.com> Feedback-ID: 40467236:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760897227344803803?= X-GMAIL-MSGID: =?utf-8?q?1760897227344803803?= |
Series |
leds: aw2013: Add vdd regulator
|
|
Commit Message
Lin, Meng-Bo
March 20, 2023, 2:22 p.m. UTC
Document vdd-supply, a regulator providing power to the "VDD" pin.
Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
---
Documentation/devicetree/bindings/leds/leds-aw2013.yaml | 3 +++
1 file changed, 3 insertions(+)
Comments
On 20/03/2023 15:22, Lin, Meng-Bo wrote: > Document vdd-supply, a regulator providing power to the "VDD" pin. > No. This device does not have VDD pin. I checked in datasheet. Best regards, Krzysztof
On Mon, 20 Mar 2023, Krzysztof Kozlowski wrote: > On 20/03/2023 15:22, Lin, Meng-Bo wrote: > > Document vdd-supply, a regulator providing power to the "VDD" pin. > > > > No. This device does not have VDD pin. I checked in datasheet. I'm confused. This patch set much do something? I guess a better commit message would help. Let me request that. -- Lee Jones [李琼斯]
On 30/03/2023 13:46, Lee Jones wrote: > On Mon, 20 Mar 2023, Krzysztof Kozlowski wrote: > >> On 20/03/2023 15:22, Lin, Meng-Bo wrote: >>> Document vdd-supply, a regulator providing power to the "VDD" pin. >>> >> >> No. This device does not have VDD pin. I checked in datasheet. > > I'm confused. This patch set much do something? > > I guess a better commit message would help. Let me request that. There was a v2 - with a discussion - so we wait for v3 which clearly indicates this is supply on controller side. IMHO, this is still wrong because it is controller's property, not device's, but Rob gave here green light, so v3 with proper explanation would be fine. Best regards, Krzysztof
On Thu, 30 Mar 2023, Krzysztof Kozlowski wrote: > On 30/03/2023 13:46, Lee Jones wrote: > > On Mon, 20 Mar 2023, Krzysztof Kozlowski wrote: > > > >> On 20/03/2023 15:22, Lin, Meng-Bo wrote: > >>> Document vdd-supply, a regulator providing power to the "VDD" pin. > >>> > >> > >> No. This device does not have VDD pin. I checked in datasheet. > > > > I'm confused. This patch set much do something? > > > > I guess a better commit message would help. Let me request that. > > There was a v2 - with a discussion - so we wait for v3 which clearly > indicates this is supply on controller side. IMHO, this is still wrong > because it is controller's property, not device's, but Rob gave here > green light, so v3 with proper explanation would be fine. Understood, thanks. -- Lee Jones [李琼斯]
diff --git a/Documentation/devicetree/bindings/leds/leds-aw2013.yaml b/Documentation/devicetree/bindings/leds/leds-aw2013.yaml index 08f3e1cfc1b1..51a58f4b8ed6 100644 --- a/Documentation/devicetree/bindings/leds/leds-aw2013.yaml +++ b/Documentation/devicetree/bindings/leds/leds-aw2013.yaml @@ -23,6 +23,9 @@ properties: vcc-supply: description: Regulator providing power to the "VCC" pin. + vdd-supply: + description: Regulator providing power to the "VDD" pin. + "#address-cells": const: 1