diff mbox series

[v1] mfd:mcp-core.c : Remove redundant driver match function

Message ID 20230319040149.216919-1-sensor1010@163.com
State New
Headers
Series [v1] mfd:mcp-core.c : Remove redundant driver match function |

Commit Message

Lizhe March 19, 2023, 4:01 a.m. UTC 
  If there is no driver_match function, the driver core assumes that each
candidate pair (driver, device)matches, see driver_match_device()

Signed-off-by: Lizhe <sensor1010@163.com>
---
 drivers/mfd/mcp-core.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Lee Jones March 30, 2023, 11:02 a.m. UTC | #1 
As a nice exercise, I'd like you to fix the subject line please.

It should match the subsystem you're applying to, with no errors.

`git log --oneline -- drivers/mfd` is your friend here.

On Sun, 19 Mar 2023, Lizhe wrote:

> If there is no driver_match function, the driver core assumes that each
> candidate pair (driver, device)matches, see driver_match_device()

Attention to detail please.  This contains whitespace issues and a lack
of punctuation.

> Signed-off-by: Lizhe <sensor1010@163.com>

You should really be using your full name.

> ---
>  drivers/mfd/mcp-core.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/mfd/mcp-core.c b/drivers/mfd/mcp-core.c
> index 2fa592c37c6f..281a9369f2b3 100644
> --- a/drivers/mfd/mcp-core.c
> +++ b/drivers/mfd/mcp-core.c
> @@ -20,11 +20,6 @@
>  #define to_mcp(d)		container_of(d, struct mcp, attached_device)
>  #define to_mcp_driver(d)	container_of(d, struct mcp_driver, drv)
>
> -static int mcp_bus_match(struct device *dev, struct device_driver *drv)
> -{
> -	return 1;
> -}
> -
>  static int mcp_bus_probe(struct device *dev)
>  {
>  	struct mcp *mcp = to_mcp(dev);
> @@ -43,7 +38,6 @@ static void mcp_bus_remove(struct device *dev)
>
>  static struct bus_type mcp_bus_type = {
>  	.name		= "mcp",
> -	.match		= mcp_bus_match,
>  	.probe		= mcp_bus_probe,
>  	.remove		= mcp_bus_remove,
>  };

The code is fine.

--
Lee Jones [李琼斯]
diff mbox series

Patch

diff --git a/drivers/mfd/mcp-core.c b/drivers/mfd/mcp-core.c
index 2fa592c37c6f..281a9369f2b3 100644
--- a/drivers/mfd/mcp-core.c
+++ b/drivers/mfd/mcp-core.c
@@ -20,11 +20,6 @@ 
 #define to_mcp(d)		container_of(d, struct mcp, attached_device)
 #define to_mcp_driver(d)	container_of(d, struct mcp_driver, drv)
 
-static int mcp_bus_match(struct device *dev, struct device_driver *drv)
-{
-	return 1;
-}
-
 static int mcp_bus_probe(struct device *dev)
 {
 	struct mcp *mcp = to_mcp(dev);
@@ -43,7 +38,6 @@  static void mcp_bus_remove(struct device *dev)
 
 static struct bus_type mcp_bus_type = {
 	.name		= "mcp",
-	.match		= mcp_bus_match,
 	.probe		= mcp_bus_probe,
 	.remove		= mcp_bus_remove,
 };