Message ID | 526f822a4d2397284f70ba632d92feaa3db0143e.1679909245.git.quic_varada@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1383348vqo; Mon, 27 Mar 2023 02:41:50 -0700 (PDT) X-Google-Smtp-Source: AKy350YckQOld/v0387TjBdFCSf8NSIssRT63yvUR8tT67qd9RJqS1Vuk35DbQ/29rjuRfj7/n3T X-Received: by 2002:a17:90b:1e01:b0:23f:b35b:7789 with SMTP id pg1-20020a17090b1e0100b0023fb35b7789mr12264777pjb.28.1679910110386; Mon, 27 Mar 2023 02:41:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679910110; cv=none; d=google.com; s=arc-20160816; b=vZPUhgtUrrwo4CQdcPAig167b7TknopN6A9KnnrpZyTDeCDkX+ZnHyMT5zb6iR9BOt mLjyhdPRBeM9SIQfsUFQrpf6EzbnoZgZoD8q3wMwQXkESnr9/ZKPBUqsR4vKxzUawV/R BEwC7H1NYTiBGVSbOD/7SCAkdYLUqqQHS0rpzu6xZkIGgEXMS/he7gfDzVmGLj6F8kuP IVJ3X4St8VfUqQW4sJVD8ImYGrg2R5loFsoYz+t9iA/154lEiQC7mITSMjrEimr2DbWR O8gGzhlYs0Be23edX7q8eRrYfKcnrtBt3zBRZti8ucM67/2WJPUU/NDxu9xkcx3wlUel gKag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=WuY0OLeSjLRrqef/sRH5TYF3Q/P/HVHVaV/DzVxgL94=; b=yOkbCnbX336RiyVraI8kmNeV5n4pvm9mgwtS9lOgdaU1eb4qQ4goNnuJJBlNNDppYe hHXSJB01lZ7orHrW0o6XY+5SnLJ7PU4romHZuomJkkSrINZ98Z81BjgcR7eezY+vSNQL Ka7pFLOwTLjdITwMw1CBmVUgkF5n1gRICcQ1a9dTWq0npV4SMf9AcYRulOE9Ycd7FV4j JApSFMhoK3jb31vjDAV5SvT+87PoKzznp7ew62Pi3NfZ9A/P1UBBtfkAFJIZa8GWPsBq 6COYeD3lHqbLHEuNaTt0ImrgQWMINWMMUau/ZYfpEsMFvAPogjgvfhzv7UKikAFsdDow bqHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=OBirZohn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v135-20020a63618d000000b005131132bff0si10604336pgb.252.2023.03.27.02.41.37; Mon, 27 Mar 2023 02:41:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=OBirZohn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233300AbjC0JcH (ORCPT <rfc822;makky5685@gmail.com> + 99 others); Mon, 27 Mar 2023 05:32:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233295AbjC0Jb5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 27 Mar 2023 05:31:57 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FE494EE4; Mon, 27 Mar 2023 02:31:52 -0700 (PDT) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32R1RNtC028389; Mon, 27 Mar 2023 09:31:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=WuY0OLeSjLRrqef/sRH5TYF3Q/P/HVHVaV/DzVxgL94=; b=OBirZohn+xSQ1WoVIX9B5u3/CdjhcczWbqMLIxXatj5pJykwyM9+won6hGlNtAGPW2EI pMHCEuDEOdwbpKbTksH2d3AFjnWLPCwNdpvi4+ApRWYYDrcB4ltuUqx8Er2dKpJmkIS2 UDOjfY+fX+DiZcEBcc1BMNM6Z7WLFEEHg4gMdUqVR8OkfE1TCz/i8hB8OziPiKe05ASx 1fFBjbxZF+ewzp4syVZBHtnh9XlYKG8YxPAEF5K6dc7Q6aBeFe5vi8m9OEL8OG6gglmb 6wfkF21+qn/zK2cRjFWOJFo/bsvtTRDnRiaZbVG1wrZo97HZp0uEg0MueC5ePm1vd/e9 aw== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pht8f3ypd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Mar 2023 09:31:46 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32R9Vktk016599 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Mar 2023 09:31:46 GMT Received: from varda-linux.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 27 Mar 2023 02:31:40 -0700 From: Varadarajan Narayanan <quic_varada@quicinc.com> To: <agross@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <vkoul@kernel.org>, <kishon@kernel.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <gregkh@linuxfoundation.org>, <mturquette@baylibre.com>, <sboyd@kernel.org>, <quic_wcheng@quicinc.com>, <linux-arm-msm@vger.kernel.org>, <linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>, <linux-clk@vger.kernel.org> CC: Varadarajan Narayanan <quic_varada@quicinc.com> Subject: [PATCH v4 3/8] dt-bindings: usb: dwc3: Add IPQ9574 compatible Date: Mon, 27 Mar 2023 15:00:55 +0530 Message-ID: <526f822a4d2397284f70ba632d92feaa3db0143e.1679909245.git.quic_varada@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <cover.1679909245.git.quic_varada@quicinc.com> References: <cover.1679909245.git.quic_varada@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: lwi6aR89MImuoawXYY82_MQzEfGRRdgI X-Proofpoint-ORIG-GUID: lwi6aR89MImuoawXYY82_MQzEfGRRdgI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_11,2023-03-24_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 suspectscore=0 malwarescore=0 impostorscore=0 clxscore=1015 mlxlogscore=929 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303270077 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761513424167199313?= X-GMAIL-MSGID: =?utf-8?q?1761513424167199313?= |
Series |
Enable IPQ9754 USB
|
|
Commit Message
Varadarajan Narayanan
March 27, 2023, 9:30 a.m. UTC
Document the IPQ9574 dwc3 compatible.
Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
---
Changes in v4:
- Update other relevant sections
- Remove constraints not applicable to IPQ9574
---
.../devicetree/bindings/usb/qcom,dwc3.yaml | 22 +++++++++++++++++++---
1 file changed, 19 insertions(+), 3 deletions(-)
Comments
On 27/03/2023 11:30, Varadarajan Narayanan wrote: > Document the IPQ9574 dwc3 compatible. > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > Changes in v4: > - Update other relevant sections > - Remove constraints not applicable to IPQ9574 No, that's not way to go. These are required. > --- > .../devicetree/bindings/usb/qcom,dwc3.yaml | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > index a2aabda..3fc8c3c 100644 > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > @@ -17,6 +17,7 @@ properties: > - qcom,ipq6018-dwc3 > - qcom,ipq8064-dwc3 > - qcom,ipq8074-dwc3 > + - qcom,ipq9574-dwc3 > - qcom,msm8953-dwc3 > - qcom,msm8994-dwc3 > - qcom,msm8996-dwc3 > @@ -132,11 +133,8 @@ required: > - "#address-cells" > - "#size-cells" > - ranges > - - power-domains > - clocks > - clock-names > - - interrupts > - - interrupt-names > > allOf: > - if: > @@ -242,6 +240,24 @@ allOf: > compatible: > contains: > enum: > + - qcom,ipq9574-dwc3 > + then: > + properties: > + clocks: > + maxItems: 5 > + clock-names: > + items: > + - const: sys_noc_axi > + - const: anoc_axi Heh, do we really need entirely different clock names for each new variant? Best regards, Krzysztof
On Tue, Mar 28, 2023 at 09:11:38AM +0200, Krzysztof Kozlowski wrote: > On 27/03/2023 11:30, Varadarajan Narayanan wrote: > > Document the IPQ9574 dwc3 compatible. > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > Changes in v4: > > - Update other relevant sections > > - Remove constraints not applicable to IPQ9574 > > No, that's not way to go. These are required. Yes. Misinterpreted an earlier comment. Will fix this. > > --- > > .../devicetree/bindings/usb/qcom,dwc3.yaml | 22 +++++++++++++++++++--- > > 1 file changed, 19 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > > index a2aabda..3fc8c3c 100644 > > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > > @@ -17,6 +17,7 @@ properties: > > - qcom,ipq6018-dwc3 > > - qcom,ipq8064-dwc3 > > - qcom,ipq8074-dwc3 > > + - qcom,ipq9574-dwc3 > > - qcom,msm8953-dwc3 > > - qcom,msm8994-dwc3 > > - qcom,msm8996-dwc3 > > @@ -132,11 +133,8 @@ required: > > - "#address-cells" > > - "#size-cells" > > - ranges > > - - power-domains > > - clocks > > - clock-names > > - - interrupts > > - - interrupt-names > > > > allOf: > > - if: > > @@ -242,6 +240,24 @@ allOf: > > compatible: > > contains: > > enum: > > + - qcom,ipq9574-dwc3 > > + then: > > + properties: > > + clocks: > > + maxItems: 5 > > + clock-names: > > + items: > > + - const: sys_noc_axi > > + - const: anoc_axi > > Heh, do we really need entirely different clock names for each new variant? Will fix and post a new patch. Thanks Varada > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml index a2aabda..3fc8c3c 100644 --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml @@ -17,6 +17,7 @@ properties: - qcom,ipq6018-dwc3 - qcom,ipq8064-dwc3 - qcom,ipq8074-dwc3 + - qcom,ipq9574-dwc3 - qcom,msm8953-dwc3 - qcom,msm8994-dwc3 - qcom,msm8996-dwc3 @@ -132,11 +133,8 @@ required: - "#address-cells" - "#size-cells" - ranges - - power-domains - clocks - clock-names - - interrupts - - interrupt-names allOf: - if: @@ -242,6 +240,24 @@ allOf: compatible: contains: enum: + - qcom,ipq9574-dwc3 + then: + properties: + clocks: + maxItems: 5 + clock-names: + items: + - const: sys_noc_axi + - const: anoc_axi + - const: master + - const: sleep + - const: mock_utmi + + - if: + properties: + compatible: + contains: + enum: - qcom,msm8994-dwc3 - qcom,qcs404-dwc3 then: