Message ID | 20230307132928.3887737-1-konrad.dybcio@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2434745wrd; Tue, 7 Mar 2023 05:41:41 -0800 (PST) X-Google-Smtp-Source: AK7set8vNIN2gbiDYJ4UD+OcwhAFnB7EvEKlgn/v6E6/jDadORaz2Nv1/wXSgrEtRu3jyovydiFv X-Received: by 2002:a17:906:308e:b0:8b1:7aaa:4c25 with SMTP id 14-20020a170906308e00b008b17aaa4c25mr14076313ejv.29.1678196500992; Tue, 07 Mar 2023 05:41:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678196500; cv=none; d=google.com; s=arc-20160816; b=f5dNW9E+BWha+Sij1ah9Q3Oo+REMTsYGRCgNZgO2JAGyOz62XaqrSc1OROBoAlGlq1 rSu/hTJpBlaRWaInZI9BaX2mDaQ+XypE85aRDUF5oUfHnHiap9GNWitjB4Dq+LS/pccq R12i9n9fgaljyPJtnStywlEtjWJQQRNPpIlNRgUHlH7NuEHM39ERzc2OlSg4FEG+abFG Y2M9yIoKjH735CaTJrBwV9a9XAnH468tCFrz85wCK8dtOHRQsp6vLj5aF+FoXRcDRUJZ hEnReUG1JUaBIBnSNxQtCDAeEiNWqTjcUplRNh5nCuC7uioDNGLH9hjHE8ZpGX4wgTRC e7Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=TzlLRqeLIoCqWaeCUWjv2sHg+Xif4EvH9trW59SFbGc=; b=VnsHQ89qNAb/O+zJZdP7eSD21JGW30P8gv2jCKgnqoENVGFDYBHNmjsjoGCKmKQWZW VozBJ4OAV9Erd+Nfej+FbWoOJ0CbckKhXhfARVaJ0tAZFO9qJkHyXBvyGd16S86SwLi8 B/+u2fQAxtRBqlt8b5L77l2kkgBgr6B+d1XsslTI7zm2PArGl+w5rRpCPTzVocArmKOU D1YnMaTi/6Y/gDSqgpwuyd5udkdCg9Aoo69vhMwKBuUVqrswoi4eLXAz2CNY5guZQsiQ GM92n+xJe5cFSBzejjq8Wh9eFZzTDVqyg21j4OVzb5G5UnW8qlb90qbA/D51Pt4lr0jH nfpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fOUJ3VKR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t12-20020a170906608c00b008de88af9a7esi864678ejj.171.2023.03.07.05.41.17; Tue, 07 Mar 2023 05:41:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fOUJ3VKR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229905AbjCGNaT (ORCPT <rfc822;toshivichauhan@gmail.com> + 99 others); Tue, 7 Mar 2023 08:30:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbjCGNaR (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 7 Mar 2023 08:30:17 -0500 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADF8352F69 for <linux-kernel@vger.kernel.org>; Tue, 7 Mar 2023 05:29:39 -0800 (PST) Received: by mail-lj1-x230.google.com with SMTP id h9so13157152ljq.2 for <linux-kernel@vger.kernel.org>; Tue, 07 Mar 2023 05:29:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678195771; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TzlLRqeLIoCqWaeCUWjv2sHg+Xif4EvH9trW59SFbGc=; b=fOUJ3VKR0xgJCRsivOF8z+yqwiKvQTkZJuVKiQm7TEdr7v4AUNTKvl24w5XMb7WMR1 EqkMQ0pp5xiQhvu0HJUAPMi+W1p3taMXijnPONvM4jyl6ImYL2qy7MSRZnQhP9Y5h/7/ LfM4fJwcmCldKdJny6k8s+TzyhvhtVq5I9m6uOoE9uK3HmgsAvPpJmt/t6O1x7sEtTzM ZicykiXRZt4fIsEkxF9EjmVyzuVfvVyoQqxHpk0UVrf7KcfKMCatHIF9VKdjM8YOaBMa 9jahkhWxostt1+pAHG6mKh0WQ1fJWK6MS2Zeb81xlyT+TpZoR4hMgnwm4V6peewZdxqG yzhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678195771; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TzlLRqeLIoCqWaeCUWjv2sHg+Xif4EvH9trW59SFbGc=; b=cloGyfzlcxuSufKRVx0wR0YSTSxuAu+VWy719cP/NtekFaT9g23m3YJziTjVS6pSBM llzLwnjozqysO7ZeJ8Hqt6SaVp0wAJlPB3K1wGiMes1TXQKoLw7TNUi5WxWzPKL+LpAy x58/hL+wH6ORE6qKK2h7vcPWk9U4Zz3xmKfxqttWrylW9rnDkHk644bMQSA5ub3/tfAQ c3xk4ipWMjUJSfpWgYR1Ttsg3hRZvGY0jwBCGybG8jCAC4+z9eyGHA6WLokM8OcmFyrn Bzm1viE0ekCOEZ2eaWF4WmSqaxiQslQzTx2wbxEQRbiYV8AKQ/VNiIG6J7EDeE/DQXvN q4eQ== X-Gm-Message-State: AO0yUKX/2b/n55WH7PrXMCwACGXfTsRSREUYfO7dkTUodxfGesRAq9UO zNnSohQA7TFTcnPRmbaTJF8qfA== X-Received: by 2002:a2e:96c7:0:b0:295:ac45:f088 with SMTP id d7-20020a2e96c7000000b00295ac45f088mr4271172ljj.44.1678195771320; Tue, 07 Mar 2023 05:29:31 -0800 (PST) Received: from localhost.localdomain (abyj16.neoplus.adsl.tpnet.pl. [83.9.29.16]) by smtp.gmail.com with ESMTPSA id f8-20020a2e3808000000b002983bfe65b8sm1674813lja.84.2023.03.07.05.29.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 05:29:31 -0800 (PST) From: Konrad Dybcio <konrad.dybcio@linaro.org> To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Konrad Dybcio <konrad.dybcio@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] clk: Print an info line before disabling unused clocks Date: Tue, 7 Mar 2023 14:29:28 +0100 Message-Id: <20230307132928.3887737-1-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_HTTP,RCVD_IN_SORBS_SOCKS,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759716573812624064?= X-GMAIL-MSGID: =?utf-8?q?1759716573812624064?= |
Series |
[v2] clk: Print an info line before disabling unused clocks
|
|
Commit Message
Konrad Dybcio
March 7, 2023, 1:29 p.m. UTC
Currently, the regulator framework informs us before calling into their unused cleanup paths, which eases at least some debugging. The same could be beneficial for clocks, so that random shutdowns shortly after most initcalls are done can be less of a guess. Add a pr_info before disabling unused clocks to do so. Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- v1 -> v2: - Don't add 'else' right before a return - Add Marijn's r-b drivers/clk/clk.c | 2 ++ 1 file changed, 2 insertions(+)
Comments
Quoting Konrad Dybcio (2023-03-07 05:29:28) > Currently, the regulator framework informs us before calling into > their unused cleanup paths, which eases at least some debugging. The > same could be beneficial for clocks, so that random shutdowns shortly > after most initcalls are done can be less of a guess. > > Add a pr_info before disabling unused clocks to do so. > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- Applied to clk-next
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index ae07685c7588..115a80fda3f9 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -1406,6 +1406,8 @@ static int __init clk_disable_unused(void) return 0; } + pr_info("clk: Disabling unused clocks\n"); + clk_prepare_lock(); hlist_for_each_entry(core, &clk_root_list, child_node)