Message ID | 20230312161512.2715500-19-u.kleine-koenig@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp799476wrd; Sun, 12 Mar 2023 10:03:31 -0700 (PDT) X-Google-Smtp-Source: AK7set9BTGoIiKEY2yOdu6Mj/RpeXVXNJKkwwh8Kbzg1edpB5tEPsxAZmqo+uFWYvaeODBpvWCGj X-Received: by 2002:a17:902:db04:b0:19f:3e9b:7527 with SMTP id m4-20020a170902db0400b0019f3e9b7527mr2781319plx.61.1678640611104; Sun, 12 Mar 2023 10:03:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678640611; cv=none; d=google.com; s=arc-20160816; b=USmHsPQ4saO0MUp8uV2ETQBOdtMVS7WLqQOyWyuObD3OsT8cCW2+/dqgmgM6xmm8yg C7IX4t78ueHM2dFhnpKPeFJZxt8sEf7+dhWNHKNw/f4quDS1/nOsMceubAZqnxGStGv6 X9AObOj3lfv24Fx5w7BjAbAaw/JktGE8bEg6eXU6tiNqn7Dx0ZbOCqzcZkRufPy0DteD UIy+aQfSJU/e5dv72temOQ4myzLIKaesiRW7BlHYrGhvU2bfr+DR+npm4hH+yUqIgPfC eV8pzQTEBssNb4/ks71/gRLr3HScQ8gndkZXo1g07bEepyxRv7inb1mdgRQQWJ4fy/Ls 0AoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=9mDCwbQXKXlxM23FxZi2OrgvBVp8voVWXvIugxKxk8s=; b=n2sMy0HtAJ2olzYrQ7vyS8pbseUmYGSwoBhLaSZhirPyY/Wq+47FMT36dJzTn4mbdR DotalCdoOrpu/InbKE1Ki8LzIij9c/zC8AGhp/HEVyeLCtQjDMwCWYkArfhLItU2KL3d l8x0CCfREgTGTJLROrBEOLAAkV6XuIQF6LXqEqrg2z7Vbot8HEUkjFTrQ5jzikiZys+Q sY/DiC9YB6oI6QsX/nYoUEjZzwXhf8CuP16VkPZ0mlIKUEhP/XPYRPHqkdO0mIb+nC17 lavW4niDSKeIX9CYm/scXDzYk7u/LN6owaeRAaYGvceCBOGSAkrSmlbcRSh7nMfzCpYG Az4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j5-20020a170903028500b0019f309fda80si2997457plr.515.2023.03.12.10.03.18; Sun, 12 Mar 2023 10:03:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230427AbjCLQQk (ORCPT <rfc822;realc9580@gmail.com> + 99 others); Sun, 12 Mar 2023 12:16:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230175AbjCLQPg (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 12 Mar 2023 12:15:36 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C118238663 for <linux-kernel@vger.kernel.org>; Sun, 12 Mar 2023 09:15:33 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1pbOLz-0007q3-CF; Sun, 12 Mar 2023 17:15:23 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pbOLy-003f2i-Oh; Sun, 12 Mar 2023 17:15:22 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pbOLy-004K98-0D; Sun, 12 Mar 2023 17:15:22 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH 18/30] clk: keystone: Convert to platform remove callback returning void Date: Sun, 12 Mar 2023 17:15:00 +0100 Message-Id: <20230312161512.2715500-19-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1610; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=EdxpF9B3WevfLOCMcjAbOLN0OKWfDkQVotXJZRfvPU8=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkDfpdmGxBzJ7rYzLX8wC5RQFJSkGcMuClwg3yA dBWvUrN1waJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZA36XQAKCRDB/BR4rcrs Ce6zCACAc5Dsu8CfbYeza6I0tWh8Pvi239Ywn32eZEcBLa/U12ZcdegfxZaZ9x7i6L+NkxW0lhj fx7skQVtNlhSbxawvIMUE6oPRT//UZJGEFo5LcL2WypYFfFwAt3X+a1ve6vH8O3sGFY5LLarJ4u iGslA6xK0d2rcXjW8WDDjkQMiFqUZ45YpLo1o0BjVNXKPJ0cE7qW/s2mcex6dfr7M0F3Udjk/t+ uA39pWbhe9Xpy+71ntFva3IPVzXwcJvZRIm6EVf9g8hMVHpZmN1NZR1BdKbxv8CupGmdap00eGp uHIdAqmAM/tLYv7VJQVs7SUiY/oNRtOEuoCFNSITpo6Yg/hU X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760182257651060273?= X-GMAIL-MSGID: =?utf-8?q?1760182257651060273?= |
Series |
clk: Convert to platform remove callback returning void
|
|
Commit Message
Uwe Kleine-König
March 12, 2023, 4:15 p.m. UTC
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/clk/keystone/sci-clk.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
Comments
Quoting Uwe Kleine-König (2023-03-12 09:15:00) > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- Applied to clk-next
diff --git a/drivers/clk/keystone/sci-clk.c b/drivers/clk/keystone/sci-clk.c index d4b4e74e22da..910ecd58c4ca 100644 --- a/drivers/clk/keystone/sci-clk.c +++ b/drivers/clk/keystone/sci-clk.c @@ -689,16 +689,14 @@ static int ti_sci_clk_probe(struct platform_device *pdev) * via common clock framework. Any memory allocated for the device will * be free'd silently via the devm framework. Returns 0 always. */ -static int ti_sci_clk_remove(struct platform_device *pdev) +static void ti_sci_clk_remove(struct platform_device *pdev) { of_clk_del_provider(pdev->dev.of_node); - - return 0; } static struct platform_driver ti_sci_clk_driver = { .probe = ti_sci_clk_probe, - .remove = ti_sci_clk_remove, + .remove_new = ti_sci_clk_remove, .driver = { .name = "ti-sci-clk", .of_match_table = of_match_ptr(ti_sci_clk_of_match),