| Message ID | 20230325114353.50293-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp353094vqo;
Sat, 25 Mar 2023 04:45:56 -0700 (PDT)
X-Google-Smtp-Source:
AKy350ag8JHNoJxf8oDWB1Sok5VH1iCvJSq6mTKXvBrNvMJsBqecVLGawRTW7FDhPmwKPmL4+yy4
X-Received: by 2002:a17:906:c003:b0:92f:7c42:8637 with SMTP id
e3-20020a170906c00300b0092f7c428637mr6236896ejz.30.1679744756247;
Sat, 25 Mar 2023 04:45:56 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1679744756; cv=none;
d=google.com; s=arc-20160816;
b=C6CUGxNOf0zCTLBI9njbXrxI0N6XLD1gDQMqBJZXt9evfOJnhcnm9Nbh9BIZvlwAn6
aEPyZEO07x6DG1vMOmpmB3ug+Q7RSelJ5JYaCsN19o6v3sXWDm+1zFEnucGXYqMdLsDY
ZGo0W2JsKMl/bqEp5gPymUz+fR80mSMTzBMNDpdOcRWIRqEDlcwVCjmxqrCCCrswFbPy
VhhgAYpiCNZ5bFORUuBtdbtun1pXSRg13SVjnB+Ui64kfNjkebH7kruPiNYcd6+IpFr8
kWlwCIcS21Po5G5ckEoXWOF+vapPhbdIPOjLVSf2/xw+iZywup0H5/kikdRvLaWgaAah
WtEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=1IhPCrg38TcoGrZQBwhoHXcMP2uuEpq8+QpUp8FcUsU=;
b=R+x9hBcTy3J8M7BVgT38owNZp+z1Kxx0Oe8w0nsU+dZxhm4kOEXcIx4IX7lFak3XQp
mJXBXigmp2zWM6WUfNOMYnBolYGYKt86PkQB4yM4B5lGeOeT+ozTxvhGJOMvrmOTv+0i
zsdLWkWtjNx8Xo/k8hW0LGHo1foDWgBZTWKMSaXZJb70V2oZz8rCI2dxcFBsBxp8Oxxr
5QLn2TXic+Rdb6oD7Qesa+WI++EcQvNK6rEKiPoYpKV3MYhiY+TXwEX8EI9W0pme8U4w
bQvMOc/vUMQLrviXT7qY1lSUvJoKeJWMT9xC5IySwYHznOa8T+OCra2w0Xpewp30WH80
Hhrg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=p8vTieC5;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
h11-20020a1709063c0b00b008d9d5588454si8246402ejg.716.2023.03.25.04.45.32;
Sat, 25 Mar 2023 04:45:56 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=p8vTieC5;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229724AbjCYLn7 (ORCPT <rfc822;makky5685@gmail.com> + 99 others);
Sat, 25 Mar 2023 07:43:59 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59744 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229600AbjCYLn5 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sat, 25 Mar 2023 07:43:57 -0400
Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com
[IPv6:2a00:1450:4864:20::534])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D50F3E18E
for <linux-kernel@vger.kernel.org>;
Sat, 25 Mar 2023 04:43:56 -0700 (PDT)
Received: by mail-ed1-x534.google.com with SMTP id t10so17483376edd.12
for <linux-kernel@vger.kernel.org>;
Sat, 25 Mar 2023 04:43:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1679744635;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=1IhPCrg38TcoGrZQBwhoHXcMP2uuEpq8+QpUp8FcUsU=;
b=p8vTieC5kCmOLk22SgH8ZRkJ4guRnRmB+4Ibglfi+0vNozLICbj+zfdi9YGxfOk0NM
BaR3RXp1eB8m7fkexMGlapDQcODB4Sr8hwGJ9nSVK7ier5q3JHPHOmiwlZSj8gQFsT91
2lXtWZUI56ZIyDXwIVtSdkpLQLad9KIlqd3IH4om3wVncn31zyLZYQ5JNYgpHEljPDlG
+Y41CawJZZdi7C46f+3afLEwVkxkxGpha23vlZOlt1o6tm5nsdqRGd5zo8mzACsGipi0
f/tNGmXsTgBvwK1jAPehQD7fNlM7b50tvzawGay0zKS3BVwzfDe1gBQEYAg6s9UBPulu
XOCg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112; t=1679744635;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=1IhPCrg38TcoGrZQBwhoHXcMP2uuEpq8+QpUp8FcUsU=;
b=JPqIopDhH5iVWHmPcT8Z0O1kTtoIrZDVGUGLZ/9aaIZucECaAOehg44w5n+aCLsgWi
6Yh08VO6F7A3cm/gAniSqMKbBevCCVV0YA0oxN3SFIbWPGhn93Z3HiGHWHQRjMwokQjx
n+yTIDLYliw+xXYido1oyNrGbr9zbZO6QoY3M88S9WTQ1RYIRkNADPfxL/Z/GQJyPilp
eDpcaJyapv+/dBBrzrWOIgUFBKGweYQvZPGBZdt+45OrbUFcNK8ks4U431PxSlT3nCIX
dtO9+RS1YOdnGe3sTOUh+scLRgqC1sUkE1YEU0tKF8tFV0MvrWHm2UeA2KOJ+aRAmatv
Y+yg==
X-Gm-Message-State: AAQBX9f/kggys9wgDhkOGGb/7OCYRYWc+yAhP4FIZBGrSUXsiM9gNkWP
ocTQm1/ceM+5S4pNj2tz3hWTobb6aprx9aFvFTo=
X-Received: by 2002:a17:906:738a:b0:933:4ca3:9678 with SMTP id
f10-20020a170906738a00b009334ca39678mr5376478ejl.24.1679744635316;
Sat, 25 Mar 2023 04:43:55 -0700 (PDT)
Received: from krzk-bin.. ([2a02:810d:15c0:828:d230:b2c7:d55:c9c8])
by smtp.gmail.com with ESMTPSA id
k10-20020a1709067aca00b009294524ac21sm11657011ejo.60.2023.03.25.04.43.54
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 25 Mar 2023 04:43:54 -0700 (PDT)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chen-Yu Tsai <wens@csie.org>, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andre Przywara <andre.przywara@arm.com>
Subject: [PATCH] dt-bindings: mfd: x-powers,axp152: simplify disallowing
properties
Date: Sat, 25 Mar 2023 12:43:53 +0100
Message-Id: <20230325114353.50293-1-krzysztof.kozlowski@linaro.org>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS
autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1761340037884929828?=
X-GMAIL-MSGID: =?utf-8?q?1761340037884929828?=
|
| Series |
dt-bindings: mfd: x-powers,axp152: simplify disallowing properties
|
|
Commit Message
Krzysztof Kozlowski
March 25, 2023, 11:43 a.m. UTC
The syntax to disallow x-powers,drive-vbus-en,
x-powers,self-working-mode and x-powers,master-mode for certain variants
can be made simpler. Also this produces much nicer warning message when
the condition hits wrong DTS.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Andre Przywara <andre.przywara@arm.com>
---
.../devicetree/bindings/mfd/x-powers,axp152.yaml | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
Comments
On Sat, 25 Mar 2023 12:43:53 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: Hi, > The syntax to disallow x-powers,drive-vbus-en, > x-powers,self-working-mode and x-powers,master-mode for certain variants > can be made simpler. Also this produces much nicer warning message when > the condition hits wrong DTS. Ah, indeed, that reads much nicer! > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Tested-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > > Cc: Andre Przywara <andre.przywara@arm.com> > --- > .../devicetree/bindings/mfd/x-powers,axp152.yaml | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > index 24d03996b93a..8eeb5b387430 100644 > --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > @@ -47,9 +47,8 @@ allOf: > - x-powers,axp209 > > then: > - not: > - required: > - - x-powers,drive-vbus-en > + properties: > + x-powers,drive-vbus-en: false > > - if: > not: > @@ -59,14 +58,9 @@ allOf: > const: x-powers,axp806 > > then: > - allOf: > - - not: > - required: > - - x-powers,self-working-mode > - > - - not: > - required: > - - x-powers,master-mode > + properties: > + x-powers,self-working-mode: false > + x-powers,master-mode: false > > - if: > not:
On Tue, Mar 28, 2023 at 10:03 PM Andre Przywara <andre.przywara@arm.com> wrote: > > On Sat, 25 Mar 2023 12:43:53 +0100 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Hi, > > > The syntax to disallow x-powers,drive-vbus-en, > > x-powers,self-working-mode and x-powers,master-mode for certain variants > > can be made simpler. Also this produces much nicer warning message when > > the condition hits wrong DTS. > > Ah, indeed, that reads much nicer! > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Andre Przywara <andre.przywara@arm.com> > Tested-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Chen-Yu Tsai <wens@csie.org>
On Sat, 25 Mar 2023, Krzysztof Kozlowski wrote: > The syntax to disallow x-powers,drive-vbus-en, > x-powers,self-working-mode and x-powers,master-mode for certain variants > can be made simpler. Also this produces much nicer warning message when > the condition hits wrong DTS. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Applied, thanks -- Lee Jones [李琼斯]
diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml index 24d03996b93a..8eeb5b387430 100644 --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml @@ -47,9 +47,8 @@ allOf: - x-powers,axp209 then: - not: - required: - - x-powers,drive-vbus-en + properties: + x-powers,drive-vbus-en: false - if: not: @@ -59,14 +58,9 @@ allOf: const: x-powers,axp806 then: - allOf: - - not: - required: - - x-powers,self-working-mode - - - not: - required: - - x-powers,master-mode + properties: + x-powers,self-working-mode: false + x-powers,master-mode: false - if: not: