Message ID | 20230311173303.262618-7-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp379885wrd; Sat, 11 Mar 2023 09:38:22 -0800 (PST) X-Google-Smtp-Source: AK7set/wnSP54zsztCy3FK64OTmD82sHXaDtKw6aa1y5tspXjyMIoB+kjxolGo3hOM5pi7LIhU/k X-Received: by 2002:a62:1e06:0:b0:622:95b6:ef32 with SMTP id e6-20020a621e06000000b0062295b6ef32mr1502155pfe.34.1678556302286; Sat, 11 Mar 2023 09:38:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678556302; cv=none; d=google.com; s=arc-20160816; b=VnpiIQLfyRA5LHZoKyOjvkouOxiEYJ0wexomlDv3W+I1EP4Ed6+Ov1JJ3hlrjov0oO 3szIwBJYwAetWsqZzpKvg4bhP0PnSt8uB5zY6ndugKnmiHx89P6VPqIKdCXv0zgpIA6U 4C9xvRPBoyJZSfXZNHNmOklPgUM9/yPpHRymuFjzqSxi6/Fw9lB8rNJTli9V7s6F1xUR VLWZ6rZuFwS6tEKnWpRyuHaklR1gfPay4NOvzRmPF5qi8j4nipWgICTfzJVqBzyTK9y6 PAMIg/FV8Z13phtHOnWviLHVrp7UZUB5N95qF+lYsDfz/E2+7HElYhIu1lwnsJjGY08H +liA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pg+GPO/7EayVuamadIf0ZkJzvPVNrr6nqvGyotFYqJw=; b=O1xPtL83Skq+wGLp0JAFtttuiX6mploGkB/gtIFLgujrwgwicZvk3fl91uWC6ugLCh uA2a33gaJ9ANRWEhZy9YiggMvMBYBRNQfex0B+W3VG5a0Um1LjXoWKOJdLfhR//R9Xl9 wWCctW9z1KTwZlVfLliNNKoiiEc0Y2YKpBmAcErc8PWLMYGr2Pl8oUtG42vxEpMe5YxP 9OIRi7lREby2Q5DobfqAi/hLngtB+h3R8Y/EXvODwyJ+wdnPxBBLur2qii/sCnSN5niF 3v1bB4OKkQmhjN65tfznUmV9rJLQWz4scF3kS6a/iviRQP2zIAiBThvh1IxO66SdJgrd D7+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="QLGcp//9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020aa79509000000b00571a5c5eaa5si2346587pfp.150.2023.03.11.09.38.10; Sat, 11 Mar 2023 09:38:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="QLGcp//9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230167AbjCKReG (ORCPT <rfc822;toshivichauhan@gmail.com> + 99 others); Sat, 11 Mar 2023 12:34:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230157AbjCKRdc (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 11 Mar 2023 12:33:32 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B388252B5 for <linux-kernel@vger.kernel.org>; Sat, 11 Mar 2023 09:33:21 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id j11so33034583edq.4 for <linux-kernel@vger.kernel.org>; Sat, 11 Mar 2023 09:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678556001; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pg+GPO/7EayVuamadIf0ZkJzvPVNrr6nqvGyotFYqJw=; b=QLGcp//9YW3Bk8OUHxNwnEQxTEzlQHE3td9NgmKco5B/m0ltJ6JzKJYZqWFEk5OOhc TgN4yl6NXi+7UGadNTCwZcT5F1eOPX0u8EIGOmUuEqvqo3VNBwildAwAelu/c0zPv5jG tL8qALW1Kh0MAkcwxjOHBT7E55h70Ih6OryxXmM5b1f3hhTQcRI0IrmlN7dMF5dxf6GN 24Rb0XmN6gxmEL2IaU/js2VrPSqXuqW18jLAZyEyGKdYqh/1JbUO4RMfaXMwikc1Bzhk AKgT/otoVDliGNadUn19zF00k5h7aJz7/J1qppKBAJvWn6cDLhfkFloaOdMPS3dSJVgP /rjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678556001; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pg+GPO/7EayVuamadIf0ZkJzvPVNrr6nqvGyotFYqJw=; b=LdE8saqmH1LFD5/QvqK6tdgpY/1N3GqeDLndIUz1b5rQrqKyKzxvT15GH9+NDulUZI AxzqN8R5PIzYtSyaaTMe8dnwy5VV9Qqjja02m9L/dlN7qNpk8ZR/7K/q3Yk8jcOwF6kS ITPRw6zPIBMLPawPN20SOX3pavS0WTr+YdZG8RzPAhBum3qSC/elaHL7zCG60fDZF4EC 95tZz/E4DyqKniXBT1JQjCYRUsx+lVXl4pRSJIxsCzo8iAWmxAPtl1Q4SJgkKbzS9ZLx i5MyHg5BZ9xGpB/pypqwrrJvNd5V0M6nvr6lG93Wf0dapIYKO8bZ3oyQPaChY58gTRjT 4V4Q== X-Gm-Message-State: AO0yUKWbUTbLrflvDHo5PrPBMUYEu25edRXsukrrcwDO14DHblKcG0ew /KYTOW878P0NWqEIoqIhf8fnEg== X-Received: by 2002:aa7:d04e:0:b0:4fa:ee01:a0cb with SMTP id n14-20020aa7d04e000000b004faee01a0cbmr1425114edo.32.1678556001033; Sat, 11 Mar 2023 09:33:21 -0800 (PST) Received: from krzk-bin.. ([2a02:810d:15c0:828:6927:e94d:fc63:9d6e]) by smtp.gmail.com with ESMTPSA id k15-20020a50ce4f000000b004d8287c775fsm1440885edj.8.2023.03.11.09.33.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 09:33:20 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Vladimir Oltean <olteanv@gmail.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Hauke Mehrtens <hauke@hauke-m.de>, Woojung Huh <woojung.huh@microchip.com>, UNGLinuxDriver@microchip.com, Claudiu Manoil <claudiu.manoil@nxp.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Colin Foster <colin.foster@in-advantage.com>, Michael Hennerich <michael.hennerich@analog.com>, Alexander Aring <alex.aring@gmail.com>, Stefan Schmidt <stefan@datenfreihafen.org>, Miquel Raynal <miquel.raynal@bootlin.com>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wpan@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 07/12] net: ieee802154: adf7242: drop of_match_ptr for ID table Date: Sat, 11 Mar 2023 18:32:58 +0100 Message-Id: <20230311173303.262618-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230311173303.262618-1-krzysztof.kozlowski@linaro.org> References: <20230311173303.262618-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760093852786449810?= X-GMAIL-MSGID: =?utf-8?q?1760093852786449810?= |
Series |
[01/12] net: dsa: lantiq_gswip: mark OF related data as maybe unused
|
|
Commit Message
Krzysztof Kozlowski
March 11, 2023, 5:32 p.m. UTC
The driver will match mostly by DT table (even thought there is regular
ID table) so there is little benefit in of_match_ptr (this also allows
ACPI matching via PRP0001, even though it might not be relevant here).
drivers/net/ieee802154/adf7242.c:1322:34: error: ‘adf7242_of_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/net/ieee802154/adf7242.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Samstag, 11. März 2023 18:33 > To: Andrew Lunn <andrew@lunn.ch>; Florian Fainelli <f.fainelli@gmail.com>; > Vladimir Oltean <olteanv@gmail.com>; David S. Miller > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub > Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Hauke > Mehrtens <hauke@hauke-m.de>; Woojung Huh > <woojung.huh@microchip.com>; UNGLinuxDriver@microchip.com; Claudiu > Manoil <claudiu.manoil@nxp.com>; Alexandre Belloni > <alexandre.belloni@bootlin.com>; Colin Foster <colin.foster@in- > advantage.com>; Hennerich, Michael <Michael.Hennerich@analog.com>; > Alexander Aring <alex.aring@gmail.com>; Stefan Schmidt > <stefan@datenfreihafen.org>; Miquel Raynal <miquel.raynal@bootlin.com>; > Heiner Kallweit <hkallweit1@gmail.com>; Russell King > <linux@armlinux.org.uk>; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-wpan@vger.kernel.org > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Subject: [PATCH 07/12] net: ieee802154: adf7242: drop of_match_ptr for ID > table > > The driver will match mostly by DT table (even thought there is regular ID > table) so there is little benefit in of_match_ptr (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). > > drivers/net/ieee802154/adf7242.c:1322:34: error: ‘adf7242_of_match’ > defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Michael Hennerich <michael.hennerich@analog.com> > --- > drivers/net/ieee802154/adf7242.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ieee802154/adf7242.c > b/drivers/net/ieee802154/adf7242.c > index 5cf218c674a5..509acc86001c 100644 > --- a/drivers/net/ieee802154/adf7242.c > +++ b/drivers/net/ieee802154/adf7242.c > @@ -1336,7 +1336,7 @@ MODULE_DEVICE_TABLE(spi, adf7242_device_id); > static struct spi_driver adf7242_driver = { > .id_table = adf7242_device_id, > .driver = { > - .of_match_table = of_match_ptr(adf7242_of_match), > + .of_match_table = adf7242_of_match, > .name = "adf7242", > .owner = THIS_MODULE, > }, > -- > 2.34.1
Hi Krzysztof, krzysztof.kozlowski@linaro.org wrote on Sat, 11 Mar 2023 18:32:58 +0100: > The driver will match mostly by DT table (even thought there is regular > ID table) so there is little benefit in of_match_ptr (this also allows > ACPI matching via PRP0001, even though it might not be relevant here). > > drivers/net/ieee802154/adf7242.c:1322:34: error: ‘adf7242_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> I see Stefan already acked most of the ieee802154 patches, but I didn't got notified for this one, so in case: Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/net/ieee802154/adf7242.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c > index 5cf218c674a5..509acc86001c 100644 > --- a/drivers/net/ieee802154/adf7242.c > +++ b/drivers/net/ieee802154/adf7242.c > @@ -1336,7 +1336,7 @@ MODULE_DEVICE_TABLE(spi, adf7242_device_id); > static struct spi_driver adf7242_driver = { > .id_table = adf7242_device_id, > .driver = { > - .of_match_table = of_match_ptr(adf7242_of_match), > + .of_match_table = adf7242_of_match, > .name = "adf7242", > .owner = THIS_MODULE, > }, Thanks, Miquèl
Hello. On 28.03.23 12:48, Miquel Raynal wrote: > Hi Krzysztof, > > krzysztof.kozlowski@linaro.org wrote on Sat, 11 Mar 2023 18:32:58 +0100: > >> The driver will match mostly by DT table (even thought there is regular >> ID table) so there is little benefit in of_match_ptr (this also allows >> ACPI matching via PRP0001, even though it might not be relevant here). >> >> drivers/net/ieee802154/adf7242.c:1322:34: error: ‘adf7242_of_match’ defined but not used [-Werror=unused-const-variable=] >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > I see Stefan already acked most of the ieee802154 patches, but I didn't > got notified for this one, so in case: The reason I did not ack the two patches for adf7242 is that Michael as driver maintainer ack'ed them already. I only handled the ones where we have no active maintainer, as a fallback. regards Stefan Schmidt
diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c index 5cf218c674a5..509acc86001c 100644 --- a/drivers/net/ieee802154/adf7242.c +++ b/drivers/net/ieee802154/adf7242.c @@ -1336,7 +1336,7 @@ MODULE_DEVICE_TABLE(spi, adf7242_device_id); static struct spi_driver adf7242_driver = { .id_table = adf7242_device_id, .driver = { - .of_match_table = of_match_ptr(adf7242_of_match), + .of_match_table = adf7242_of_match, .name = "adf7242", .owner = THIS_MODULE, },