Message ID | 20221028051420.GA30073@rdm |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp635448wru; Thu, 27 Oct 2022 22:38:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM64u5Um7KWdxeH/ujpPqCllOc+CGvzjEO4zblKBkKSjcbshm4ap0hteiQ9+4Zw+EjRtpwAQ X-Received: by 2002:a17:907:31c3:b0:770:852b:71a2 with SMTP id xf3-20020a17090731c300b00770852b71a2mr45564064ejb.557.1666935495500; Thu, 27 Oct 2022 22:38:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666935495; cv=none; d=google.com; s=arc-20160816; b=AHKqEgHh5+n5Gmjf6D6LjsHta/V/+nwpCGmkgRdv8c5jmR1cDKGYZiMIxDrpMA8GJ4 +Z7wRtMxQVzrPKabGAylbwosIGh0gbOgwe3BzB2q1YkXBjvY1on0V+K44NXTxp9Rg9Jr a0YqjPrDwVITWQnRjXkJYv3fa2dHF7vwD27lObLiplR4VcwQKrZE5bbSOWdYFpQQtAUt azldAuJBgym9JOHHhyUknfZxnuurQ+4vLTUZlKq4UWBjxorYAF67Gc6cRxvHnAraoXpe +VPeZzjHIR27WzdmE9rlc/CtAHQiu/fTLFqZumqBYD3BJwAUH9pQ0g+y2HpmgQhQsLhZ oHpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date:dkim-signature; bh=Y8Cl50GxiFHirgjeWPOfiswX2gs4Kajn64w85/PEn9Q=; b=TbzVjTVIlju06bn17EbSBA+uAHHmZduyNSbXScff5ntkmqgRJR1G/jy1sII+A3Y+LU svXLlSQQ+KbGUzxjU6OI3hNiWb3cRzsIHsHzp5eu83xWdaLNXsHlMcgecEBI0d77XM5N qY/gtLQKK7RvWwmvsmL63uZvBb7bVDoAXJfGHiqHGgHL3+NPPG1PwP6IqpYa5rAkz2yQ Rj/dhhpZ0wpPlAzNfQ+9wRC4rIJSIejK5idwY6t6tfi9j3UFvHb5oKqm7krfihlDbEBe IcJNN7YNf3IYFgrFG1Io6k7F7cH066vYDe/zaiHNdQhBMsC86DHarkC9ugu9M8aGPMo9 5CuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=aNZyiFu8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa3-20020a1709076d0300b007a96e504c7esi3886138ejc.753.2022.10.27.22.37.49; Thu, 27 Oct 2022 22:38:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=aNZyiFu8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbiJ1FOh (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Fri, 28 Oct 2022 01:14:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbiJ1FOe (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 28 Oct 2022 01:14:34 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BD46BCA1 for <linux-kernel@vger.kernel.org>; Thu, 27 Oct 2022 22:14:31 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id r186-20020a1c44c3000000b003cf4d389c41so2892885wma.3 for <linux-kernel@vger.kernel.org>; Thu, 27 Oct 2022 22:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Y8Cl50GxiFHirgjeWPOfiswX2gs4Kajn64w85/PEn9Q=; b=aNZyiFu8QyAiNdVys2tpGzR/2lt6NUhGjCrNITFwiS+dPB5Gn1gx+YNA5KyZ/qOmYR Wq2uUP33O6D5zmrCGfYuRXnySKEucM1rAyvYMAkkxnKLXujmSwgSu0U80zwzAV8FsVYM A/5Y8maP6T+c4mcNrd55u+0xiUjtDrfIIASSnjSHmRT+YsNGCAn2w3zSqDqqJh5UDxNE kAm6FhaWx7DKLbR46mya/kdBgj9HSjpzNODjfuVRAAvEcqetMRym80Dfns/svvHJkKcv Cni4dCzTzXQ+T2+34lOGMlprcXyOUX6WcM4bcPdKM6lrgC0KKD1sKfj3KfI9nVzOhFDt I2JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y8Cl50GxiFHirgjeWPOfiswX2gs4Kajn64w85/PEn9Q=; b=GjSefIE1Gxq1BZE1w1i4M75VpUTqydBLnDJn5dQd90I/tw0ZY2DRFn9YotYJG2dBZI yehW5B7t8Ud0SmA1TeZF9/bqU8GcpP8et+DjaaDlMUvFBv3AkEyW0Zigxk3w7DKmyp3w VtWz2Ta7QzTqt4N6++4IeBlZUriKgqkVRnMkWbIwWnLYEW3BhnwWRzDC30iRt8UK+vi0 mkJ3+TOHsyCtE0zmxjVlE0IuA/Ti3hYkYNsj7oKySarZn6VB21vubdKS6RQTmZiU8HIG e+u6wD41ROWYC6W6jstceqdjXQZHXUOMR6aCaCALSxT8JxO87P1jag8DDyiWBBkyREpE 59ZA== X-Gm-Message-State: ACrzQf2MILsJ6zVSOxlgpxeIcgAh3fVfgaTjTmW4coe3bsbKLO87Rc5O w3xOIDMokfTE5X/z5zOTU+M= X-Received: by 2002:a05:600c:46c7:b0:3c6:f3e6:1f13 with SMTP id q7-20020a05600c46c700b003c6f3e61f13mr8040409wmo.62.1666934070110; Thu, 27 Oct 2022 22:14:30 -0700 (PDT) Received: from rdm ([41.75.189.203]) by smtp.gmail.com with ESMTPSA id p23-20020a1c5457000000b003a601a1c2f7sm6357483wmi.19.2022.10.27.22.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 22:14:29 -0700 (PDT) Date: Fri, 28 Oct 2022 08:14:20 +0300 From: UMWARI JOVIAL <umwarijovial@gmail.com> To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: [PATCH] WARNING: Possible repeated word: 'very' Message-ID: <20221028051420.GA30073@rdm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747908553810942806?= X-GMAIL-MSGID: =?utf-8?q?1747908553810942806?= |
Series |
WARNING: Possible repeated word: 'very'
|
|
Commit Message
UMWARI JOVIAL
Oct. 28, 2022, 5:14 a.m. UTC
i used checkpatch.pl script to identify the above
Repetition of the same word in one sentence same line
Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
---
drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Oct 28, 2022 at 08:14:20AM +0300, UMWARI JOVIAL wrote: > i used checkpatch.pl script to identify the above > Repetition of the same word in one sentence same line Please read the documentation for how to write a good changelog text. Hint, "i" is not something you see in a text, right? Also, why do you have WARNING in the subject line and not the driver name? Again, read the documentation please. > > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com> > --- > drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c > index 090345bad223..30a0276b8b58 100644 > --- a/drivers/staging/rtl8712/rtl871x_xmit.c > +++ b/drivers/staging/rtl8712/rtl871x_xmit.c > @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) > * If we turn on USE_RXTHREAD, then, no need for critical section. > * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... > * > - * Must be very very cautious... > + * Must be very cautious... The original text here is correct. thanks, greg k-h
Thank you working on it now Best Regards Umwari Jovial On Fri, 28 Oct 2022 at 09:07, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Fri, Oct 28, 2022 at 08:14:20AM +0300, UMWARI JOVIAL wrote: > > i used checkpatch.pl script to identify the above > > Repetition of the same word in one sentence same line > > Please read the documentation for how to write a good changelog text. > Hint, "i" is not something you see in a text, right? > > Also, why do you have WARNING in the subject line and not the driver > name? Again, read the documentation please. > > > > > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com> > > --- > > drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c > > index 090345bad223..30a0276b8b58 100644 > > --- a/drivers/staging/rtl8712/rtl871x_xmit.c > > +++ b/drivers/staging/rtl8712/rtl871x_xmit.c > > @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) > > * If we turn on USE_RXTHREAD, then, no need for critical section. > > * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... > > * > > - * Must be very very cautious... > > + * Must be very cautious... > > The original text here is correct. > > thanks, > > greg k-h
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Oct 28, 2022 at 09:13:14AM +0300, jovial umwari wrote: > Thank you > working on it now > > Best Regards > Umwari Jovial As you spell your name this way in emails, please use the same format for your signed-off-by lines in your patches. thanks, greg k-h
Thank you for the corrections i am very sorry for All these mistakes i did not know Best regards Umwari Jovial On Fri, 28 Oct 2022 at 09:27, Greg KH <gregkh@linuxfoundation.org> wrote: > > A: http://en.wikipedia.org/wiki/Top_post > Q: Were do I find info about this thing called top-posting? > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > http://daringfireball.net/2007/07/on_top > > On Fri, Oct 28, 2022 at 09:13:14AM +0300, jovial umwari wrote: > > Thank you > > working on it now > > > > Best Regards > > Umwari Jovial > > As you spell your name this way in emails, please use the same format > for your signed-off-by lines in your patches. > > thanks, > > greg k-h
On Fri, Oct 28, 2022 at 08:14:20AM +0300, UMWARI JOVIAL wrote: > i used checkpatch.pl script to identify the above > Repetition of the same word in one sentence same line > > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com> This is my (not yet automated) response: You are sending patches to the Outreachy list, in a way that makes me suspect you have overlooked the Outreachy Project Contribution Information. Please review: https://www.outreachy.org/outreachy-december-2022-internship-round/communities/linux-kernel/ (only accepted applicants can see this link) https://lore.kernel.org/outreachy/Y0D+dzbjRtuc0KT4@aschofie-mobl2/ Alison > --- > drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c > index 090345bad223..30a0276b8b58 100644 > --- a/drivers/staging/rtl8712/rtl871x_xmit.c > +++ b/drivers/staging/rtl8712/rtl871x_xmit.c > @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) > * If we turn on USE_RXTHREAD, then, no need for critical section. > * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... > * > - * Must be very very cautious... > + * Must be very cautious... > * > */ > struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv) > -- > 2.25.1 > >
Noted. Thank you sir On Fri, 28 Oct 2022 at 21:35, Alison Schofield <alison.schofield@intel.com> wrote: > > On Fri, Oct 28, 2022 at 08:14:20AM +0300, UMWARI JOVIAL wrote: > > i used checkpatch.pl script to identify the above > > Repetition of the same word in one sentence same line > > > > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com> > > This is my (not yet automated) response: > > You are sending patches to the Outreachy list, in a way > that makes me suspect you have overlooked the Outreachy > Project Contribution Information. > > Please review: > https://www.outreachy.org/outreachy-december-2022-internship-round/communities/linux-kernel/ (only accepted applicants can see this link) > > https://lore.kernel.org/outreachy/Y0D+dzbjRtuc0KT4@aschofie-mobl2/ > > Alison > > > --- > > drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c > > index 090345bad223..30a0276b8b58 100644 > > --- a/drivers/staging/rtl8712/rtl871x_xmit.c > > +++ b/drivers/staging/rtl8712/rtl871x_xmit.c > > @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) > > * If we turn on USE_RXTHREAD, then, no need for critical section. > > * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... > > * > > - * Must be very very cautious... > > + * Must be very cautious... > > * > > */ > > struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv) > > -- > > 2.25.1 > > > >
On Sat, 29 Oct 2022, jovial umwari wrote: > Noted. Thank you sir Please don't top post. Your reponse should appear below the text that you are responding to. julia > > On Fri, 28 Oct 2022 at 21:35, Alison Schofield > <alison.schofield@intel.com> wrote: > > > > On Fri, Oct 28, 2022 at 08:14:20AM +0300, UMWARI JOVIAL wrote: > > > i used checkpatch.pl script to identify the above > > > Repetition of the same word in one sentence same line > > > > > > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com> > > > > This is my (not yet automated) response: > > > > You are sending patches to the Outreachy list, in a way > > that makes me suspect you have overlooked the Outreachy > > Project Contribution Information. > > > > Please review: > > https://www.outreachy.org/outreachy-december-2022-internship-round/communities/linux-kernel/ (only accepted applicants can see this link) > > > > https://lore.kernel.org/outreachy/Y0D+dzbjRtuc0KT4@aschofie-mobl2/ > > > > Alison > > > > > --- > > > drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c > > > index 090345bad223..30a0276b8b58 100644 > > > --- a/drivers/staging/rtl8712/rtl871x_xmit.c > > > +++ b/drivers/staging/rtl8712/rtl871x_xmit.c > > > @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) > > > * If we turn on USE_RXTHREAD, then, no need for critical section. > > > * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... > > > * > > > - * Must be very very cautious... > > > + * Must be very cautious... > > > * > > > */ > > > struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv) > > > -- > > > 2.25.1 > > > > > > > >
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c index 090345bad223..30a0276b8b58 100644 --- a/drivers/staging/rtl8712/rtl871x_xmit.c +++ b/drivers/staging/rtl8712/rtl871x_xmit.c @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) * If we turn on USE_RXTHREAD, then, no need for critical section. * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... * - * Must be very very cautious... + * Must be very cautious... * */ struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv)