Message ID | 20230324113013.254371-2-andre.przywara@arm.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp556711vqo; Fri, 24 Mar 2023 04:40:58 -0700 (PDT) X-Google-Smtp-Source: AKy350a0BaeSIE00QoOAxp12emRA+0l0KjP3pZQYPfQr84AqSdLs5OPAISm0Z95WeEn+nRcU6Oyv X-Received: by 2002:aa7:d584:0:b0:4fa:ba60:8188 with SMTP id r4-20020aa7d584000000b004faba608188mr2481471edq.8.1679658058153; Fri, 24 Mar 2023 04:40:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679658058; cv=none; d=google.com; s=arc-20160816; b=RSDjio00FASiO3oZC1MZ9rMfRWA5FGZwREvP6h2AxDFhLpsHGeuIZHhK77LvL7yLic n0bDSaBo06Uqc5+MjDLWf4wqBzJpc6Ez2LMj1Q78xbLu6xm8OClbcl3cNstHckcsY0L3 YZDzrUDt/IYtpy9NBPiWG6uboYurFEgqyrn5CVZMJRescBC7ZRuy0IqM/8kSGnEmUStM KW4zPoC2gpBl+Hz2Me+6XBbJNeYgJmPUG9MvQHiyOJ8FVqKQt2kp84+K4hPfmdG9gqdX pSAgGs25OzbQRDONGt5nFR3L5vP+VZDXPXU75YnO1uCWypIz/nFskyqFKId5c6uJfWgu K3nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=j18UNowLRYU58bAi1vmty0noMjH6n9k122ybzzqWnQA=; b=QdKj+ygRAgQaiOIKHLp0MljdJMagu/W0X2lhl30Or95E2+SgMX5LYtwznzM81wEg7g WJd6Sdqun24SFAStbVa7UyRUYYJnpzH7cOGK+LbAbsCs+BqBfM6zS5oBaY2xYrVB7xG8 1wGb1/Gx/XTFE+iwCE94MG/FZ6mTpyWx182aGf4WbjAE1vHQyXfRy9TocY5SddmnLkTT dGgwA5sgr/U227KTcwepq3PJAbChS8Lb4eiHYY1mBfzLaZMws1sDaShVefmemIdQBX+W /wjnxlL3PfXWEK/Hvc1yIh5L0SS5/Vuh4CPnhAVzhTCo3bw/jFeXMS8G8mlHkhV402yv UbWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g8-20020a170906394800b009228af19a8csi20022264eje.506.2023.03.24.04.40.34; Fri, 24 Mar 2023 04:40:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231740AbjCXLav (ORCPT <rfc822;ezelljr.billy@gmail.com> + 99 others); Fri, 24 Mar 2023 07:30:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231438AbjCXLat (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 24 Mar 2023 07:30:49 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AAEB11ABCD; Fri, 24 Mar 2023 04:30:48 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 825B412FC; Fri, 24 Mar 2023 04:31:32 -0700 (PDT) Received: from donnerap.arm.com (donnerap.cambridge.arm.com [10.1.197.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 951553F6C4; Fri, 24 Mar 2023 04:30:46 -0700 (PDT) From: Andre Przywara <andre.przywara@arm.com> To: Lee Jones <lee@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Martin Botka <martin.botka@somainline.org>, martin.botka1@gmail.com, Shengyu Qu <wiagn233@outlook.com>, Samuel Holland <samuel@sholland.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v9 1/3] dt-bindings: mfd: x-powers,axp152: Document the AXP313a variant Date: Fri, 24 Mar 2023 11:30:11 +0000 Message-Id: <20230324113013.254371-2-andre.przywara@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230324113013.254371-1-andre.przywara@arm.com> References: <20230324113013.254371-1-andre.przywara@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761249127789761629?= X-GMAIL-MSGID: =?utf-8?q?1761249127789761629?= |
Series |
regulator: Add X-Powers AXP313a PMIC support
|
|
Commit Message
Andre Przywara
March 24, 2023, 11:30 a.m. UTC
From: Martin Botka <martin.botka@somainline.org> The X-Powers AXP313a is a PMIC used on some devices with the Allwinner H616 or H313 SoC. According to the datasheet, the DC/DC converter PWM frequency is fixed (to 3 MHz), so disallow the property that lets us set this frequency for the other PMICs. Signed-off-by: Martin Botka <martin.botka@somainline.org> Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- .../devicetree/bindings/mfd/x-powers,axp152.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Comments
On 24/03/2023 12:30, Andre Przywara wrote: > From: Martin Botka <martin.botka@somainline.org> > > The X-Powers AXP313a is a PMIC used on some devices with the Allwinner > H616 or H313 SoC. > According to the datasheet, the DC/DC converter PWM frequency is fixed > (to 3 MHz), so disallow the property that lets us set this frequency > for the other PMICs. > > Signed-off-by: Martin Botka <martin.botka@somainline.org> > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > .../devicetree/bindings/mfd/x-powers,axp152.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > index b7a8747d5fa0e..4b4f42cb09ef7 100644 > --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > @@ -79,6 +79,17 @@ allOf: > required: > - interrupts > > + - if: > + properties: > + compatible: > + contains: > + const: x-powers,axp313a > + > + then: > + not: > + required: > + - x-powers,dcdc-freq Should be simpler x-powers,dcdc-freq: false I'll fix the other cases. Best regards, Krzysztof
On Sat, 25 Mar 2023 12:40:38 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: Hi, > On 24/03/2023 12:30, Andre Przywara wrote: > > From: Martin Botka <martin.botka@somainline.org> > > > > The X-Powers AXP313a is a PMIC used on some devices with the Allwinner > > H616 or H313 SoC. > > According to the datasheet, the DC/DC converter PWM frequency is fixed > > (to 3 MHz), so disallow the property that lets us set this frequency > > for the other PMICs. > > > > Signed-off-by: Martin Botka <martin.botka@somainline.org> > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > > --- > > .../devicetree/bindings/mfd/x-powers,axp152.yaml | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > > index b7a8747d5fa0e..4b4f42cb09ef7 100644 > > --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > > +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml > > @@ -79,6 +79,17 @@ allOf: > > required: > > - interrupts > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: x-powers,axp313a > > + > > + then: > > + not: > > + required: > > + - x-powers,dcdc-freq > > Should be simpler x-powers,dcdc-freq: false Ah, many thanks! I was a bit concerned about "not required" not sounding quite right, but I indeed copied from the other cases and verified that it worked as expected. But yours is indeed much better, thanks for the other patch! Cheers, Andre > I'll fix the other cases. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml index b7a8747d5fa0e..4b4f42cb09ef7 100644 --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml @@ -79,6 +79,17 @@ allOf: required: - interrupts + - if: + properties: + compatible: + contains: + const: x-powers,axp313a + + then: + not: + required: + - x-powers,dcdc-freq + properties: compatible: oneOf: @@ -88,6 +99,7 @@ properties: - x-powers,axp209 - x-powers,axp221 - x-powers,axp223 + - x-powers,axp313a - x-powers,axp803 - x-powers,axp806 - x-powers,axp809