diff mbox series

[v2,2/5] dt-bindings: misc: qcom,fastrpc: allow FastRPC node without reg entry

Message ID 20230327184811.499553-3-me@dylanvanassche.be
State New
Headers
Series dts: qcom: arm64: sdm845: SLPI DSP enablement |

Commit Message

Dylan Van Assche March 27, 2023, 6:48 p.m. UTC 
  FastRPC nodes may exist without a registry property and actual
Compute Banks  in some cases such as the SLPI on the Qualcomm SDM845 SoC.
Relax the regex to allow such FastRPC nodes and remove 'reg' as a
required property.

Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
---
 Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Krzysztof Kozlowski March 27, 2023, 7:35 p.m. UTC | #1 
On 27/03/2023 20:48, Dylan Van Assche wrote:
> FastRPC nodes may exist without a registry property and actual

Why would they exist without unit address?

> Compute Banks  in some cases such as the SLPI on the Qualcomm SDM845 SoC.

I do not see there anything disallowing unit address yet...


> Relax the regex to allow such FastRPC nodes and remove 'reg' as a
> required property.

No, at least not without proper explanation why unit address is not
allowed for these.


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
index 1ab9588cdd89..0ccd3296d4f2 100644
--- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
+++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
@@ -64,7 +64,7 @@  properties:
     const: 0
 
 patternProperties:
-  "(compute-)?cb@[0-9]*$":
+  "(compute-)?cb(@[0-9]*)?$":
     type: object
 
     description: >
@@ -89,7 +89,6 @@  patternProperties:
 
     required:
       - compatible
-      - reg
 
     additionalProperties: false