Message ID | 20230325110004.363898-1-lizetao1@huawei.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp175133vqo; Fri, 24 Mar 2023 20:23:27 -0700 (PDT) X-Google-Smtp-Source: AKy350bexcLMvykS1MAk6w68PVZZAFtSAgrTjSLcsSbwkwUB69+Otsp+Zfte0BpS4NnuE1HYqNq4 X-Received: by 2002:a17:907:3f27:b0:870:b950:18d4 with SMTP id hq39-20020a1709073f2700b00870b95018d4mr6380630ejc.5.1679714607687; Fri, 24 Mar 2023 20:23:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679714607; cv=none; d=google.com; s=arc-20160816; b=jkkpCR/Vg+XkVvB74BVcngp3BqXfRZmj3q5klw70x+0gcaYZ58LHJN8+cTdg2ohS/c IdrytfWNBPx5EGWqccUJ5ztjYaWoy/pqJfh0fNFR+CGT+B+azIK7MIK8EIwzqofKUcQv P/FYc+ysrsfBiuOy7Z0AqRQFIMNpov++yG4fOP+jTNCscQVmqlPXlP3js8VVuLppaPv8 3r38UOj8gN5pivcsSuUYdT9XwbDccRC5jgeOm2QgGszeQ9x9A+Bhk/WERNEOoy5/695J gQDwEX84CvGyVbT4L2qOUYkq6MVkcGaoX/GpTf/hns/Zs16NHXRzF/P5FEOIlolG4kMs 28pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=EsxCNV6AeGP/O7B4GMmyN3igtFmWE6n7Tv/goZuq34Y=; b=zNXd538eVxrxjCl16WXhC77NKX69w4p7Xvy0Fx7tjRfE/zngfX7Ec7SK0wTsUal3m9 5J3h5Iemw2dGilITO24jB0AgmtSMQwImKYFeR0lD9H+1UyqLMxW6sdah8PDr4457uNCq mk6/TdKJ0UZWfe2361reSM3pM7Al5z9Yq9faru8JphONOIIg6FAZMK9Q/aYOX8mG6HcE p7FKoHPAlQ3sgHU9FgbbpKXeMeNuYKlv16Je5+V0S/ROiTXI42+f5iB+aZ7fMDESuAxa rqZ4lm5gctsJVmsoIyjTgDxzOicAXqhsAdHy85C/riqlgIbeG4N5q7ibavhJyexb6Fd2 NvvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wu12-20020a170906eecc00b0093a36bdabe8si14123087ejb.807.2023.03.24.20.22.55; Fri, 24 Mar 2023 20:23:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232186AbjCYDAZ (ORCPT <rfc822;makky5685@gmail.com> + 99 others); Fri, 24 Mar 2023 23:00:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231681AbjCYDAY (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 24 Mar 2023 23:00:24 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96DDE14200; Fri, 24 Mar 2023 20:00:22 -0700 (PDT) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Pk3dF6GVTzSnnq; Sat, 25 Mar 2023 10:56:49 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Sat, 25 Mar 2023 11:00:18 +0800 From: Li Zetao <lizetao1@huawei.com> To: <njavali@marvell.com>, <GR-QLogic-Storage-Upstream@marvell.com>, <jejb@linux.ibm.com>, <martin.petersen@oracle.com>, <himanshu.madhani@cavium.com>, <quinn.tran@cavium.com> CC: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH] scsi: qla2xxx: Fix memory leak in qla2x00_probe_one() Date: Sat, 25 Mar 2023 11:00:04 +0000 Message-ID: <20230325110004.363898-1-lizetao1@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.3 required=5.0 tests=DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761308424413099099?= X-GMAIL-MSGID: =?utf-8?q?1761308424413099099?= |
Series |
scsi: qla2xxx: Fix memory leak in qla2x00_probe_one()
|
|
Commit Message
Li Zetao
March 25, 2023, 11 a.m. UTC
There is a memory leak reported by kmemleak:
unreferenced object 0xffffc900003f0000 (size 12288):
comm "modprobe", pid 19117, jiffies 4299751452 (age 42490.264s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<00000000629261a8>] __vmalloc_node_range+0xe56/0x1110
[<0000000001906886>] __vmalloc_node+0xbd/0x150
[<000000005bb4dc34>] vmalloc+0x25/0x30
[<00000000a2dc1194>] qla2x00_create_host+0x7a0/0xe30 [qla2xxx]
[<0000000062b14b47>] qla2x00_probe_one+0x2eb8/0xd160 [qla2xxx]
[<00000000641ccc04>] local_pci_probe+0xeb/0x1a0
The root cause is traced to an error handling path in qla2x00_probe_one()
when the adapter "base_vha" initialize failed. The fab_scan_rp "scan.l"
is used to record the port information and it is alloced in
qla2x00_create_host(). However, it is not released in the error handling
path "probe_failed".
Fix it by freeing the memory of "scan.l" when an error occurs in adapter
initialize process.
Fixes: a4239945b8ad ("scsi: qla2xxx: Add switch command to simplify fabric discovery")
Signed-off-by: Li Zetao <lizetao1@huawei.com>
---
drivers/scsi/qla2xxx/qla_os.c | 1 +
1 file changed, 1 insertion(+)
Comments
> On Mar 25, 2023, at 4:00 AM, Li Zetao <lizetao1@huawei.com> wrote: > > There is a memory leak reported by kmemleak: > > unreferenced object 0xffffc900003f0000 (size 12288): > comm "modprobe", pid 19117, jiffies 4299751452 (age 42490.264s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [<00000000629261a8>] __vmalloc_node_range+0xe56/0x1110 > [<0000000001906886>] __vmalloc_node+0xbd/0x150 > [<000000005bb4dc34>] vmalloc+0x25/0x30 > [<00000000a2dc1194>] qla2x00_create_host+0x7a0/0xe30 [qla2xxx] > [<0000000062b14b47>] qla2x00_probe_one+0x2eb8/0xd160 [qla2xxx] > [<00000000641ccc04>] local_pci_probe+0xeb/0x1a0 > > The root cause is traced to an error handling path in qla2x00_probe_one() > when the adapter "base_vha" initialize failed. The fab_scan_rp "scan.l" > is used to record the port information and it is alloced in > qla2x00_create_host(). However, it is not released in the error handling > path "probe_failed". > > Fix it by freeing the memory of "scan.l" when an error occurs in adapter > initialize process. > > Fixes: a4239945b8ad ("scsi: qla2xxx: Add switch command to simplify fabric discovery") > Signed-off-by: Li Zetao <lizetao1@huawei.com> > --- > drivers/scsi/qla2xxx/qla_os.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c > index 80c4ee9df2a4..38916e11684d 100644 > --- a/drivers/scsi/qla2xxx/qla_os.c > +++ b/drivers/scsi/qla2xxx/qla_os.c > @@ -3606,6 +3606,7 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id) > probe_failed: > qla_enode_stop(base_vha); > qla_edb_stop(base_vha); > + vfree(base_vha->scan.l); > if (base_vha->gnl.l) { > dma_free_coherent(&ha->pdev->dev, base_vha->gnl.size, > base_vha->gnl.l, base_vha->gnl.ldma); > -- > 2.34.1 > Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
On Sat, 25 Mar 2023 11:00:04 +0000, Li Zetao wrote: > There is a memory leak reported by kmemleak: > > unreferenced object 0xffffc900003f0000 (size 12288): > comm "modprobe", pid 19117, jiffies 4299751452 (age 42490.264s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [<00000000629261a8>] __vmalloc_node_range+0xe56/0x1110 > [<0000000001906886>] __vmalloc_node+0xbd/0x150 > [<000000005bb4dc34>] vmalloc+0x25/0x30 > [<00000000a2dc1194>] qla2x00_create_host+0x7a0/0xe30 [qla2xxx] > [<0000000062b14b47>] qla2x00_probe_one+0x2eb8/0xd160 [qla2xxx] > [<00000000641ccc04>] local_pci_probe+0xeb/0x1a0 > > [...] Applied to 6.3/scsi-fixes, thanks! [1/1] scsi: qla2xxx: Fix memory leak in qla2x00_probe_one() https://git.kernel.org/mkp/scsi/c/85ade4010e13
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 80c4ee9df2a4..38916e11684d 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -3606,6 +3606,7 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id) probe_failed: qla_enode_stop(base_vha); qla_edb_stop(base_vha); + vfree(base_vha->scan.l); if (base_vha->gnl.l) { dma_free_coherent(&ha->pdev->dev, base_vha->gnl.size, base_vha->gnl.l, base_vha->gnl.ldma);