Message ID | 20230315181902.4177819-6-joel@joelfernandes.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp50005wrt; Wed, 15 Mar 2023 11:23:12 -0700 (PDT) X-Google-Smtp-Source: AK7set8uA0JieLfyoZ2mYUsO+GMIBAgOtaYTkswbNBd41mkC4BwLiKnXAB6QdJL78lTE90FiJ5Fd X-Received: by 2002:a05:6a20:1613:b0:d6:c92:9925 with SMTP id l19-20020a056a20161300b000d60c929925mr794578pzj.31.1678904592589; Wed, 15 Mar 2023 11:23:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904592; cv=none; d=google.com; s=arc-20160816; b=q9l6c/kaBDl+BtopYd7lTw/GvYrgWgkMxz2MHKq1/EvcjJ3T8unxKHCt3d4Zrvc06B guKYh6rM6CDaV3F5xb+09FQkrTvhAAZhrmVvtKF0eayYByZaHHzHldRkRW3lKsOfhKvI 1ILJxhmseb2wVIJBPI9lep0mq3wGnOpC/0x7x39CPQXNq2EuLyi21vtCGiPBWZxyM2v6 om5Bkky7WewIOnYnDROvRRcGKI0TO0aQXIRdvxeA+/0r1b1vZeRRg8X6lsPsyxaHK3JS He0qZkp22Y/G21rknjV/d0hqFBIhtAQoxD34REFiVztE0I9BPyfxb9ojHoLNo7uBrL3q OQiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Y6P3avYFLfmZWtirttMewFieZIFd8qLJc55Dm6AWaNQ=; b=VreuAwa4scyfasT9g3ndNwGGazn8+wQ4sERsNWxjtZTPFxKZb+cFCePMy31tmrb84j ixtbaDWiQhDMPHKyIcyS8qstT5P9ZtZ2d7NrWLiJg2ykKfu7ijfmtErQJ2BL7ueiNc7B vPszLKS35mMAgfv/mCHFI6Ei7iB3CNiqYUTRI8pvfy/R9P+wxjnlm8R7asuc7IFEvEEK Gei4eG82MAYmxCGQNX6Xybfo0RGvf3gmSyG8uhjPXmj8cXo6D2eVeUExPywm45KQciXp 258YRcR6pyvb/Cv1dlwgIp/oDnEqBDDf4+Bn51h0sEt/X0HKEZ6hICpswsjh6Em1NzEL kfxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=AfJO3WF6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m13-20020a6545cd000000b004fb95253a18si5549944pgr.376.2023.03.15.11.23.00; Wed, 15 Mar 2023 11:23:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=AfJO3WF6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232670AbjCOSTr (ORCPT <rfc822;ruipengqi7@gmail.com> + 99 others); Wed, 15 Mar 2023 14:19:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232536AbjCOSTl (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 15 Mar 2023 14:19:41 -0400 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73DFE5BCBB for <linux-kernel@vger.kernel.org>; Wed, 15 Mar 2023 11:19:32 -0700 (PDT) Received: by mail-qt1-x831.google.com with SMTP id cf14so17177557qtb.10 for <linux-kernel@vger.kernel.org>; Wed, 15 Mar 2023 11:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y6P3avYFLfmZWtirttMewFieZIFd8qLJc55Dm6AWaNQ=; b=AfJO3WF6GZ+yRdTZNjn5moqlE0pcfcwzJyR8ecGuewfHyPT8CvRJVgvhX9FiypD/QW 4t/r8YuGdxUFqFX4s51NsQEsnlk7EzA/hmPFQFKgHtdisgnd9MzLrJ6+3B7j282f7ItC f4V0U1tDhWGzVLkggiaSkFqTi3L4T7gF+mFrc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y6P3avYFLfmZWtirttMewFieZIFd8qLJc55Dm6AWaNQ=; b=G6vhlN/oI6lyUiTsrr/wpfu42S5hBofd5EI0H+/u1GyBNaLU78RkL00eAF2ESJE/HM xQvWKy57X2YqAE+kiUe3YSoklXwPDDuMJnPFF1ZroCPKUkrm2Nd6iWNyx1aKwr3qlJCT RzGj/O8IMZptI9MqVb6vqOr1AOOpqlkQRnPxAvskYR+yY4aMWd8pC4FzMW0jULa2Vy0T 901eUBGrBx1OiJo6NIC4+8Oyhing3SnvcizHxEhQhrQHiWNd43jKEIEMzzak2fH772Cq 94T8Z97qtLNm41cRYiBxU75gd3dCgvHPzseww1s6ILRgWDGY7X3a5R1Sf26+YQGxSYmN Cuvw== X-Gm-Message-State: AO0yUKWOZ/oud6PxPNbgG9v2kBpE3pG3M04oAsDNN40FSpV37HQZwxnw X/LVOt55qV0cDz8hwfeERUb+9g== X-Received: by 2002:ac8:5e0c:0:b0:3b8:6a20:675e with SMTP id h12-20020ac85e0c000000b003b86a20675emr1472979qtx.29.1678904370959; Wed, 15 Mar 2023 11:19:30 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:30 -0700 (PDT) From: "Joel Fernandes (Google)" <joel@joelfernandes.org> To: Saeed Mahameed <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Boris Pismenny <borisp@nvidia.com> Cc: "Uladzislau Rezki (Sony)" <urezki@gmail.com>, Ariel Levkovich <lariel@nvidia.com>, Vlad Buslov <vladbu@nvidia.com>, "Paul E . McKenney" <paulmck@kernel.org>, Joel Fernandes <joel@joelfernandes.org>, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 06/14] net/mlx5: Rename kfree_rcu() to kfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:18:53 +0000 Message-Id: <20230315181902.4177819-6-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459062258398536?= X-GMAIL-MSGID: =?utf-8?q?1760459062258398536?= |
Series |
[v2,01/14] drbd: Rename kvfree_rcu() to kvfree_rcu_mightsleep()
|
|
Commit Message
Joel Fernandes
March 15, 2023, 6:18 p.m. UTC
From: "Uladzislau Rezki (Sony)" <urezki@gmail.com> The kfree_rcu() and kvfree_rcu() macros' single-argument forms are deprecated. Therefore switch to the new kfree_rcu_mightsleep() and kvfree_rcu_mightsleep() variants. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. Cc: Ariel Levkovich <lariel@nvidia.com> Cc: Saeed Mahameed <saeedm@nvidia.com> Cc: Vlad Buslov <vladbu@nvidia.com> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> Signed-off-by: Paul E. McKenney <paulmck@kernel.org> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> --- drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
Comments
On Wed, Mar 15, 2023 at 2:19 PM Joel Fernandes (Google) <joel@joelfernandes.org> wrote: > > From: "Uladzislau Rezki (Sony)" <urezki@gmail.com> > > The kfree_rcu() and kvfree_rcu() macros' single-argument forms are > deprecated. Therefore switch to the new kfree_rcu_mightsleep() and > kvfree_rcu_mightsleep() variants. The goal is to avoid accidental use > of the single-argument forms, which can introduce functionality bugs in > atomic contexts and latency bugs in non-atomic contexts. In a world where patches anxiously await their precious Ack, could today be our lucky day on this one? We need Acks to take this in for 6.4. David? Others? - Joel > > Cc: Ariel Levkovich <lariel@nvidia.com> > Cc: Saeed Mahameed <saeedm@nvidia.com> > Cc: Vlad Buslov <vladbu@nvidia.com> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > --- > drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c | 2 +- > drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c > index ca834bbcb44f..8afcec0c5d3c 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c > @@ -242,7 +242,7 @@ mlx5e_int_port_remove(struct mlx5e_tc_int_port_priv *priv, > mlx5_del_flow_rules(int_port->rx_rule); > mapping_remove(ctx, int_port->mapping); > mlx5e_int_port_metadata_free(priv, int_port->match_metadata); > - kfree_rcu(int_port); > + kfree_rcu_mightsleep(int_port); > priv->num_ports--; > } > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c > index 08d0929e8260..b811dad7370a 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c > @@ -670,7 +670,7 @@ static int mlx5e_macsec_del_txsa(struct macsec_context *ctx) > > mlx5e_macsec_cleanup_sa(macsec, tx_sa, true); > mlx5_destroy_encryption_key(macsec->mdev, tx_sa->enc_key_id); > - kfree_rcu(tx_sa); > + kfree_rcu_mightsleep(tx_sa); > macsec_device->tx_sa[assoc_num] = NULL; > > out: > @@ -849,7 +849,7 @@ static void macsec_del_rxsc_ctx(struct mlx5e_macsec *macsec, struct mlx5e_macsec > xa_erase(&macsec->sc_xarray, rx_sc->sc_xarray_element->fs_id); > metadata_dst_free(rx_sc->md_dst); > kfree(rx_sc->sc_xarray_element); > - kfree_rcu(rx_sc); > + kfree_rcu_mightsleep(rx_sc); > } > > static int mlx5e_macsec_del_rxsc(struct macsec_context *ctx) > -- > 2.40.0.rc1.284.g88254d51c5-goog >
On 26 Mar 08:34, Joel Fernandes wrote: >On Wed, Mar 15, 2023 at 2:19 PM Joel Fernandes (Google) ><joel@joelfernandes.org> wrote: >> >> From: "Uladzislau Rezki (Sony)" <urezki@gmail.com> >> >> The kfree_rcu() and kvfree_rcu() macros' single-argument forms are >> deprecated. Therefore switch to the new kfree_rcu_mightsleep() and >> kvfree_rcu_mightsleep() variants. The goal is to avoid accidental use >> of the single-argument forms, which can introduce functionality bugs in >> atomic contexts and latency bugs in non-atomic contexts. > >In a world where patches anxiously await their precious Ack, could >today be our lucky day on this one? > >We need Acks to take this in for 6.4. David? Others? > For mlx5 usually me, but since this is a larger series that is not mlx5 centric and targeting multiple tree, I really don't know which subsystem you should be targeting.. for netdev submissions you need to specify the targeted branch e.g. [PATCH v2 net-next 06/14] ... FWIW: Reviewed-by: Saeed Mahameed <saeedm@nvidia.com> > - Joel > > >> >> Cc: Ariel Levkovich <lariel@nvidia.com> >> Cc: Saeed Mahameed <saeedm@nvidia.com> >> Cc: Vlad Buslov <vladbu@nvidia.com> >> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> >> Signed-off-by: Paul E. McKenney <paulmck@kernel.org> >> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> >> --- >> drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c | 2 +- >> drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c >> index ca834bbcb44f..8afcec0c5d3c 100644 >> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c >> @@ -242,7 +242,7 @@ mlx5e_int_port_remove(struct mlx5e_tc_int_port_priv *priv, >> mlx5_del_flow_rules(int_port->rx_rule); >> mapping_remove(ctx, int_port->mapping); >> mlx5e_int_port_metadata_free(priv, int_port->match_metadata); >> - kfree_rcu(int_port); >> + kfree_rcu_mightsleep(int_port); >> priv->num_ports--; >> } >> >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c >> index 08d0929e8260..b811dad7370a 100644 >> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c >> @@ -670,7 +670,7 @@ static int mlx5e_macsec_del_txsa(struct macsec_context *ctx) >> >> mlx5e_macsec_cleanup_sa(macsec, tx_sa, true); >> mlx5_destroy_encryption_key(macsec->mdev, tx_sa->enc_key_id); >> - kfree_rcu(tx_sa); >> + kfree_rcu_mightsleep(tx_sa); >> macsec_device->tx_sa[assoc_num] = NULL; >> >> out: >> @@ -849,7 +849,7 @@ static void macsec_del_rxsc_ctx(struct mlx5e_macsec *macsec, struct mlx5e_macsec >> xa_erase(&macsec->sc_xarray, rx_sc->sc_xarray_element->fs_id); >> metadata_dst_free(rx_sc->md_dst); >> kfree(rx_sc->sc_xarray_element); >> - kfree_rcu(rx_sc); >> + kfree_rcu_mightsleep(rx_sc); >> } >> >> static int mlx5e_macsec_del_rxsc(struct macsec_context *ctx) >> -- >> 2.40.0.rc1.284.g88254d51c5-goog >>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c index ca834bbcb44f..8afcec0c5d3c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c @@ -242,7 +242,7 @@ mlx5e_int_port_remove(struct mlx5e_tc_int_port_priv *priv, mlx5_del_flow_rules(int_port->rx_rule); mapping_remove(ctx, int_port->mapping); mlx5e_int_port_metadata_free(priv, int_port->match_metadata); - kfree_rcu(int_port); + kfree_rcu_mightsleep(int_port); priv->num_ports--; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c index 08d0929e8260..b811dad7370a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c @@ -670,7 +670,7 @@ static int mlx5e_macsec_del_txsa(struct macsec_context *ctx) mlx5e_macsec_cleanup_sa(macsec, tx_sa, true); mlx5_destroy_encryption_key(macsec->mdev, tx_sa->enc_key_id); - kfree_rcu(tx_sa); + kfree_rcu_mightsleep(tx_sa); macsec_device->tx_sa[assoc_num] = NULL; out: @@ -849,7 +849,7 @@ static void macsec_del_rxsc_ctx(struct mlx5e_macsec *macsec, struct mlx5e_macsec xa_erase(&macsec->sc_xarray, rx_sc->sc_xarray_element->fs_id); metadata_dst_free(rx_sc->md_dst); kfree(rx_sc->sc_xarray_element); - kfree_rcu(rx_sc); + kfree_rcu_mightsleep(rx_sc); } static int mlx5e_macsec_del_rxsc(struct macsec_context *ctx)