arm64: dts: imx8mm-evk: correct pmic clock source

Message ID 20230327100321.1682333-1-peng.fan@oss.nxp.com
State New
Headers
Series arm64: dts: imx8mm-evk: correct pmic clock source |

Commit Message

Peng Fan (OSS) March 27, 2023, 10:03 a.m. UTC
  From: Peng Fan <peng.fan@nxp.com>

The osc_32k supports #clock-cells as 0, using an id is wrong, drop it.

Fixes: a6a355ede574 ("arm64: dts: imx8mm-evk: Add 32.768 kHz clock to PMIC")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Marco Felsch March 27, 2023, 10:17 a.m. UTC | #1
On 23-03-27, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The osc_32k supports #clock-cells as 0, using an id is wrong, drop it.
> 
> Fixes: a6a355ede574 ("arm64: dts: imx8mm-evk: Add 32.768 kHz clock to PMIC")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

> ---
>  arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index d1a6390976a9..3f9dfd4d3884 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -194,7 +194,7 @@ pmic@4b {
>  		rohm,reset-snvs-powered;
>  
>  		#clock-cells = <0>;
> -		clocks = <&osc_32k 0>;
> +		clocks = <&osc_32k>;
>  		clock-output-names = "clk-32k-out";
>  
>  		regulators {
> -- 
> 2.37.1
> 
> 
>
  
Shawn Guo April 5, 2023, 1:22 p.m. UTC | #2
On Mon, Mar 27, 2023 at 06:03:21PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The osc_32k supports #clock-cells as 0, using an id is wrong, drop it.
> 
> Fixes: a6a355ede574 ("arm64: dts: imx8mm-evk: Add 32.768 kHz clock to PMIC")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Applied, thanks!
  

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
index d1a6390976a9..3f9dfd4d3884 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
@@ -194,7 +194,7 @@  pmic@4b {
 		rohm,reset-snvs-powered;
 
 		#clock-cells = <0>;
-		clocks = <&osc_32k 0>;
+		clocks = <&osc_32k>;
 		clock-output-names = "clk-32k-out";
 
 		regulators {