diff mbox series

[-next,1/3] spi: omap2-mcspi: Use devm_platform_get_and_ioremap_resource()

Message ID 20230327055346.76625-1-yang.lee@linux.alibaba.com
State New
Headers
Series [-next,1/3] spi: omap2-mcspi: Use devm_platform_get_and_ioremap_resource() |

Commit Message

Yang Li March 27, 2023, 5:53 a.m. UTC 
  According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/spi/spi-omap2-mcspi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Dhruva Gole March 27, 2023, 8:26 a.m. UTC | #1 
On 27/03/23 11:23, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
For the series,

Reviewed-by: Dhruva Gole <d-gole@ti.com>

>  drivers/spi/spi-omap2-mcspi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
> index d95f0ae033ca..8331e247bf5c 100644
> --- a/drivers/spi/spi-omap2-mcspi.c
> +++ b/drivers/spi/spi-omap2-mcspi.c
> @@ -1477,8 +1477,7 @@ static int omap2_mcspi_probe(struct platform_device *pdev)
>  		master->max_transfer_size = omap2_mcspi_max_xfer_size;
>  	}
>  
> -	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	mcspi->base = devm_ioremap_resource(&pdev->dev, r);
> +	mcspi->base = devm_platform_get_and_ioremap_resource(pdev, 0, &r);
>  	if (IS_ERR(mcspi->base)) {
>  		status = PTR_ERR(mcspi->base);
>  		goto free_master;
Mark Brown March 27, 2023, 5:12 p.m. UTC | #2 
On Mon, 27 Mar 2023 13:53:44 +0800, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> 
> [...]

Applied to

   broonie/spi.git for-next

Thanks!

[1/3] spi: omap2-mcspi: Use devm_platform_get_and_ioremap_resource()
      commit: 5e72620125dfa6b876ea3fe3ad25e4c11b70615a
[2/3] spi: orion: Use devm_platform_get_and_ioremap_resource()
      commit: 36b49126afa22b7f9fe3b16360ef2ab3da6bc376
[3/3] spi: pic32: Use devm_platform_get_and_ioremap_resource()
      commit: d10c878213b0bd2df18639f62af28e93a36d437d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index d95f0ae033ca..8331e247bf5c 100644
--- a/drivers/spi/spi-omap2-mcspi.c
+++ b/drivers/spi/spi-omap2-mcspi.c
@@ -1477,8 +1477,7 @@  static int omap2_mcspi_probe(struct platform_device *pdev)
 		master->max_transfer_size = omap2_mcspi_max_xfer_size;
 	}
 
-	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	mcspi->base = devm_ioremap_resource(&pdev->dev, r);
+	mcspi->base = devm_platform_get_and_ioremap_resource(pdev, 0, &r);
 	if (IS_ERR(mcspi->base)) {
 		status = PTR_ERR(mcspi->base);
 		goto free_master;