diff mbox series

[v3,3/3] dt-bindings: clock: imx8mp: Remove unused IMX8MP_CLK_AUDIO_ROOT

Message ID 1666922026-6943-4-git-send-email-shengjiu.wang@nxp.com
State New
Headers
Series clk: imx8mp: Add audio shared gate |

Commit Message

Shengjiu Wang Oct. 28, 2022, 1:53 a.m. UTC 
  Remove unused IMX8MP_CLK_AUDIO_ROOT which is replaced by
IMX8MP_CLK_AUDIO_AHB_ROOT.

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 include/dt-bindings/clock/imx8mp-clock.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Krzysztof Kozlowski Oct. 28, 2022, 2:17 a.m. UTC | #1 
On 27/10/2022 21:53, Shengjiu Wang wrote:
> Remove unused IMX8MP_CLK_AUDIO_ROOT which is replaced by
> IMX8MP_CLK_AUDIO_AHB_ROOT.

You break users, so this should be a bit better explained.

Best regards,
Krzysztof
Krzysztof Kozlowski Oct. 28, 2022, 2:26 a.m. UTC | #2 
On 27/10/2022 22:20, Shengjiu Wang wrote:
> On Fri, Oct 28, 2022 at 10:17 AM Krzysztof Kozlowski <
> krzysztof.kozlowski@linaro.org> wrote:
> 
>> On 27/10/2022 21:53, Shengjiu Wang wrote:
>>> Remove unused IMX8MP_CLK_AUDIO_ROOT which is replaced by
>>> IMX8MP_CLK_AUDIO_AHB_ROOT.
>>
>> You break users, so this should be a bit better explained.
>>
>> I do a search, but no one is using it...

The commit msg should explain the reason and it didn't. Also a reason
like "I did not find in Linux upstream a user" might not be enough. What
about U-boot? BSD? Other firmwares?

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h
index 2f6fec299662..6619227f51ab 100644
--- a/include/dt-bindings/clock/imx8mp-clock.h
+++ b/include/dt-bindings/clock/imx8mp-clock.h
@@ -286,7 +286,6 @@ 
 #define IMX8MP_CLK_TSENSOR_ROOT			281
 #define IMX8MP_CLK_VPU_ROOT			282
 #define IMX8MP_CLK_MRPR_ROOT			283
-#define IMX8MP_CLK_AUDIO_ROOT			284
 #define IMX8MP_CLK_DRAM_ALT_ROOT		285
 #define IMX8MP_CLK_DRAM_CORE			286
 #define IMX8MP_CLK_ARM				287