| Message ID | 20230325132117.19733-2-me@dylanvanassche.be |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp408441vqo;
Sat, 25 Mar 2023 06:27:15 -0700 (PDT)
X-Google-Smtp-Source:
AK7set+CjR0g/9nrivSmsMvhFQfZrH+S3yAnhmyZiSdsRgccSGXuOq7e5lYFLxYufL0OBYGBu2ut
X-Received: by 2002:a05:6a20:3949:b0:da:e9fa:9c29 with SMTP id
r9-20020a056a20394900b000dae9fa9c29mr11218341pzg.26.1679750834912;
Sat, 25 Mar 2023 06:27:14 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1679750834; cv=none;
d=google.com; s=arc-20160816;
b=jfiUtV0oey6dXmarVVpZ5ZzECRgClXzgLbTjHimMiechgPh1xYg6mlPo/PhzCkVd34
HtgfR9nqCLPwEqEhlfcjHKgchhiE79xyndEO47ekeY1flnpb1W167Mf9ui19ACoj74sW
aAErg1GYecj1TOHpnM4dL/I6cjaw2GrEa0JL0LBHMXuYAYda2yn9E5eY0Uhp0G2OOfll
zYh70wRjZwyFPTMNKBaDkCpaJ1UVACTEPD3MyE5gBSSg2rKNRL6MSaoGaI6HDpjFhdM1
wBceBCtDpB+yYYOmx1bm5s7yQZZ9/dxxKUNo7ptCkecvGNpVjXnmxda/uxvkelRTqqgi
U6gA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=bF9VsuGzSoYgIieRbDoIsSdRfKP285EwWx3I2yVBs9g=;
b=Q8i0H83nJCuZjQ8GNxGlw8/67M78QImw3Kmtn4y4bmlATSUAG3cN9MCekazExhjdJL
oKddOd2oK+xIgeMkEmbO8Y9YFpl8Liqo+svBjAxdjkeneLY4FcOop7H8/PJM+k8BrwPK
wqOUNmcMezyFbpfydazKjwR+LolgN+KGl4iePczUPaxIxl4+qAdAVlTzhsHs1CU/Rvc+
hlqKc3bnYNzKXCRtYkOW3yhQK5lXAebAvKgn+M6QAtXANWanYHgs37Wt3WD+6K9dcRRC
J2enIHuLHHk5hStjBFQjB7dZnmRnYDWPGD2zcNzHa4YeoiBeUTrsXA3gI6dx+neDR1E2
tXCA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@dylanvanassche.be header.s=MBO0001
header.b=0L+bubSx;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=dylanvanassche.be
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
g5-20020a636b05000000b004fc1f5e387esi24265481pgc.817.2023.03.25.06.27.02;
Sat, 25 Mar 2023 06:27:14 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@dylanvanassche.be header.s=MBO0001
header.b=0L+bubSx;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=dylanvanassche.be
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229724AbjCYNWR (ORCPT <rfc822;makky5685@gmail.com> + 99 others);
Sat, 25 Mar 2023 09:22:17 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47866 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231406AbjCYNWP (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sat, 25 Mar 2023 09:22:15 -0400
Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F8661422E;
Sat, 25 Mar 2023 06:22:10 -0700 (PDT)
Received: from smtp102.mailbox.org (smtp102.mailbox.org
[IPv6:2001:67c:2050:b231:465::102])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits)
server-digest SHA256)
(No client certificate requested)
by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4PkKVh2vXdz9sTC;
Sat, 25 Mar 2023 14:22:04 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dylanvanassche.be;
s=MBO0001; t=1679750524;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=bF9VsuGzSoYgIieRbDoIsSdRfKP285EwWx3I2yVBs9g=;
b=0L+bubSxdsh+WXrb3qbDJIL4NHPHUjgiEPm6js2diONIt3HaZMa8TjOFa5klnbqe7qAqfP
kkutaBubL8CY79ZyGYKpiwui4ExLraYNFdstSgiWsiVGlHFd2PqB5CWy25wCfgofi3YNCJ
rpHcH6QVhL0xM061zJrY46dFjP2PgqwQ1gDBXBceKSYY0G8uB0F8+dd9CUI/akd6Ybm4Je
KKSfkFmbT0G/PVsHALNdpsiXG51c1QCx+b4XrB58IfHp+eZoRbbNlg0P/vXWuMkzp1TJpJ
mye0KDog8HqeYsxr5gvHsBhHGTwIY9Sb+cWpkjLagwS5neu9WszrUptU3LVpNg==
From: Dylan Van Assche <me@dylanvanassche.be>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
Dylan Van Assche <me@dylanvanassche.be>
Subject: [PATCH 1/2] dt-bindings: remoteproc: qcom: adsp: add
qcom,sdm845-slpi-pas compatible
Date: Sat, 25 Mar 2023 14:21:16 +0100
Message-Id: <20230325132117.19733-2-me@dylanvanassche.be>
In-Reply-To: <20230325132117.19733-1-me@dylanvanassche.be>
References: <20230325132117.19733-1-me@dylanvanassche.be>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Rspamd-Queue-Id: 4PkKVh2vXdz9sTC
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS
autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1761346411654834520?=
X-GMAIL-MSGID: =?utf-8?q?1761346411654834520?=
|
| Series |
Qualcomm SDM845 SLPI DSP driver support
|
|
Commit Message
Dylan Van Assche
March 25, 2023, 1:21 p.m. UTC
SLPI DSP remoteproc on DSP is defined by the 'qcom,sdm845-slpi-pas'
compatible in the qcom_q6v5_pas driver. Add this compatible to the
devicetree bindings.
Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
---
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 3 +++
1 file changed, 3 insertions(+)
Comments
On 25/03/2023 14:21, Dylan Van Assche wrote: > SLPI DSP remoteproc on DSP is defined by the 'qcom,sdm845-slpi-pas' > compatible in the qcom_q6v5_pas driver. Add this compatible to the > devicetree bindings. > > Signed-off-by: Dylan Van Assche <me@dylanvanassche.be> > --- > Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > index 643ee787a81f..175be01ecd1c 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > @@ -26,6 +26,7 @@ properties: > - qcom,sdm660-adsp-pas > - qcom,sdm845-adsp-pas > - qcom,sdm845-cdsp-pas > + - qcom,sdm845-slpi-pas > > reg: > maxItems: 1 > @@ -63,6 +64,7 @@ allOf: > - qcom,msm8998-adsp-pas > - qcom,sdm845-adsp-pas > - qcom,sdm845-cdsp-pas > + - qcom,sdm845-slpi-pas > then: > properties: > clocks: > @@ -104,6 +106,7 @@ allOf: You miss also if:then: for power-domains. Best regards, Krzysztof
Hi Krzysztof, On Sun, 2023-03-26 at 10:53 +0200, Krzysztof Kozlowski wrote: > On 25/03/2023 14:21, Dylan Van Assche wrote: > > SLPI DSP remoteproc on DSP is defined by the 'qcom,sdm845-slpi-pas' > > compatible in the qcom_q6v5_pas driver. Add this compatible to the > > devicetree bindings. > > > > Signed-off-by: Dylan Van Assche <me@dylanvanassche.be> > > --- > > Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 3 > > +++ > > 1 file changed, 3 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > > b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > > index 643ee787a81f..175be01ecd1c 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > > @@ -26,6 +26,7 @@ properties: > > - qcom,sdm660-adsp-pas > > - qcom,sdm845-adsp-pas > > - qcom,sdm845-cdsp-pas > > + - qcom,sdm845-slpi-pas > > > > reg: > > maxItems: 1 > > @@ -63,6 +64,7 @@ allOf: > > - qcom,msm8998-adsp-pas > > - qcom,sdm845-adsp-pas > > - qcom,sdm845-cdsp-pas > > + - qcom,sdm845-slpi-pas > > then: > > properties: > > clocks: > > @@ -104,6 +106,7 @@ allOf: > > > You miss also if:then: for power-domains. I am not sure what to put for the power-domains, newer remoteprocs from SM8150/SM8250/SM8350 etc. are not in this binding either. Could you elaborate a bit here? Thanks! Kind regards, Dylan Van Assche > > Best regards, > Krzysztof >
On 27/03/2023 13:39, Dylan Van Assche wrote: > Hi Krzysztof, > > On Sun, 2023-03-26 at 10:53 +0200, Krzysztof Kozlowski wrote: >> On 25/03/2023 14:21, Dylan Van Assche wrote: >>> SLPI DSP remoteproc on DSP is defined by the 'qcom,sdm845-slpi-pas' >>> compatible in the qcom_q6v5_pas driver. Add this compatible to the >>> devicetree bindings. >>> >>> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be> >>> --- >>> Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 3 >>> +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >>> b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >>> index 643ee787a81f..175be01ecd1c 100644 >>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >>> @@ -26,6 +26,7 @@ properties: >>> - qcom,sdm660-adsp-pas >>> - qcom,sdm845-adsp-pas >>> - qcom,sdm845-cdsp-pas >>> + - qcom,sdm845-slpi-pas >>> >>> reg: >>> maxItems: 1 >>> @@ -63,6 +64,7 @@ allOf: >>> - qcom,msm8998-adsp-pas >>> - qcom,sdm845-adsp-pas >>> - qcom,sdm845-cdsp-pas >>> + - qcom,sdm845-slpi-pas >>> then: >>> properties: >>> clocks: >>> @@ -104,6 +106,7 @@ allOf: >> >> >> You miss also if:then: for power-domains. > > I am not sure what to put for the power-domains, Doesn't your driver patch clearly state it? > newer remoteprocs from > SM8150/SM8250/SM8350 etc. are not in this binding either. They have their own binding, but why is it an argument to add sdm845-slpi a bit incomplete? > > Could you elaborate a bit here? Thanks! There are already examples of other remoteprocs which do it, so I do not understand why this one is different. What to elaborate more? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml index 643ee787a81f..175be01ecd1c 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml @@ -26,6 +26,7 @@ properties: - qcom,sdm660-adsp-pas - qcom,sdm845-adsp-pas - qcom,sdm845-cdsp-pas + - qcom,sdm845-slpi-pas reg: maxItems: 1 @@ -63,6 +64,7 @@ allOf: - qcom,msm8998-adsp-pas - qcom,sdm845-adsp-pas - qcom,sdm845-cdsp-pas + - qcom,sdm845-slpi-pas then: properties: clocks: @@ -104,6 +106,7 @@ allOf: - qcom,msm8998-slpi-pas - qcom,sdm845-adsp-pas - qcom,sdm845-cdsp-pas + - qcom,sdm845-slpi-pas then: properties: interrupts: