Message ID | 20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-7-3ead1e418fe4@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2831751wrt; Thu, 23 Mar 2023 03:37:00 -0700 (PDT) X-Google-Smtp-Source: AK7set8+9wsEhxws2araAhhDhB8UK73fkGJgYkznKfCdQ44BdJ/YWTmvx2+6NKs1W/kQc1zKafBj X-Received: by 2002:a17:906:370b:b0:8b1:30da:b586 with SMTP id d11-20020a170906370b00b008b130dab586mr9524310ejc.49.1679567820015; Thu, 23 Mar 2023 03:37:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679567820; cv=none; d=google.com; s=arc-20160816; b=veM3vS5NUw8Kwm2d88Vlx2iZnvHGdejf52loZC6EHo4PtSp86JWsfyamtwxz80pvvZ WPohHamKC7fV0zapzpFPd02u9dQt5HC/GOPR26u5pnWwpQoJUlEkGk1xqO78PIhNVTBh z0sVks/JXfq6KZTcXJbstF25iBwwfqhEoADxfS34Il1TcvBVSWWC9nagh5lDvieRfU1F j9Axg5Zv1fxOhz/FaER2sHTRFI50ZR/YqbG4rfKoliPEyI9bFee5JxE00eiE/f3yAd9Z HWTdVR0aYmOhNkwZnlr2Y1XY6qr9hGP4D3S/Tj4XXyTrXmfybq0Vs0dybeqyzP0Tfb1g Jaog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=FaktxrHqSVBJvgr5m72rtimmU8b1rgEPNt97tFbcEsI=; b=G8hMhTDSMslJs+iK+7trN9yJGbormGGDxBtsKqmg8SpCKjHn+mJF2vgmoJIljXU4LW K3zSnn3+xVgJBm43STzcvUCP4TNDAw+sP2iTSQ07xNOjaXbyAdw2loQRNWUaZ/qyQy1q mCeO5h7IRsxipCTOtb4kuGpXneMNm/FFLKInK1Rz+TYkInRhvs4IddjRbI0JlIkhySi7 V2IRRUzHXexlIcCtu+Vdgw92IGiIJezZ6GNp/XLO8JsZPh2qPHoITlc3dDjlWs79PEbS Lzd+mahK2ECMZVy2oMzkUsT2d4Al0n4/w+8yfhUho1BlPaFXiJmmCH3egcgEva22DPQg 4dRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="RA/Lgk4V"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id he41-20020a1709073da900b009324eea0cedsi19928038ejc.72.2023.03.23.03.36.36; Thu, 23 Mar 2023 03:36:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="RA/Lgk4V"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231490AbjCWK02 (ORCPT <rfc822;ezelljr.billy@gmail.com> + 99 others); Thu, 23 Mar 2023 06:26:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231400AbjCWKZ7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 23 Mar 2023 06:25:59 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D41361C7EC for <linux-kernel@vger.kernel.org>; Thu, 23 Mar 2023 03:25:35 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id l27so11546168wrb.2 for <linux-kernel@vger.kernel.org>; Thu, 23 Mar 2023 03:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679567134; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FaktxrHqSVBJvgr5m72rtimmU8b1rgEPNt97tFbcEsI=; b=RA/Lgk4VwDZLxmXqWCBeVhDkzv9+CRUnqPoo9qv4UtG2XacS8baIy+fTIVEV82opdv CAjK2Ah7Dy9KSx5k2zPAgeq2dxSnBLeGXdmEf6/8/VZU0eTtKhmridKEGg/n2wWxlFVF pH68Xtcbv5kZXA82o/cTGLfrcXJIPqgeBLsOdGqziepgcUDnC0IlmjLXgsrIjUvujNKy ATRzK4Chla46roFSYqSZ9kQ1tl1zVSDCzmU5m/eael73KeqBOf1HLH4Mlam0PHYF2S7s MZj+/aYc1u6miyHQ4A6newI6jdqIkfLsMq0vtI8rqmqe7vJz2KYOzrcRo53ggOdnlW/a QhQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679567134; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FaktxrHqSVBJvgr5m72rtimmU8b1rgEPNt97tFbcEsI=; b=ZuYIOOIxhJOBRzbky7vHNBTI6g6r6UVNXt3D4zxolav1YYaQQ76ZMeUg6pPlrk9Y70 yKdCrTDWnuRIZCoU9ACOgPFjFukorz/WTQnOp1B/UAO49Cx4JikJav8icIDidlFVWA/p Om3YdkaLSTSCNxPG7TRryu7o3d6o+q1oopw58isONCTgxWPZXl1JChyvnxpj/Q5sxTee /jiugSpzr9OzAa49fCXWRrFnicfGnaJD/YNhpREqMkOI4iWfT+Hpg683eE/Su7SMzTAV pPuZQGnyNMOEq7Jeg1t6bUXxYgQ2+P7BqjcUi6tbKDMsGaldOFQmA1ZNuew2GGTllOcB 1xUg== X-Gm-Message-State: AAQBX9cZBKLKtEv+Tul+tJYDq5gwdCiIJ6DRioRb/rJxxiH2wUu4XKvg 4G3vcrOL1izQOSbu1HvnOUnq2g== X-Received: by 2002:adf:ff8f:0:b0:2da:53e3:57d1 with SMTP id j15-20020adfff8f000000b002da53e357d1mr2029999wrr.62.1679567134135; Thu, 23 Mar 2023 03:25:34 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id e23-20020a5d5957000000b002cfefa50a8esm15753530wri.98.2023.03.23.03.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 03:25:33 -0700 (PDT) From: Neil Armstrong <neil.armstrong@linaro.org> Date: Thu, 23 Mar 2023 11:25:22 +0100 Subject: [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-7-3ead1e418fe4@linaro.org> References: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-0-3ead1e418fe4@linaro.org> In-Reply-To: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-0-3ead1e418fe4@linaro.org> To: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Lee Jones <lee@kernel.org>, Stephen Boyd <sboyd@kernel.org>, Manivannan Sadhasivam <mani@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com>, Avri Altman <avri.altman@wdc.com>, Bart Van Assche <bvanassche@acm.org> Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, linux-scsi@vger.kernel.org, Neil Armstrong <neil.armstrong@linaro.org> X-Mailer: b4 0.12.1 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761154506541490817?= X-GMAIL-MSGID: =?utf-8?q?1761154506541490817?= |
Series |
arm64: qcom: sm8450: bindings check cleanup
|
|
Commit Message
Neil Armstrong
March 23, 2023, 10:25 a.m. UTC
Fixes the following DT bindings check error:
ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected)
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
1 file changed, 1 deletion(-)
Comments
On 23/03/2023 11:25, Neil Armstrong wrote: > Fixes the following DT bindings check error: > ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected) > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index ef9bae2e6acc..8ecc48c7c5ef 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 { > "jedec,ufs-2.0"; > reg = <0 0x01d84000 0 0x3000>, > <0 0x01d88000 0 0x8000>; > - reg-names = "std", "ice"; This is also part of: https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.vesa@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi but I actually wonder whether you just missed some binding patch? Best regards, Krzysztof
Hi, On 23/03/2023 11:49, Krzysztof Kozlowski wrote: > On 23/03/2023 11:25, Neil Armstrong wrote: >> Fixes the following DT bindings check error: >> ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected) >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >> index ef9bae2e6acc..8ecc48c7c5ef 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >> @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 { >> "jedec,ufs-2.0"; >> reg = <0 0x01d84000 0 0x3000>, >> <0 0x01d88000 0 0x8000>; >> - reg-names = "std", "ice"; > > This is also part of: > https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.vesa@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi > but I actually wonder whether you just missed some binding patch? I'm aware of Abel's RFC patchset to support shared ICE, but this is a cleanup of the current DT, and the current bindings schema doesn't document reg-names. Neil > > Best regards, > Krzysztof >
Hi Neil, On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote: > Hi, > > On 23/03/2023 11:49, Krzysztof Kozlowski wrote: > > On 23/03/2023 11:25, Neil Armstrong wrote: > > > Fixes the following DT bindings check error: > > > ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected) > > > > > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > > --- > > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > > > index ef9bae2e6acc..8ecc48c7c5ef 100644 > > > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > > > @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 { > > > "jedec,ufs-2.0"; > > > reg = <0 0x01d84000 0 0x3000>, > > > <0 0x01d88000 0 0x8000>; > > > - reg-names = "std", "ice"; > > > > This is also part of: > > https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.vesa@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi > > but I actually wonder whether you just missed some binding patch? > > I'm aware of Abel's RFC patchset to support shared ICE, but this is a cleanup of the current DT, > and the current bindings schema doesn't document reg-names. > The ufs-qcom driver accesses the "ice" registers by name, so the reg-names can't be removed from the device tree. A few months ago there was a patch to fix the device tree schema for qcom,ufs to include the reg-names. It looks like that patch got missed, though: https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com - Eric
On 24/03/2023 07:52, Eric Biggers wrote: > Hi Neil, > > On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote: >> Hi, >> >> On 23/03/2023 11:49, Krzysztof Kozlowski wrote: >>> On 23/03/2023 11:25, Neil Armstrong wrote: >>>> Fixes the following DT bindings check error: >>>> ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected) >>>> >>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >>>> --- >>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>> index ef9bae2e6acc..8ecc48c7c5ef 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>> @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 { >>>> "jedec,ufs-2.0"; >>>> reg = <0 0x01d84000 0 0x3000>, >>>> <0 0x01d88000 0 0x8000>; >>>> - reg-names = "std", "ice"; >>> >>> This is also part of: >>> https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.vesa@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi >>> but I actually wonder whether you just missed some binding patch? >> >> I'm aware of Abel's RFC patchset to support shared ICE, but this is a cleanup of the current DT, >> and the current bindings schema doesn't document reg-names. >> > > The ufs-qcom driver accesses the "ice" registers by name, so the reg-names can't > be removed from the device tree. A few months ago there was a patch to fix the > device tree schema for qcom,ufs to include the reg-names. It looks like that > patch got missed, though: > https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com Exactly. This is why I never saw these warnings. Neil, there are a lot of pending patches, so you need to be sure you run dtbs_check with them applied. Best regards, Krzysztof
Hi Eric, On Fri Mar 24, 2023 at 7:52 AM CET, Eric Biggers wrote: > Hi Neil, > > On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote: > > Hi, > > > > On 23/03/2023 11:49, Krzysztof Kozlowski wrote: > > > On 23/03/2023 11:25, Neil Armstrong wrote: > > > > Fixes the following DT bindings check error: > > > > ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected) > > > > > > > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > > > --- > > > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > > > > index ef9bae2e6acc..8ecc48c7c5ef 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > > > > @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 { > > > > "jedec,ufs-2.0"; > > > > reg = <0 0x01d84000 0 0x3000>, > > > > <0 0x01d88000 0 0x8000>; > > > > - reg-names = "std", "ice"; > > > > > > This is also part of: > > > https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.vesa@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi > > > but I actually wonder whether you just missed some binding patch? > > > > I'm aware of Abel's RFC patchset to support shared ICE, but this is a cleanup of the current DT, > > and the current bindings schema doesn't document reg-names. > > > > The ufs-qcom driver accesses the "ice" registers by name, so the reg-names can't > be removed from the device tree. A few months ago there was a patch to fix the > device tree schema for qcom,ufs to include the reg-names. It looks like that > patch got missed, though: > https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com Are you implying that I should resend the patch or something? Not sure who to bug about applying this patch. Regards Luca > > - Eric
On 24/03/2023 08:26, Luca Weiss wrote: > Hi Eric, > > On Fri Mar 24, 2023 at 7:52 AM CET, Eric Biggers wrote: >> Hi Neil, >> >> On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote: >>> Hi, >>> >>> On 23/03/2023 11:49, Krzysztof Kozlowski wrote: >>>> On 23/03/2023 11:25, Neil Armstrong wrote: >>>>> Fixes the following DT bindings check error: >>>>> ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected) >>>>> >>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >>>>> --- >>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 - >>>>> 1 file changed, 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>> index ef9bae2e6acc..8ecc48c7c5ef 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>> @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 { >>>>> "jedec,ufs-2.0"; >>>>> reg = <0 0x01d84000 0 0x3000>, >>>>> <0 0x01d88000 0 0x8000>; >>>>> - reg-names = "std", "ice"; >>>> >>>> This is also part of: >>>> https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.vesa@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi >>>> but I actually wonder whether you just missed some binding patch? >>> >>> I'm aware of Abel's RFC patchset to support shared ICE, but this is a cleanup of the current DT, >>> and the current bindings schema doesn't document reg-names. >>> >> >> The ufs-qcom driver accesses the "ice" registers by name, so the reg-names can't >> be removed from the device tree. A few months ago there was a patch to fix the >> device tree schema for qcom,ufs to include the reg-names. It looks like that >> patch got missed, though: >> https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com > > Are you implying that I should resend the patch or something? Not sure > who to bug about applying this patch. Yes, you should. It has been almost three months... Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index ef9bae2e6acc..8ecc48c7c5ef 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 { "jedec,ufs-2.0"; reg = <0 0x01d84000 0 0x3000>, <0 0x01d88000 0 0x8000>; - reg-names = "std", "ice"; interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>; phys = <&ufs_mem_phy_lanes>; phy-names = "ufsphy";