Message ID | 20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-6-3ead1e418fe4@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2832883wrt; Thu, 23 Mar 2023 03:40:26 -0700 (PDT) X-Google-Smtp-Source: AK7set8vcEyRgCpmNRwKBmP7RfgfJVhwl98k8Efea520QOYvp5VXkgqTuQ9kDe55lkwpIvR2spG/ X-Received: by 2002:a17:906:3710:b0:923:812c:a5d3 with SMTP id d16-20020a170906371000b00923812ca5d3mr5187705ejc.25.1679568026581; Thu, 23 Mar 2023 03:40:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679568026; cv=none; d=google.com; s=arc-20160816; b=bSuEtxp2+C7lh8z6VxOrWLlBy3/J1WZ5TbZRyc/co2/WTNG8TBksUs3HulkZFdUOsx lnmws0p3/B1woGXj1xqBsMI60AUKYdipCUceVs3Q+Q4hTOFSmYZcy9x7S21UZVzBgNMb xgwhzx7vSkQcCAg2+atq9lKZaNekiN8pVZW+xeJupdZPSeI0v9u3H9kTXxzjf0x1j7Ve wq53uHfRFF8xqNojz9Ptyx8XLbPCWX30G/16XC7Bcn9N0SCaI2GYr+EN26hU9C8kQCg5 t7Av3Ua9H3iIJIAk6XAAVi2T0WhmUCtadWtbrDKhSb2wB9I/tW1ZXUc6o1HJRwmBx5ux 25jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=JLUTPlE00BSnjiP+YKOutfDTs6tTX6QAssulhGKRHLM=; b=M0JgHAB4KbW/mWTh863anUa8pwhcV3cjbf6Nx/vIPfFJYXk7f9fl65J82YHJFk1NIC QU/c/jkd6sNgTaEVnBrmiBDLlSjEr32WGKVyA+O+ZY6fHEPy9iIXrL5qMIz0DPFR/JCE GDfMPTG3okym6MYJYzSyPG6xtlZwKrz2SdaPwnxNr0PrMT3U5215RQ4clGM4aTv2Dfvr yhrXmgK+ZfM/UI2mbSrAJh5i9HCFMu5Zd+5iiyru52vPQGcwx5hwoJ/tgOKH16TcEUyf o0bslGm+tjL5famHE2VLbAV7U5wvOVQwDVss7F3JLHeddjf1AgzO3RTTfi/2nBJwjwdt F6ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=R48HHx1w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w25-20020a170906b19900b0092fbd283e79si18135702ejy.319.2023.03.23.03.40.03; Thu, 23 Mar 2023 03:40:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=R48HHx1w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231395AbjCWK0Y (ORCPT <rfc822;ezelljr.billy@gmail.com> + 99 others); Thu, 23 Mar 2023 06:26:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231362AbjCWKZz (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 23 Mar 2023 06:25:55 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92CC91C33D for <linux-kernel@vger.kernel.org>; Thu, 23 Mar 2023 03:25:34 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id h17so19855363wrt.8 for <linux-kernel@vger.kernel.org>; Thu, 23 Mar 2023 03:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679567133; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JLUTPlE00BSnjiP+YKOutfDTs6tTX6QAssulhGKRHLM=; b=R48HHx1wdjnhsHgZ4ALbYG0+8j5SMxooMuHnduChZHWwZ0OZgwykIJ+MkPtslt7r0N /wF/FuDu1ONXfoH65B19fv9bddghDB7pFtm3bKCiTIXM5bFO67PiNTUphoTFh78n+Aji st7CqyEQ014AMyKaW2V7iBNOgL/BDbCnnVnsZU3MnLSQct4Y6WEN8uVBA35bnY87IGV3 A1ZmLm3Z5MbuNfateEye6dFjAf1p2Sg1hZ/TOJ8hhZ418TCTE77tCkNqeKRG9SNih5HO 6QRbR6dIRE8+jVvZqg7fVfRpp5XmJqLydMorfJTPnBYb5h8y9L18rlhp2WLeKvgHr02z Ho7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679567133; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JLUTPlE00BSnjiP+YKOutfDTs6tTX6QAssulhGKRHLM=; b=cHhFThSAzQsBSRuIKb5B+jUqM/j5ySFI+u8ISd+AnTgGBx49Bu2Yu0g7ogJIgtHKC0 gDuPkL7S3tLrU+Dxx7ZLiNWXRHfvLWV8XPkBwOSi1m2rwlUssBtroB9yzCaASHgHq52i ivZiizg07/XGHU4rAvgBbJEjpmSCtPjyTSAUBAvpu4qvFaRv4rHqbqJSXEKn/zZr1EQ4 TOvFQ8gKcptWkpynZdT3aJX1XaWCyuJEoS7uOc36S+Ia+2+LL0pEbT67hG/Y8qqsyv2k GjtdBYeVwFTJTgbOmy5W0H8ieJ4BSIbsEaKjX9H7L1hkH5DlR6RLzM1IngZi09W0H6eH oRyQ== X-Gm-Message-State: AAQBX9erVQQh1ebUNbaXoC3eUHJR8SFtShQA3DEsAqPXEmqf+2ONNCGO E2jGNxPqIX6exJfQVZoXkIBGaQ== X-Received: by 2002:a5d:6709:0:b0:2cf:e449:1a9e with SMTP id o9-20020a5d6709000000b002cfe4491a9emr1930821wru.30.1679567132966; Thu, 23 Mar 2023 03:25:32 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id e23-20020a5d5957000000b002cfefa50a8esm15753530wri.98.2023.03.23.03.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 03:25:32 -0700 (PDT) From: Neil Armstrong <neil.armstrong@linaro.org> Date: Thu, 23 Mar 2023 11:25:21 +0100 Subject: [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-6-3ead1e418fe4@linaro.org> References: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-0-3ead1e418fe4@linaro.org> In-Reply-To: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-0-3ead1e418fe4@linaro.org> To: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Lee Jones <lee@kernel.org>, Stephen Boyd <sboyd@kernel.org>, Manivannan Sadhasivam <mani@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com>, Avri Altman <avri.altman@wdc.com>, Bart Van Assche <bvanassche@acm.org> Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, linux-scsi@vger.kernel.org, Neil Armstrong <neil.armstrong@linaro.org> X-Mailer: b4 0.12.1 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761154722617153587?= X-GMAIL-MSGID: =?utf-8?q?1761154722617153587?= |
Series |
arm64: qcom: sm8450: bindings check cleanup
|
|
Commit Message
Neil Armstrong
March 23, 2023, 10:25 a.m. UTC
Fixes the following DT bindings check error:
codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long
codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed:
['mclk', 'macro', 'dcodec', 'npl'] is too long
The implementation was checked and this npl clock isn't used for the VA macro.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Comments
On 23/03/2023 11:25, Neil Armstrong wrote: > Fixes the following DT bindings check error: > codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long > codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed: > ['mclk', 'macro', 'dcodec', 'npl'] is too long > > The implementation was checked and this npl clock isn't used for the VA macro. > This does not look correct. DTS looks good, you miss some patches in your tree. Best regards, Krzysztof
On 23/03/2023 11:47, Krzysztof Kozlowski wrote: > On 23/03/2023 11:25, Neil Armstrong wrote: >> Fixes the following DT bindings check error: >> codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long >> codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed: >> ['mclk', 'macro', 'dcodec', 'npl'] is too long >> >> The implementation was checked and this npl clock isn't used for the VA macro. >> > > This does not look correct. DTS looks good, you miss some patches in > your tree. I'm based on today's linux-next, while the other lpass macros uses the npl clock, the lpass vamacro bindings doesn't document the npl clock. And I found no fixes whatsover to add the npl clock to bindings. Neil > > Best regards, > Krzysztof >
On 23/03/2023 14:13, Neil Armstrong wrote: > On 23/03/2023 11:47, Krzysztof Kozlowski wrote: >> On 23/03/2023 11:25, Neil Armstrong wrote: >>> Fixes the following DT bindings check error: >>> codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long >>> codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed: >>> ['mclk', 'macro', 'dcodec', 'npl'] is too long >>> >>> The implementation was checked and this npl clock isn't used for the VA macro. >>> >> >> This does not look correct. DTS looks good, you miss some patches in >> your tree. > > I'm based on today's linux-next, Which is unfortunately not enough. Several things were fixed/added/changed and are pending. I brought the topic of pending branch few times on IRC for that reason. > while the other lpass macros uses the npl clock, > the lpass vamacro bindings doesn't document the npl clock. > > And I found no fixes whatsover to add the npl clock to bindings. Really? lore finds it easily: https://lore.kernel.org/all/20221118071849.25506-2-srinivas.kandagatla@linaro.org/ Best regards, Krzysztof
On 24/03/2023 08:17, Krzysztof Kozlowski wrote: > On 23/03/2023 14:13, Neil Armstrong wrote: >> On 23/03/2023 11:47, Krzysztof Kozlowski wrote: >>> On 23/03/2023 11:25, Neil Armstrong wrote: >>>> Fixes the following DT bindings check error: >>>> codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long >>>> codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed: >>>> ['mclk', 'macro', 'dcodec', 'npl'] is too long >>>> >>>> The implementation was checked and this npl clock isn't used for the VA macro. >>>> >>> >>> This does not look correct. DTS looks good, you miss some patches in >>> your tree. >> >> I'm based on today's linux-next, > > Which is unfortunately not enough. Several things were > fixed/added/changed and are pending. I brought the topic of pending > branch few times on IRC for that reason. > >> while the other lpass macros uses the npl clock, >> the lpass vamacro bindings doesn't document the npl clock. >> >> And I found no fixes whatsover to add the npl clock to bindings. > > Really? lore finds it easily: > > https://lore.kernel.org/all/20221118071849.25506-2-srinivas.kandagatla@linaro.org/ You're better at lore than me... thx anyway... Neil > > > Best regards, > Krzysztof >
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index bcb51e612261..ef9bae2e6acc 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -2321,9 +2321,8 @@ vamacro: codec@33f0000 { reg = <0 0x033f0000 0 0x1000>; clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>, <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, - <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, - <&q6prmcc LPASS_CLK_ID_RX_CORE_MCLK2_2X_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>; - clock-names = "mclk", "macro", "dcodec", "npl"; + <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; + clock-names = "mclk", "macro", "dcodec"; assigned-clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>; assigned-clock-rates = <19200000>;