Message ID | 20230317092711.660897-1-b-kapoor@ti.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp238983wrt; Fri, 17 Mar 2023 02:39:50 -0700 (PDT) X-Google-Smtp-Source: AK7set9/rUM8W1tQzzUeOUqWLV+l0d1i+PNozTxhES5HWzpOuEAqaL2QW+XvAnyip676IhkCrM0S X-Received: by 2002:a17:902:b713:b0:19a:7439:3e98 with SMTP id d19-20020a170902b71300b0019a74393e98mr9387962pls.4.1679045990625; Fri, 17 Mar 2023 02:39:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679045990; cv=none; d=google.com; s=arc-20160816; b=Ww3ZR52hFRHEabw8TXl41mJ+Ikb1bb9wVHY8wcReiHm78BuAMeJEyxMPMTucGjvGz+ T34qEQhvyv+K0YqHdTS9wEppvlwL+yWuSX3dX61ya8RmR4CB4kyTE2JoTpqSbFX3DBBb UykpsyapYDgAnZqqi630LdNYr0tYSaDDfMQxWI/ig/I2xrJG6cxJnsMx5irRS8GGUyid 36a0RL4wgaBUzDiSy7jRkX281Qo7iPOzmt5shtBQIJHHSOtt75O0G+qDFsNHnCr539KJ i2YAd94TZhuzQAuVISpcrlgxgGDKH9JHXuqJl0qDJgh+/jJqn2z6K+0sroD7zJlL3h5o cSZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=HVVYccP7UecLLJfh3xO12QfnKAVW8ZviNqjjuxE2sBM=; b=P2og1Rj2kudfRT6Wnd7pdO8tmZvCzYj0vyyuw6uWJWWtJhjc7ztqwa8Q1wMnnkqsa5 dAB/96tGeJXEgI2azQpQJ7KFfVYctZ9asM8H9AD7GzcAyC1ZmexGXJXJwPKnot3Z4Fab IzEFcpYtWGwitXujlV+w0sXhpmIBkdP1b6fcioIW6/7iIrUyCDrL5AyX0r3AKrv+Xgtp f5DDzMwr/8pXdN09Md9+bWjRDeNSEGPL5j8PcIBPv0/0JvICiFtzgzydklHTy5XkYd1I rba8DwLI5To5HDGsLKoJrlW7PQfZ4jmer1N+fksl2yGifH+vmR8/H1ROZkkS2C9gUvDL aYCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=RGg7Ns5r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v3-20020a1709028d8300b001a076b5a192si1936580plo.326.2023.03.17.02.39.38; Fri, 17 Mar 2023 02:39:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=RGg7Ns5r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231157AbjCQJ2T (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Fri, 17 Mar 2023 05:28:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230260AbjCQJ2Q (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 17 Mar 2023 05:28:16 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15C97C5AE5; Fri, 17 Mar 2023 02:28:15 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32H9RCva092161; Fri, 17 Mar 2023 04:27:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1679045232; bh=HVVYccP7UecLLJfh3xO12QfnKAVW8ZviNqjjuxE2sBM=; h=From:To:CC:Subject:Date; b=RGg7Ns5r2UkeZDGBSAmrtNcP0/Hq1CBMAN4kYC88/aOlEqG+z2YMjLWRDNlr59YIS 45k/BadOyUMfLp0m8+8xqx7WcMwCAkSkd5sQ4lyRrHx6cWZ5jnpDvt5GcOtyEgxad9 1KQGv8GV1TY+fvCDHKixQvTwOFzOySkOxnaWneMk= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32H9RCpq085387 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Mar 2023 04:27:12 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 17 Mar 2023 04:27:12 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 17 Mar 2023 04:27:12 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32H9RB4n070727; Fri, 17 Mar 2023 04:27:12 -0500 From: Bhavya Kapoor <b-kapoor@ti.com> To: <linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org> CC: <b-kapoor@ti.com>, <ulf.hansson@linaro.org>, <adrian.hunter@intel.com> Subject: [PATCH v2] mmc: sdhci_am654: Set HIGH_SPEED_ENA for SDR12 and SDR25 Date: Fri, 17 Mar 2023 14:57:11 +0530 Message-ID: <20230317092711.660897-1-b-kapoor@ti.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760607328431823373?= X-GMAIL-MSGID: =?utf-8?q?1760607328431823373?= |
Series |
[v2] mmc: sdhci_am654: Set HIGH_SPEED_ENA for SDR12 and SDR25
|
|
Commit Message
Bhavya Kapoor
March 17, 2023, 9:27 a.m. UTC
Timing Information in Datasheet assumes that HIGH_SPEED_ENA=1 should be
set for SDR12 and SDR25 modes. But sdhci_am654 driver clears
HIGH_SPEED_ENA register. Thus, Modify sdhci_am654 to not clear
HIGH_SPEED_ENA (HOST_CONTROL[2]) bit for SDR12 and SDR25 speed modes.
Fixes: e374e87538f4 ("mmc: sdhci_am654: Clear HISPD_ENA in some lower speed modes")
Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
---
Changelog v1->v2:
- Corrected Names of speed modes in commit message
Link to v1: https://lore.kernel.org/all/20230316080451.475020-1-b-kapoor@ti.com/
drivers/mmc/host/sdhci_am654.c | 2 --
1 file changed, 2 deletions(-)
Comments
On Fri, 17 Mar 2023 at 10:28, Bhavya Kapoor <b-kapoor@ti.com> wrote: > > Timing Information in Datasheet assumes that HIGH_SPEED_ENA=1 should be > set for SDR12 and SDR25 modes. But sdhci_am654 driver clears > HIGH_SPEED_ENA register. Thus, Modify sdhci_am654 to not clear > HIGH_SPEED_ENA (HOST_CONTROL[2]) bit for SDR12 and SDR25 speed modes. > > Fixes: e374e87538f4 ("mmc: sdhci_am654: Clear HISPD_ENA in some lower speed modes") > Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com> Applied for fixes and by adding a stable tag, thanks! Kind regards Uffe > --- > > Changelog v1->v2: > - Corrected Names of speed modes in commit message > > Link to v1: https://lore.kernel.org/all/20230316080451.475020-1-b-kapoor@ti.com/ > > drivers/mmc/host/sdhci_am654.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c > index 7ef828942df3..ac90e86bb0a0 100644 > --- a/drivers/mmc/host/sdhci_am654.c > +++ b/drivers/mmc/host/sdhci_am654.c > @@ -351,8 +351,6 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg) > */ > case MMC_TIMING_SD_HS: > case MMC_TIMING_MMC_HS: > - case MMC_TIMING_UHS_SDR12: > - case MMC_TIMING_UHS_SDR25: > val &= ~SDHCI_CTRL_HISPD; > } > } > -- > 2.34.1 >
diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c index 7ef828942df3..ac90e86bb0a0 100644 --- a/drivers/mmc/host/sdhci_am654.c +++ b/drivers/mmc/host/sdhci_am654.c @@ -351,8 +351,6 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg) */ case MMC_TIMING_SD_HS: case MMC_TIMING_MMC_HS: - case MMC_TIMING_UHS_SDR12: - case MMC_TIMING_UHS_SDR25: val &= ~SDHCI_CTRL_HISPD; } }