Message ID | 20221026132838.GA44037@rdm |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp274116wru; Wed, 26 Oct 2022 06:41:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4f4lYWlbSyx6akvXcVIUs5ybqQUpkEOUhRbF3SqpCbpmvhdFldWK5LZd/rMs1KSjvqNT/d X-Received: by 2002:a17:90a:2cc7:b0:212:f074:cf4d with SMTP id n65-20020a17090a2cc700b00212f074cf4dmr4421570pjd.70.1666791682829; Wed, 26 Oct 2022 06:41:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666791682; cv=none; d=google.com; s=arc-20160816; b=qp0bJsPsQxZb+/+/VxImO/jgnncxf327S+CcssjJZthhDtfGRF88ZVKmAvc0AGLv7j x1hkcyU7IyhSEm4GKmpRsoUP/T9f+oGt5w/7/wpZ1OOIbH4P1IS+kv4m3TO3g2meT/Sm ZBjyKeSYasuAVoExTZWVasHUMHzDgHGzoG2FM+etd9uurC6Brp95lA39r8gNCnjaU3PJ h4qQ0sPlvyQXLXXNlU6LVgbnk/bFaznRC3mphQphuNd2ipk7oTzkDWAmpihTDa+Oo2Sd XO83qtEhICaqWD99LR1OAWXBoN6WofkApGcTxVijZ15borSaSW6hzFL4X6oUGNCfgdtk tqeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date:dkim-signature; bh=BQjuqzUbSlDqvGhbLmWueKhvNccMA5rF1ebwhNIRC8o=; b=XJDl8AGM5j9KJBI2Q+JmMMgpUQetKVtPfTn//O7f6R6QTwX7ZNMeAWGxpk8iZMmZXZ ImyWs8xyANk20yCzoM08v4SE3vsSjiYRwHqyApma6ssljwlmEIQ9GMufd1NLD6rLket1 tQn/lYbbaMjv9smD9SjL0RRqN7GIG+ehwvIX4rnVN9R4L78mPoIB8EGOcQeRhNCgL+zz lIJzjemaytua9F4YR6FjzTaQaL2Tuvy2RfD10L4Ut46glRY1rIXp12pp6OESsG/J3Tzk ua7fuG2mMkjvcVR63xOy+4cOWp31OVjWH8neT0b7EEy5uiATlAz05chYJkP8qeAG861c 6JWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="G1//KcT6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o5-20020a170903300500b00176939b5cd9si5593005pla.578.2022.10.26.06.41.08; Wed, 26 Oct 2022 06:41:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="G1//KcT6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233507AbiJZN25 (ORCPT <rfc822;pwkd43@gmail.com> + 99 others); Wed, 26 Oct 2022 09:28:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233040AbiJZN2x (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 26 Oct 2022 09:28:53 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC680DB779 for <linux-kernel@vger.kernel.org>; Wed, 26 Oct 2022 06:28:51 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id w14so2056097wru.8 for <linux-kernel@vger.kernel.org>; Wed, 26 Oct 2022 06:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=BQjuqzUbSlDqvGhbLmWueKhvNccMA5rF1ebwhNIRC8o=; b=G1//KcT6j5z5YfC3wUevGXsdon0yVPojTloeyZWcGQUIBIpxrMzrrmxlKdUMgcoZCC Vzjun/6shaKnwzglVWT5DQi/RVTo0SXYUWk165DbwchhlZtG2EvVyC1aOY8hJeIqoWnt 5dbY0P199x+Dg8MlAcNsjsZFpyvpkuQ2yMUlMEp7FMZaRw+drjxs+/DDwmBTek/dpYQ7 T+q4dVQXQ7SfjsX19UaZLQt1ZRGkq0mhQiQrRRvOI0ZT2n/Ia9SuW0k/gnxhNKdEs70u KKk03DLDus9d0JECKciycUKSEw1dP94wsoJ6Dw2+/HVFhj7eDLfckwDW03CRjrdDvbFE UbSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BQjuqzUbSlDqvGhbLmWueKhvNccMA5rF1ebwhNIRC8o=; b=xs5plmqTa2H+uQj6+GjnBw8RHMbmgytQTXCm9/jX0YNufrKdhpuEOULOXVo4Ikomwz BEeTlaTKfjDSzmglWUNQ9eBYULFhfxgAqOH+HxVfduhgdzqkJ8WBsTmL9e+Lm2UJRX7i TAPb57ymtGXdt1tYpxddizaZ3a71JKPU6jyVny7iFG+/LVA+dDXRtJUzGDQrnN7q3Nws Lp0Q/RnLUr5zCV7Eya2/Kl2VN2uepP+LXcOfw/U/Kf8wNAZwZKTu+v0Q8fHUTBAcYRv/ Xym4I2DoB81TxQvqMnbAFk4wsmk9pM+UllnwJ8GAeNMChTPh3JB/ytEdBZw/0/qOiMu3 lzmQ== X-Gm-Message-State: ACrzQf28DXRT2mn90GdtYTCzM8sadRu+JpBpo1+wPPW5pYZpYTEVJY9w 14s782eKoHu6+rzjHXKInGk= X-Received: by 2002:a5d:42c6:0:b0:235:1b3a:8d2e with SMTP id t6-20020a5d42c6000000b002351b3a8d2emr23154184wrr.689.1666790930423; Wed, 26 Oct 2022 06:28:50 -0700 (PDT) Received: from rdm ([41.75.188.129]) by smtp.gmail.com with ESMTPSA id 24-20020a05600c021800b003c6c2ff7f25sm1842410wmi.15.2022.10.26.06.28.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 06:28:50 -0700 (PDT) Date: Wed, 26 Oct 2022 16:28:38 +0300 From: UMWARI JOVIAL <umwarijovial@gmail.com> To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: [PATCH] Fixed[ERROR:trailing whitespace and braces around scalar initializer] Message-ID: <20221026132838.GA44037@rdm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747757755856640590?= X-GMAIL-MSGID: =?utf-8?q?1747757755856640590?= |
Series |
Fixed[ERROR:trailing whitespace and braces around scalar initializer]
|
|
Commit Message
UMWARI JOVIAL
Oct. 26, 2022, 1:28 p.m. UTC
Using the checkpatch.pl script, found the below errors and fixed
ERROR: trailing whitespace
CHECK: Please don't use multiple blank lines
warning: braces around scalar initializer
Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
---
drivers/staging/most/dim2/dim2.c | 2 --
1 file changed, 2 deletions(-)
Comments
On Wed, Oct 26, 2022 at 04:28:38PM +0300, UMWARI JOVIAL wrote: > Using the checkpatch.pl script, found the below errors and fixed > ERROR: trailing whitespace > CHECK: Please don't use multiple blank lines > warning: braces around scalar initializer > > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com> > --- > drivers/staging/most/dim2/dim2.c | 2 -- > 1 file changed, 2 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
On Wed, Oct 26, 2022 at 04:28:38PM +0300, UMWARI JOVIAL wrote: > Using the checkpatch.pl script, found the below errors and fixed > ERROR: trailing whitespace > CHECK: Please don't use multiple blank lines > warning: braces around scalar initializer > > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com> > --- > drivers/staging/most/dim2/dim2.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > index 7a5f80e637a0..28259ce05024 100644 > --- a/drivers/staging/most/dim2/dim2.c > +++ b/drivers/staging/most/dim2/dim2.c > @@ -987,7 +987,6 @@ static int rcar_gen2_enable(struct platform_device *pdev) > writel(0x04, dev->io_base + 0x600); > } > > - > /* BBCR = 0b11 */ > writel(0x03, dev->io_base + 0x500); > writel(0x0002FF02, dev->io_base + 0x508); > @@ -1084,7 +1083,6 @@ static const struct of_device_id dim2_of_match[] = { > { > .compatible = "xlnx,axi4-os62420_6pin-1.00.a", > }, > - {}, I'm no expert, but this looks like a null terminator and probably should not be removed. Best regards, Nam
On Wed, Oct 26, 2022 at 07:14:34PM +0200, Nam Cao wrote: > On Wed, Oct 26, 2022 at 04:28:38PM +0300, UMWARI JOVIAL wrote: > > Using the checkpatch.pl script, found the below errors and fixed > > ERROR: trailing whitespace > > CHECK: Please don't use multiple blank lines > > warning: braces around scalar initializer > > > > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com> > > --- > > drivers/staging/most/dim2/dim2.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > > index 7a5f80e637a0..28259ce05024 100644 > > --- a/drivers/staging/most/dim2/dim2.c > > +++ b/drivers/staging/most/dim2/dim2.c > > @@ -987,7 +987,6 @@ static int rcar_gen2_enable(struct platform_device *pdev) > > writel(0x04, dev->io_base + 0x600); > > } > > > > - > > /* BBCR = 0b11 */ > > writel(0x03, dev->io_base + 0x500); > > writel(0x0002FF02, dev->io_base + 0x508); > > @@ -1084,7 +1083,6 @@ static const struct of_device_id dim2_of_match[] = { > > { > > .compatible = "xlnx,axi4-os62420_6pin-1.00.a", > > }, > > - {}, > > I'm no expert, but this looks like a null terminator and probably > should not be removed. You're absolutely correct. Also I tried to see why checkpatch.pl was printing an error for this but it doesn't print an error for me. regards, dan carpenter
Hi UMWARI,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on linus/master v6.1-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/UMWARI-JOVIAL/Fixed-ERROR-trailing-whitespace-and-braces-around-scalar-initializer/20221026-212952
patch link: https://lore.kernel.org/r/20221026132838.GA44037%40rdm
patch subject: [PATCH] Fixed[ERROR:trailing whitespace and braces around scalar initializer]
config: hexagon-randconfig-r016-20221026
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/51dcd5e3ce065f3e92959e5f71505108d73997b5
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review UMWARI-JOVIAL/Fixed-ERROR-trailing-whitespace-and-braces-around-scalar-initializer/20221026-212952
git checkout 51dcd5e3ce065f3e92959e5f71505108d73997b5
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/staging/most/dim2/most_dim2: struct of_device_id is 196 bytes. The last of 5 is:
0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x78 0x6c 0x6e 0x78 0x2c 0x61 0x78 0x69 0x34 0x2d 0x6f 0x73 0x36 0x32 0x34 0x32 0x30 0x5f 0x36 0x70 0x69 0x6e 0x2d 0x31 0x2e 0x30 0x30 0x2e 0x61 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
>> FATAL: modpost: drivers/staging/most/dim2/most_dim2: struct of_device_id is not terminated with a NULL entry!
well for the start it was not giving an error but after fixing blank lines that is when i saw that Thank you for the hint i fixed it On Thu, 27 Oct 2022 at 10:56, Dan Carpenter <dan.carpenter@oracle.com> wrote: > > On Wed, Oct 26, 2022 at 07:14:34PM +0200, Nam Cao wrote: > > On Wed, Oct 26, 2022 at 04:28:38PM +0300, UMWARI JOVIAL wrote: > > > Using the checkpatch.pl script, found the below errors and fixed > > > ERROR: trailing whitespace > > > CHECK: Please don't use multiple blank lines > > > warning: braces around scalar initializer > > > > > > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com> > > > --- > > > drivers/staging/most/dim2/dim2.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > > > index 7a5f80e637a0..28259ce05024 100644 > > > --- a/drivers/staging/most/dim2/dim2.c > > > +++ b/drivers/staging/most/dim2/dim2.c > > > @@ -987,7 +987,6 @@ static int rcar_gen2_enable(struct platform_device *pdev) > > > writel(0x04, dev->io_base + 0x600); > > > } > > > > > > - > > > /* BBCR = 0b11 */ > > > writel(0x03, dev->io_base + 0x500); > > > writel(0x0002FF02, dev->io_base + 0x508); > > > @@ -1084,7 +1083,6 @@ static const struct of_device_id dim2_of_match[] = { > > > { > > > .compatible = "xlnx,axi4-os62420_6pin-1.00.a", > > > }, > > > - {}, > > > > I'm no expert, but this looks like a null terminator and probably > > should not be removed. > > You're absolutely correct. Also I tried to see why checkpatch.pl was > printing an error for this but it doesn't print an error for me. > > regards, > dan carpenter >
diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index 7a5f80e637a0..28259ce05024 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -987,7 +987,6 @@ static int rcar_gen2_enable(struct platform_device *pdev) writel(0x04, dev->io_base + 0x600); } - /* BBCR = 0b11 */ writel(0x03, dev->io_base + 0x500); writel(0x0002FF02, dev->io_base + 0x508); @@ -1084,7 +1083,6 @@ static const struct of_device_id dim2_of_match[] = { { .compatible = "xlnx,axi4-os62420_6pin-1.00.a", }, - {}, }; MODULE_DEVICE_TABLE(of, dim2_of_match);