Message ID | e34d8eddc1dda8bb0ff840a7dd18ca4dd6c62d22.1679479634.git.quic_varada@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2275475wrt; Wed, 22 Mar 2023 04:03:01 -0700 (PDT) X-Google-Smtp-Source: AK7set9cIjHxeboy4b2eC9g1+SjbKJxR0DUrr3esnbjG8cx96o+UzHDhpXziFSk/plVhvU8rj1zq X-Received: by 2002:a17:906:face:b0:92f:a61a:f755 with SMTP id lu14-20020a170906face00b0092fa61af755mr5447356ejb.73.1679482981434; Wed, 22 Mar 2023 04:03:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679482981; cv=none; d=google.com; s=arc-20160816; b=rG2i1WpUFguPUGswj2ePKFL/np74nuws4X+E2025plCHBxVqGx1PuDeOjNLItIyc4D /LAfiv6rlXwlqr1rHOPFvwdkR+vaKkwtPmv2/4R/kC6+u2XrdZHR7pdnnvaiLA62UhFX mdYS0bSsZESmcKnl+QbkJSg2CsGb+26hcQM7PNqzBjqBn6m2vgR1HQU1eDvexGH1Zm5u woSdaYXi8s+zFVBa06gatsr1Rtw+aKCLs+cphUdtrBaZWTGQGJ67mxD802BmeQE5GqwB 5X57X/bDAU1gis2qr4sDwRlAF/f5gb1hidNosPuZ4GjVRTaok38ydJUzrsmHFUNxL1FK pbaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=C5i6Lb2az4K0UbrOKbM7fKXf3cghf7uw6Z1c9mBZsBo=; b=C2HaIp4AZmBuw9oK0pMHs89oYxOO/N3ZCWQeY+xvXRv8QrY/hVkFWcnpxlMbbOGrGK LWE/7yFcazwjSbk6yXZrckRV4KMwxLk0HFxpC94QmGoSRd6pgZVxiMfywPrAlc9h/sJv I1ST+cR3KEKJaqc33v/0WttbZU81cXVInPYeQGsH/xMw1wkLdVgBqRMuUMWdzrnDuimE 0irdWxKJQNJif9CRWj1HafQpIxcwKYl/DQo1lwmf+zn/xpTDYN+GpXyOmEmmlDTaNyEv 4cKssfr4J4oq/UpPycoq1dCbmhe9EetyAVROYCOL0+JKRUC+v6et37YkwvdcrQd+pE6Z HmQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=SdtJT01v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i24-20020a1709061cd800b008c1d4ed00d3si15599734ejh.792.2023.03.22.04.02.36; Wed, 22 Mar 2023 04:03:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=SdtJT01v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229671AbjCVKpN (ORCPT <rfc822;pusanteemu@gmail.com> + 99 others); Wed, 22 Mar 2023 06:45:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230298AbjCVKpK (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 22 Mar 2023 06:45:10 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B014E5F524; Wed, 22 Mar 2023 03:45:08 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32MAaBDf019384; Wed, 22 Mar 2023 10:45:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=C5i6Lb2az4K0UbrOKbM7fKXf3cghf7uw6Z1c9mBZsBo=; b=SdtJT01vJXwdGimfLPyj6OHphaFiPmX6s6Cc3Vj8n/ZjEYH51JG5SBnAtQxNWrdfVIyA Ij00rNZr6Fc7yvsZ0mj6M3MdDpzz1dLU9L5J09qdyhC9hGny0GCGVBFFqddybtvKm2wz iJvq8kJ+56YkmQt9uuGlLYYizZaeXkDWzPGomBT8gKu5FLPuNV+FvAX5GkcWXa4X4xfk cTJ/p2inDjDpCS1pAHBNwoLGQGBAT4gtegnbp7YrWfDz/kPzgp8LH9fJkJzKOCXTtSZE sgXlPtoXC/j03fBYYCdzN6jfCzk+FxPV3C/LOJx+s2A+uDPCBFYcQqipKDbhe3vyb8Hw iw== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pfyy7011u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 10:45:01 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32MAj0Ns011376 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 10:45:00 GMT Received: from varda-linux.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 22 Mar 2023 03:44:55 -0700 From: Varadarajan Narayanan <quic_varada@quicinc.com> To: <agross@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <vkoul@kernel.org>, <kishon@kernel.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <gregkh@linuxfoundation.org>, <mturquette@baylibre.com>, <sboyd@kernel.org>, <quic_wcheng@quicinc.com>, <linux-arm-msm@vger.kernel.org>, <linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>, <linux-clk@vger.kernel.org> CC: Varadarajan Narayanan <quic_varada@quicinc.com> Subject: [PATCH v3 2/8] dt-bindings: phy: qcom,qmp-usb: Add IPQ9574 USB3 PHY Date: Wed, 22 Mar 2023 16:14:06 +0530 Message-ID: <e34d8eddc1dda8bb0ff840a7dd18ca4dd6c62d22.1679479634.git.quic_varada@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <cover.1679479634.git.quic_varada@quicinc.com> References: <cover.1679479634.git.quic_varada@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: TsoSydLkFqLDJD9g2WXmYkgS0vhItg_F X-Proofpoint-ORIG-GUID: TsoSydLkFqLDJD9g2WXmYkgS0vhItg_F X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-22_08,2023-03-22_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 phishscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303220077 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761065547112106236?= X-GMAIL-MSGID: =?utf-8?q?1761065547112106236?= |
Series |
Enable IPQ9754 USB
|
|
Commit Message
Varadarajan Narayanan
March 22, 2023, 10:44 a.m. UTC
Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574
Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
---
Changes in v2:
- Updated sections missed in previous patch
---
.../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
Comments
On 22/03/2023 11:44, Varadarajan Narayanan wrote: > Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > Changes in v2: > - Updated sections missed in previous patch > --- > .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > index e81a382..beae44c 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > @@ -21,6 +21,7 @@ properties: > enum: > - qcom,ipq6018-qmp-usb3-phy > - qcom,ipq8074-qmp-usb3-phy > + - qcom,ipq9574-qmp-usb3-phy > - qcom,msm8996-qmp-usb3-phy > - qcom,msm8998-qmp-usb3-phy > - qcom,qcm2290-qmp-usb3-phy > @@ -204,6 +205,27 @@ allOf: > compatible: > contains: > enum: > + - qcom,ipq9574-qmp-usb3-phy > + then: > + properties: > + clocks: > + maxItems: 2 toplevel defines minItems as 3, so are you sure this works? Did you test it? Best regards, Krzysztof
On Wed, Mar 22, 2023 at 10:52:44PM +0100, Krzysztof Kozlowski wrote: > On 22/03/2023 11:44, Varadarajan Narayanan wrote: > > Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > > --- > > Changes in v2: > > - Updated sections missed in previous patch > > --- > > .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > index e81a382..beae44c 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > > @@ -21,6 +21,7 @@ properties: > > enum: > > - qcom,ipq6018-qmp-usb3-phy > > - qcom,ipq8074-qmp-usb3-phy > > + - qcom,ipq9574-qmp-usb3-phy > > - qcom,msm8996-qmp-usb3-phy > > - qcom,msm8998-qmp-usb3-phy > > - qcom,qcm2290-qmp-usb3-phy > > @@ -204,6 +205,27 @@ allOf: > > compatible: > > contains: > > enum: > > + - qcom,ipq9574-qmp-usb3-phy > > + then: > > + properties: > > + clocks: > > + maxItems: 2 > > toplevel defines minItems as 3, so are you sure this works? Did you test it? Yes, this is tested. Able to do I/O. We only have 2 items. Is it ok change the minItems to 2? Thanks Varada > > Best regards, > Krzysztof >
On 23/03/2023 07:37, Varadarajan Narayanan wrote: > On Wed, Mar 22, 2023 at 10:52:44PM +0100, Krzysztof Kozlowski wrote: >> On 22/03/2023 11:44, Varadarajan Narayanan wrote: >>> Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 >>> >>> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> >>> >>> --- >>> Changes in v2: >>> - Updated sections missed in previous patch >>> --- >>> .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 22 ++++++++++++++++++++++ >>> 1 file changed, 22 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml >>> index e81a382..beae44c 100644 >>> --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml >>> +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml >>> @@ -21,6 +21,7 @@ properties: >>> enum: >>> - qcom,ipq6018-qmp-usb3-phy >>> - qcom,ipq8074-qmp-usb3-phy >>> + - qcom,ipq9574-qmp-usb3-phy >>> - qcom,msm8996-qmp-usb3-phy >>> - qcom,msm8998-qmp-usb3-phy >>> - qcom,qcm2290-qmp-usb3-phy >>> @@ -204,6 +205,27 @@ allOf: >>> compatible: >>> contains: >>> enum: >>> + - qcom,ipq9574-qmp-usb3-phy >>> + then: >>> + properties: >>> + clocks: >>> + maxItems: 2 >> >> toplevel defines minItems as 3, so are you sure this works? Did you test it? > > Yes, this is tested. Able to do I/O. Bindings do not impact on whether you can or can not do IO, so I meant tested as DTS is compliant with bindings. I assume it was not, so please test bindings and DTS before sending new version. see Documentation/devicetree/bindings/writing-schema.rst for instructions > We only have 2 items. Is it ok change the minItems to 2? Yes, because you must update top level (and maybe other) constraints to correct ones. Just test the code... Best regards, Krzysztof
On Thu, Mar 23, 2023 at 07:42:37AM +0100, Krzysztof Kozlowski wrote: > On 23/03/2023 07:37, Varadarajan Narayanan wrote: > > On Wed, Mar 22, 2023 at 10:52:44PM +0100, Krzysztof Kozlowski wrote: > >> On 22/03/2023 11:44, Varadarajan Narayanan wrote: > >>> Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574 > >>> > >>> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > >>> > >>> --- > >>> Changes in v2: > >>> - Updated sections missed in previous patch > >>> --- > >>> .../bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 22 ++++++++++++++++++++++ > >>> 1 file changed, 22 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > >>> index e81a382..beae44c 100644 > >>> --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > >>> +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml > >>> @@ -21,6 +21,7 @@ properties: > >>> enum: > >>> - qcom,ipq6018-qmp-usb3-phy > >>> - qcom,ipq8074-qmp-usb3-phy > >>> + - qcom,ipq9574-qmp-usb3-phy > >>> - qcom,msm8996-qmp-usb3-phy > >>> - qcom,msm8998-qmp-usb3-phy > >>> - qcom,qcm2290-qmp-usb3-phy > >>> @@ -204,6 +205,27 @@ allOf: > >>> compatible: > >>> contains: > >>> enum: > >>> + - qcom,ipq9574-qmp-usb3-phy > >>> + then: > >>> + properties: > >>> + clocks: > >>> + maxItems: 2 > >> > >> toplevel defines minItems as 3, so are you sure this works? Did you test it? > > > > Yes, this is tested. Able to do I/O. > > Bindings do not impact on whether you can or can not do IO, so I meant > tested as DTS is compliant with bindings. I assume it was not, so please > test bindings and DTS before sending new version. > see Documentation/devicetree/bindings/writing-schema.rst for instructions Sorry. Misunderstood the question. Yes, I ran make dtbs_check and got these messages. But couldn't relate them with the minItems/maxItems mismatch... phy@7d000: clocks: [[8, 93], [8, 102]] is too short phy@7d000: clock-names: ['aux', 'cfg_ahb'] is too short Will fix it now. Thanks for the clarification. > > We only have 2 items. Is it ok change the minItems to 2? > > Yes, because you must update top level (and maybe other) constraints to > correct ones. Just test the code... Ok. Thanks Varada > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml index e81a382..beae44c 100644 --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml @@ -21,6 +21,7 @@ properties: enum: - qcom,ipq6018-qmp-usb3-phy - qcom,ipq8074-qmp-usb3-phy + - qcom,ipq9574-qmp-usb3-phy - qcom,msm8996-qmp-usb3-phy - qcom,msm8998-qmp-usb3-phy - qcom,qcm2290-qmp-usb3-phy @@ -204,6 +205,27 @@ allOf: compatible: contains: enum: + - qcom,ipq9574-qmp-usb3-phy + then: + properties: + clocks: + maxItems: 2 + clock-names: + items: + - const: aux + - const: cfg_ahb + resets: + maxItems: 2 + reset-names: + items: + - const: phy + - const: common + + - if: + properties: + compatible: + contains: + enum: - qcom,sm8150-qmp-usb3-phy - qcom,sm8150-qmp-usb3-uni-phy - qcom,sm8250-qmp-usb3-uni-phy