[6/6] ASoC: dt-bindings: wcd938x: fix codec reset line polarity in example

Message ID 20221027074652.1044235-6-dmitry.torokhov@gmail.com
State New
Headers
Series [1/6] arm64: dts: qcom: msm8996: fix sound card reset line polarity |

Commit Message

Dmitry Torokhov Oct. 27, 2022, 7:46 a.m. UTC
  The driver for the codec, when resetting the chip, first drives the line
low, and then high. This means that the line is active low. Change the
annotation in the example DTS accordingly.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Krzysztof Kozlowski Oct. 27, 2022, 1:44 p.m. UTC | #1
On 27/10/2022 03:46, Dmitry Torokhov wrote:
> The driver for the codec, when resetting the chip, first drives the line
> low, and then high. This means that the line is active low. Change the
> annotation in the example DTS accordingly.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
  
Rob Herring Oct. 28, 2022, 7:39 p.m. UTC | #2
On Thu, Oct 27, 2022 at 12:46:52AM -0700, Dmitry Torokhov wrote:
> The driver for the codec, when resetting the chip, first drives the line
> low, and then high. This means that the line is active low. Change the
> annotation in the example DTS accordingly.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> index 51547190f709..2f5e0df93872 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> @@ -112,7 +112,7 @@ examples:
>    - |
>      codec {
>          compatible = "qcom,wcd9380-codec";
> -        reset-gpios = <&tlmm 32 0>;
> +        reset-gpios = <&tlmm 32 GPIO_ACTIVE_LOW>;

Missing a header for this.

>          #sound-dai-cells = <1>;
>          qcom,tx-device = <&wcd938x_tx>;
>          qcom,rx-device = <&wcd938x_rx>;
> -- 
> 2.38.0.135.g90850a2211-goog
> 
>
  

Patch

diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
index 51547190f709..2f5e0df93872 100644
--- a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
@@ -112,7 +112,7 @@  examples:
   - |
     codec {
         compatible = "qcom,wcd9380-codec";
-        reset-gpios = <&tlmm 32 0>;
+        reset-gpios = <&tlmm 32 GPIO_ACTIVE_LOW>;
         #sound-dai-cells = <1>;
         qcom,tx-device = <&wcd938x_tx>;
         qcom,rx-device = <&wcd938x_rx>;