Message ID | 20230315061810.653263-4-yukuai1@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2164037wrd; Tue, 14 Mar 2023 23:21:53 -0700 (PDT) X-Google-Smtp-Source: AK7set9+9c7hPZ6+qHAs7AfsTA0hAF/R1ZDdret/YHQdhymTPW6dFL+I8rgKLsLZ6Q4JB9gyW8iy X-Received: by 2002:a17:90b:4d07:b0:237:ae98:a47f with SMTP id mw7-20020a17090b4d0700b00237ae98a47fmr16400089pjb.1.1678861313573; Tue, 14 Mar 2023 23:21:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678861313; cv=none; d=google.com; s=arc-20160816; b=lBDmgW+ECzXb0k36vZxNb6WUHqZ+S2GRUvGNuX53/7WWqDphZlVHG0e8lhaZhfB5xv ckeuRG3ClaGYpphm+qhPLc35pFLYvYePTCev+B6C3U5J+1ABd9h01vpZTqszVB/jWNfY QIq3oPYG1EFPye3KdD4qowje0n2SnK44ELq8vfMfiF05/pKYB3sYtpPgU2B86Rjz8tHv 6o5zyf2+4HqXqzPQ4YrAHI539TZ0tY9xhfAQUcGaimouegwhCZIMdSRjQIuKvKWhXRPP OCgcrMFXQPTIpZXVJafnsuTSUCs2Jk8NYichZqHpFcxpQLp2nxeUX4CDu5K/eXDnV2PI K/tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=DKX7+fw/bVlv5vDS2XyxXTqd72I0w0iD9oD9dR/CS8E=; b=yWcHw9thgZ3tMy8BLp48JWeh4kjcGshMPpZBPL8oswKSXa7wFvargKiZCzLGxMlsYA rdfo6DAPAWhQzkhVH37WtjQuZVDe1l+p9/y5z25DvXPLFhrXoDIpvOx++Kpk8d36Q4qR 46eGm0yEtwqJJYyny0aofF5k8KDwBGyTZQOmwmpxn5ZeU2g7s3vUY7HZM2THYaOs7+7I plIl+3lmzShZtRHJsfEY0E8eoeNLe9yEj3XrcA0Kt5NjNW1vwkekqQtjol8XMBw0G+dJ WR23EqlEEei0wH0s8K+wVn5pTBTRnhrattOG+dnXw3xGt+AyntmXBz4bRoKQNGb/NIMo nU7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z13-20020a170903018d00b0019a9b869bfasi5051054plg.75.2023.03.14.23.21.38; Tue, 14 Mar 2023 23:21:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231195AbjCOGTJ (ORCPT <rfc822;realc9580@gmail.com> + 99 others); Wed, 15 Mar 2023 02:19:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230447AbjCOGTB (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 15 Mar 2023 02:19:01 -0400 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AD2026C26; Tue, 14 Mar 2023 23:18:59 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.169]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Pc0b30hg3z4f4cFl; Wed, 15 Mar 2023 14:18:55 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.127.227]) by APP3 (Coremail) with SMTP id _Ch0CgCnUyFNYxFklvvMEw--.20241S7; Wed, 15 Mar 2023 14:18:56 +0800 (CST) From: Yu Kuai <yukuai1@huaweicloud.com> To: agk@redhat.com, snitzer@kernel.org, song@kernel.org Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: [PATCH v2 3/5] md: use md_thread api to wake up sync_thread Date: Wed, 15 Mar 2023 14:18:08 +0800 Message-Id: <20230315061810.653263-4-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230315061810.653263-1-yukuai1@huaweicloud.com> References: <20230315061810.653263-1-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: _Ch0CgCnUyFNYxFklvvMEw--.20241S7 X-Coremail-Antispam: 1UD129KBjvJXoW7Ar47Jw4rGw13JFWkXw4rAFb_yoW8WFy7pa yxAF95ur10yry3ZFZxJa4qva4rXF10q342vry7ua1rJw15tw45tFy3ury8AryvvayfAw45 Zw1rtFWxuFs29r7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9m14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JrWl82xGYIkIc2 x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0 Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJw A2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS 0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2 IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0 Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCF04k20xvY0x0EwIxGrwCFx2 IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v2 6r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67 AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IY s7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr 0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUd8n5UUUUU= X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, MAY_BE_FORGED,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760413681131283288?= X-GMAIL-MSGID: =?utf-8?q?1760413681131283288?= |
Series |
md: fix uaf for sync_thread
|
|
Commit Message
Yu Kuai
March 15, 2023, 6:18 a.m. UTC
From: Yu Kuai <yukuai3@huawei.com> Instead of wake_up_process() directly, convert to use md_wakeup_thread(). Signed-off-by: Yu Kuai <yukuai3@huawei.com> --- drivers/md/md.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-)
Comments
Greeting, FYI, we noticed INFO:task_blocked_for_more_than#seconds due to commit (built with gcc-11): commit: af2203c7e88c00d3ce072f18c18a36e2936372fd ("[PATCH v2 3/5] md: use md_thread api to wake up sync_thread") url: https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/md-pass-a-md_thread-pointer-to-md_register_thread/20230315-142018 base: git://git.kernel.org/cgit/linux/kernel/git/song/md.git md-next patch link: https://lore.kernel.org/all/20230315061810.653263-4-yukuai1@huaweicloud.com/ patch subject: [PATCH v2 3/5] md: use md_thread api to wake up sync_thread in testcase: mdadm-selftests version: mdadm-selftests-x86_64-5f41845-1_20220826 with following parameters: disk: 1HDD test_prefix: 07revert on test machine: 8 threads 1 sockets Intel(R) Core(TM) i7-4790T CPU @ 2.70GHz (Haswell) with 16G memory caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): If you fix the issue, kindly add following tag | Reported-by: kernel test robot <oliver.sang@intel.com> | Link: https://lore.kernel.org/oe-lkp/202303170904.640a8ece-oliver.sang@intel.com kern :err : [ 990.133727] INFO: task mdadm:1040 blocked for more than 491 seconds. kern :err : [ 990.140824] Tainted: G S 6.3.0-rc1-00019-gaf2203c7e88c #1 kern :err : [ 990.148856] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. kern :info : [ 990.157410] task:mdadm state:D stack:0 pid:1040 ppid:963 flags:0x00000000 kern :info : [ 990.166483] Call Trace: kern :info : [ 990.169666] <TASK> kern :info : [ 990.172504] __schedule (kernel/sched/core.c:5304 kernel/sched/core.c:6622) kern :info : [ 990.176810] ? io_schedule_timeout (kernel/sched/core.c:6504) kern :info : [ 990.181994] ? _raw_spin_lock_irqsave (arch/x86/include/asm/atomic.h:202 include/linux/atomic/atomic-instrumented.h:543 include/asm-generic/qspinlock.h:111 include/linux/spinlock.h:186 include/linux/spinlock_api_smp.h:111 kernel/locking/spinlock.c:162) kern :info : [ 990.187250] ? _raw_write_lock_irq (kernel/locking/spinlock.c:153) kern :info : [ 990.192255] schedule (arch/x86/include/asm/preempt.h:85 (discriminator 1) kernel/sched/core.c:6699 (discriminator 1)) kern :info : [ 990.196291] do_md_stop (drivers/md/md.c:6364 (discriminator 29)) kern :info : [ 990.200603] ? md_kick_rdev_from_array (drivers/md/md.c:6344) kern :info : [ 990.206111] ? add_ptr_to_bulk_krc_lock (arch/x86/include/asm/atomic.h:95 include/linux/atomic/atomic-instrumented.h:191 kernel/rcu/tree.c:3273) kern :info : [ 990.211711] ? cpuacct_stats_show (kernel/sched/wait.c:418) kern :info : [ 990.216787] ? schedule_delayed_monitor_work (arch/x86/include/asm/bitops.h:207 arch/x86/include/asm/bitops.h:239 include/asm-generic/bitops/instrumented-non-atomic.h:142 kernel/rcu/tree.c:3044) kern :info : [ 990.222736] ? __cond_resched (kernel/sched/core.c:8486) kern :info : [ 990.227292] ? mutex_lock_interruptible (arch/x86/include/asm/atomic64_64.h:190 include/linux/atomic/atomic-long.h:443 include/linux/atomic/atomic-instrumented.h:1781 kernel/locking/mutex.c:171 kernel/locking/mutex.c:981) kern :info : [ 990.232725] ? __mutex_lock_interruptible_slowpath (kernel/locking/mutex.c:978) kern :info : [ 990.239095] ? __mutex_unlock_slowpath+0x2a0/0x2a0 kern :info : [ 990.245668] md_ioctl (drivers/md/md.c:7642) kern :info : [ 990.249809] ? hot_add_disk (drivers/md/md.c:7513) kern :info : [ 990.254360] ? __call_rcu_common+0x363/0x900 kern :info : [ 990.260389] ? blkdev_bszset (block/ioctl.c:473) kern :info : [ 990.265047] ? rcu_nocb_gp_kthread (kernel/rcu/tree.c:2596) kern :info : [ 990.270224] ? __fput (include/linux/fs.h:2554 fs/internal.h:110 fs/file_table.c:328) kern :info : [ 990.274269] ? __cond_resched (kernel/sched/core.c:8486) kern :info : [ 990.278826] blkdev_ioctl (block/ioctl.c:615) kern :info : [ 990.283223] ? blkdev_common_ioctl (block/ioctl.c:560) kern :info : [ 990.288568] ? _raw_spin_lock (arch/x86/include/asm/atomic.h:202 include/linux/atomic/atomic-instrumented.h:543 include/asm-generic/qspinlock.h:111 include/linux/spinlock.h:186 include/linux/spinlock_api_smp.h:134 kernel/locking/spinlock.c:154) kern :info : [ 990.293139] ? _raw_write_lock_irq (kernel/locking/spinlock.c:153) kern :info : [ 990.298137] __x64_sys_ioctl (fs/ioctl.c:52 fs/ioctl.c:870 fs/ioctl.c:856 fs/ioctl.c:856) kern :info : [ 990.302800] do_syscall_64 (arch/x86/entry/common.c:50 arch/x86/entry/common.c:80) kern :info : [ 990.307108] entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:120) kern :info : [ 990.312889] RIP: 0033:0x7f00b07c8cc7 kern :info : [ 990.317187] RSP: 002b:00007ffc27cbbc88 EFLAGS: 00000206 ORIG_RAX: 0000000000000010 kern :info : [ 990.325483] RAX: ffffffffffffffda RBX: 0000000000000019 RCX: 00007f00b07c8cc7 kern :info : [ 990.333342] RDX: 0000000000000000 RSI: 0000000000000932 RDI: 0000000000000004 kern :info : [ 990.341195] RBP: 0000000000000004 R08: 0000000000000002 R09: 0000000000000000 kern :info : [ 990.349044] R10: fffffffffffff28e R11: 0000000000000206 R12: 00007ffc27cbe994 kern :info : [ 990.356888] R13: 0000000000000005 R14: 00007ffc27cbbd30 R15: 0000557160bdec10 kern :info : [ 990.364750] </TASK> user :err : [ 1006.832241] Terminated user :notice: [ 1006.968217] /lkp/benchmarks/mdadm-selftests/tests/07revert-grow... FAILED - see /var/tmp/07revert-grow.log and /var/tmp/fail07revert-grow.log for details user :notice: [ 1007.123127] 07revert-grow TIMEOUT user :err : [ 1008.444219] mdadm: cannot open /dev/md0: No such device user :notice: [ 1012.202178] test: please run test suite without running RAIDs environment. user :notice: [ 1017.437744] test: please run test suite without running RAIDs environment. user :notice: [ 1017.836121] /usr/bin/wget -q --timeout=1800 --tries=1 --local-encoding=UTF-8 http://internal-lkp-server:80/~lkp/cgi-bin/lkp-jobfile-append-var?job_file=/lkp/jobs/scheduled/lkp-hsw-d05/mdadm-selftests-1HDD-07revert-debian-11.1-x86_64-20220510.cgz-af2203c7e88c00d3ce072f18c18a36e2936372fd-20230317-32283-1997139-5.yaml&job_state=post_run -O /dev/null user :notice: [ 1019.573946] kill 528 vmstat --timestamp -n 10 user :notice: [ 1019.588893] kill 526 dmesg --follow --decode To reproduce: git clone https://github.com/intel/lkp-tests.git cd lkp-tests sudo bin/lkp install job.yaml # job file is attached in this email bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run sudo bin/lkp run generated-yaml-file # if come across any failure that blocks the test, # please remove ~/.lkp and /lkp dir to run from a clean state.
Hi, 在 2023/03/17 10:30, kernel test robot 写道: > > Greeting, > > FYI, we noticed INFO:task_blocked_for_more_than#seconds due to commit (built with gcc-11): > > commit: af2203c7e88c00d3ce072f18c18a36e2936372fd ("[PATCH v2 3/5] md: use md_thread api to wake up sync_thread") > url: https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/md-pass-a-md_thread-pointer-to-md_register_thread/20230315-142018 > base: git://git.kernel.org/cgit/linux/kernel/git/song/md.git md-next > patch link: https://lore.kernel.org/all/20230315061810.653263-4-yukuai1@huaweicloud.com/ > patch subject: [PATCH v2 3/5] md: use md_thread api to wake up sync_thread > I don't expect there is any difference between: if (mddev->sync_thread) wake_up_process(mddev->sync_thread->tsk); and: md_wakeup_thread(mddev->sync_thread); I still don't understand the problem.. I'll try to reporduce this, untill them, I guess I'll just drop this patch. Thanks, Kuai > in testcase: mdadm-selftests > version: mdadm-selftests-x86_64-5f41845-1_20220826 > with following parameters: > > disk: 1HDD > test_prefix: 07revert > > > > on test machine: 8 threads 1 sockets Intel(R) Core(TM) i7-4790T CPU @ 2.70GHz (Haswell) with 16G memory > > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): > > > > If you fix the issue, kindly add following tag > | Reported-by: kernel test robot <oliver.sang@intel.com> > | Link: https://lore.kernel.org/oe-lkp/202303170904.640a8ece-oliver.sang@intel.com > > > kern :err : [ 990.133727] INFO: task mdadm:1040 blocked for more than 491 seconds. > kern :err : [ 990.140824] Tainted: G S 6.3.0-rc1-00019-gaf2203c7e88c #1 > kern :err : [ 990.148856] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > kern :info : [ 990.157410] task:mdadm state:D stack:0 pid:1040 ppid:963 flags:0x00000000 > kern :info : [ 990.166483] Call Trace: > kern :info : [ 990.169666] <TASK> > kern :info : [ 990.172504] __schedule (kernel/sched/core.c:5304 kernel/sched/core.c:6622) > kern :info : [ 990.176810] ? io_schedule_timeout (kernel/sched/core.c:6504) > kern :info : [ 990.181994] ? _raw_spin_lock_irqsave (arch/x86/include/asm/atomic.h:202 include/linux/atomic/atomic-instrumented.h:543 include/asm-generic/qspinlock.h:111 include/linux/spinlock.h:186 include/linux/spinlock_api_smp.h:111 kernel/locking/spinlock.c:162) > kern :info : [ 990.187250] ? _raw_write_lock_irq (kernel/locking/spinlock.c:153) > kern :info : [ 990.192255] schedule (arch/x86/include/asm/preempt.h:85 (discriminator 1) kernel/sched/core.c:6699 (discriminator 1)) > kern :info : [ 990.196291] do_md_stop (drivers/md/md.c:6364 (discriminator 29)) > kern :info : [ 990.200603] ? md_kick_rdev_from_array (drivers/md/md.c:6344) > kern :info : [ 990.206111] ? add_ptr_to_bulk_krc_lock (arch/x86/include/asm/atomic.h:95 include/linux/atomic/atomic-instrumented.h:191 kernel/rcu/tree.c:3273) > kern :info : [ 990.211711] ? cpuacct_stats_show (kernel/sched/wait.c:418) > kern :info : [ 990.216787] ? schedule_delayed_monitor_work (arch/x86/include/asm/bitops.h:207 arch/x86/include/asm/bitops.h:239 include/asm-generic/bitops/instrumented-non-atomic.h:142 kernel/rcu/tree.c:3044) > kern :info : [ 990.222736] ? __cond_resched (kernel/sched/core.c:8486) > kern :info : [ 990.227292] ? mutex_lock_interruptible (arch/x86/include/asm/atomic64_64.h:190 include/linux/atomic/atomic-long.h:443 include/linux/atomic/atomic-instrumented.h:1781 kernel/locking/mutex.c:171 kernel/locking/mutex.c:981) > kern :info : [ 990.232725] ? __mutex_lock_interruptible_slowpath (kernel/locking/mutex.c:978) > kern :info : [ 990.239095] ? __mutex_unlock_slowpath+0x2a0/0x2a0 > kern :info : [ 990.245668] md_ioctl (drivers/md/md.c:7642) > kern :info : [ 990.249809] ? hot_add_disk (drivers/md/md.c:7513) > kern :info : [ 990.254360] ? __call_rcu_common+0x363/0x900 > kern :info : [ 990.260389] ? blkdev_bszset (block/ioctl.c:473) > kern :info : [ 990.265047] ? rcu_nocb_gp_kthread (kernel/rcu/tree.c:2596) > kern :info : [ 990.270224] ? __fput (include/linux/fs.h:2554 fs/internal.h:110 fs/file_table.c:328) > kern :info : [ 990.274269] ? __cond_resched (kernel/sched/core.c:8486) > kern :info : [ 990.278826] blkdev_ioctl (block/ioctl.c:615) > kern :info : [ 990.283223] ? blkdev_common_ioctl (block/ioctl.c:560) > kern :info : [ 990.288568] ? _raw_spin_lock (arch/x86/include/asm/atomic.h:202 include/linux/atomic/atomic-instrumented.h:543 include/asm-generic/qspinlock.h:111 include/linux/spinlock.h:186 include/linux/spinlock_api_smp.h:134 kernel/locking/spinlock.c:154) > kern :info : [ 990.293139] ? _raw_write_lock_irq (kernel/locking/spinlock.c:153) > kern :info : [ 990.298137] __x64_sys_ioctl (fs/ioctl.c:52 fs/ioctl.c:870 fs/ioctl.c:856 fs/ioctl.c:856) > kern :info : [ 990.302800] do_syscall_64 (arch/x86/entry/common.c:50 arch/x86/entry/common.c:80) > kern :info : [ 990.307108] entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:120) > kern :info : [ 990.312889] RIP: 0033:0x7f00b07c8cc7 > kern :info : [ 990.317187] RSP: 002b:00007ffc27cbbc88 EFLAGS: 00000206 ORIG_RAX: 0000000000000010 > kern :info : [ 990.325483] RAX: ffffffffffffffda RBX: 0000000000000019 RCX: 00007f00b07c8cc7 > kern :info : [ 990.333342] RDX: 0000000000000000 RSI: 0000000000000932 RDI: 0000000000000004 > kern :info : [ 990.341195] RBP: 0000000000000004 R08: 0000000000000002 R09: 0000000000000000 > kern :info : [ 990.349044] R10: fffffffffffff28e R11: 0000000000000206 R12: 00007ffc27cbe994 > kern :info : [ 990.356888] R13: 0000000000000005 R14: 00007ffc27cbbd30 R15: 0000557160bdec10 > kern :info : [ 990.364750] </TASK> > user :err : [ 1006.832241] Terminated > > user :notice: [ 1006.968217] /lkp/benchmarks/mdadm-selftests/tests/07revert-grow... FAILED - see /var/tmp/07revert-grow.log and /var/tmp/fail07revert-grow.log for details > > user :notice: [ 1007.123127] 07revert-grow TIMEOUT > > user :err : [ 1008.444219] mdadm: cannot open /dev/md0: No such device > > user :notice: [ 1012.202178] test: please run test suite without running RAIDs environment. > > user :notice: [ 1017.437744] test: please run test suite without running RAIDs environment. > > user :notice: [ 1017.836121] /usr/bin/wget -q --timeout=1800 --tries=1 --local-encoding=UTF-8 http://internal-lkp-server:80/~lkp/cgi-bin/lkp-jobfile-append-var?job_file=/lkp/jobs/scheduled/lkp-hsw-d05/mdadm-selftests-1HDD-07revert-debian-11.1-x86_64-20220510.cgz-af2203c7e88c00d3ce072f18c18a36e2936372fd-20230317-32283-1997139-5.yaml&job_state=post_run -O /dev/null > > user :notice: [ 1019.573946] kill 528 vmstat --timestamp -n 10 > > user :notice: [ 1019.588893] kill 526 dmesg --follow --decode > > > > To reproduce: > > git clone https://github.com/intel/lkp-tests.git > cd lkp-tests > sudo bin/lkp install job.yaml # job file is attached in this email > bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run > sudo bin/lkp run generated-yaml-file > > # if come across any failure that blocks the test, > # please remove ~/.lkp and /lkp dir to run from a clean state. > > >
Hi, 在 2023/03/17 11:30, Yu Kuai 写道: > Hi, > > 在 2023/03/17 10:30, kernel test robot 写道: >> >> Greeting, >> >> FYI, we noticed INFO:task_blocked_for_more_than#seconds due to commit >> (built with gcc-11): >> >> commit: af2203c7e88c00d3ce072f18c18a36e2936372fd ("[PATCH v2 3/5] md: >> use md_thread api to wake up sync_thread") >> url: >> https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/md-pass-a-md_thread-pointer-to-md_register_thread/20230315-142018 >> >> base: git://git.kernel.org/cgit/linux/kernel/git/song/md.git md-next >> patch link: >> https://lore.kernel.org/all/20230315061810.653263-4-yukuai1@huaweicloud.com/ >> >> patch subject: [PATCH v2 3/5] md: use md_thread api to wake up >> sync_thread >> > > I don't expect there is any difference between: > > if (mddev->sync_thread) > wake_up_process(mddev->sync_thread->tsk); > > and: > > md_wakeup_thread(mddev->sync_thread); I understand that they are different now. md_wakeup_thread() only wakeup wait_event() from md_thread(), it will not wake up 'md_thread->tsk' if it's runing. Hence this patch is wrong. Thanks, Kuai
diff --git a/drivers/md/md.c b/drivers/md/md.c index 97e87df4ee43..4ecfd0508afb 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -6267,10 +6267,12 @@ static int md_set_readonly(struct mddev *mddev, struct block_device *bdev) } if (test_bit(MD_RECOVERY_RUNNING, &mddev->recovery)) set_bit(MD_RECOVERY_INTR, &mddev->recovery); - if (mddev->sync_thread) - /* Thread might be blocked waiting for metadata update - * which will now never happen */ - wake_up_process(mddev->sync_thread->tsk); + + /* + * Thread might be blocked waiting for metadata update + * which will now never happen + */ + md_wakeup_thread(&mddev->sync_thread, mddev); if (mddev->external && test_bit(MD_SB_CHANGE_PENDING, &mddev->sb_flags)) return -EBUSY; @@ -6331,10 +6333,12 @@ static int do_md_stop(struct mddev *mddev, int mode, } if (test_bit(MD_RECOVERY_RUNNING, &mddev->recovery)) set_bit(MD_RECOVERY_INTR, &mddev->recovery); - if (mddev->sync_thread) - /* Thread might be blocked waiting for metadata update - * which will now never happen */ - wake_up_process(mddev->sync_thread->tsk); + + /* + * Thread might be blocked waiting for metadata update + * which will now never happen + */ + md_wakeup_thread(&mddev->sync_thread, mddev); mddev_unlock(mddev); wait_event(resync_wait, (mddev->sync_thread == NULL &&