| Message ID | 20221026211458.68432-1-arthurgrillo@riseup.net |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp487586wru;
Wed, 26 Oct 2022 14:17:52 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM5LCrsCgrhVB7/WrZlamaa4ETimXXNc2T0fMd15/v/Z/OuevIaKyduIaOUsyccP2lCDUz/m
X-Received: by 2002:a17:90b:3891:b0:20d:59e3:1f4f with SMTP id
mu17-20020a17090b389100b0020d59e31f4fmr6221493pjb.21.1666819072266;
Wed, 26 Oct 2022 14:17:52 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666819072; cv=none;
d=google.com; s=arc-20160816;
b=fEJpF1URYvS2yFwnKPTE2g3DX+WGGqkq34XyZ2lbCn3EL1HF3YRnzUjPS920o3Cn2l
AyI/wgQD7PUup/1ZnrUfHkYo7lePpTCV6IPlii9F2TjJdyXtuQsGaqMFAxNL65PXa691
yp3DjZWDUTImB8F4JFAXY7A7cIxWAmTywLXUvnCFPAgF7t/DnUDkXsy9G2cY3f17b9Qq
cTiUtX8JbNnHKcCYpbpSny5LLa4TFY3ACLDJHvcNpYwJB/wVw9Qn9fJ5vn+mYKbPmnFn
daAff0fIqOfVNKknlpR0pnu7UYRfdCwjbnm5N4eoPJC5sbH2yGEVmwgdpKQkQw1QGuZL
4ROA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=Db6jCId2W4S/aVsBen3gZgcCTndUFtjdZCV58LsmENo=;
b=LG5YvDBA6mWDXLRnOVmf0jIlhR5MFah+nZx8FBNKL6s0cQiugb5H+V+YgCGg3FMy6w
rvJPTBbgoEec3IqroUdi0rR1RzyFK/IEQxLklIqTUQUFf/PvwWtbo2VrtyktFYlTe8xn
Ehyvz+/YFoLxyxVHS9sRC0qvgQqHWT0Hun2ql3GoLlOLFHSW1IC55sfYZc+mPoa/Knqk
X/bam9LAiKYF0QIelTbxvU010W7irIg4txhXIDmC7BRf14Lyp/yQlBizd7dsHAxxma6W
5BmvVfwaLAwZ69o6dr09dDMf0WCCEYFfFuA0Fvw6no8Lks4iE9ZHQZ/ZSsR9M5RsyoBU
s8WA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@riseup.net header.s=squak header.b=Ra9lX8oC;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=riseup.net
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
c8-20020a634e08000000b00452a7b4f50bsi9814419pgb.48.2022.10.26.14.17.35;
Wed, 26 Oct 2022 14:17:52 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@riseup.net header.s=squak header.b=Ra9lX8oC;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=riseup.net
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S234154AbiJZVPN (ORCPT <rfc822;pwkd43@gmail.com> + 99 others);
Wed, 26 Oct 2022 17:15:13 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46162 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S233698AbiJZVPL (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 26 Oct 2022 17:15:11 -0400
Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D02682859
for <linux-kernel@vger.kernel.org>;
Wed, 26 Oct 2022 14:15:10 -0700 (PDT)
Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits)
server-digest SHA256
client-signature RSA-PSS (2048 bits) client-digest SHA256)
(Client CN "mail.riseup.net", Issuer "R3" (not verified))
by mx1.riseup.net (Postfix) with ESMTPS id 4MyM5p2hhWzDqXT;
Wed, 26 Oct 2022 21:15:10 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak;
t=1666818910; bh=APYOM4y7kgiXVNJBM6mveeMKzmAiEbIw4YkLWM5pJZo=;
h=From:To:Cc:Subject:Date:From;
b=Ra9lX8oCSmzSTdW7tjYozHU8DsdSPwtjywDlyTrJQd3Lm77LyEcmbd78BmJwo1lCD
OEyLozx7JbGxsnWlxng8o1D6aB5HAf/6LuMpr+syZcjdrfrkRtGcACqbT/laEpT8cT
c6qi8l6KbiJL7Jb/ozxtq+pSAF5NJ5k9MALtHdcQ=
X-Riseup-User-ID:
B8985AC8A5ACF8A065AFF6B3A5F7E11411B5160F54633E5E622691687DA7D7C4
Received: from [127.0.0.1] (localhost [127.0.0.1])
by fews1.riseup.net (Postfix) with ESMTPSA id 4MyM5k2VGXz5vS7;
Wed, 26 Oct 2022 21:15:06 +0000 (UTC)
From: Arthur Grillo <arthurgrillo@riseup.net>
To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Javier Martinez Canillas <javierm@redhat.com>,
=?utf-8?q?Ma=C3=ADra_Canal?= <mairacanal@riseup.net>, =?utf-8?q?Toke_H?=
=?utf-8?q?=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>,
"Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
David Gow <davidgow@google.com>, Daniel Latypov <dlatypov@google.com>,
andrealmeid@riseup.net, melissa.srw@gmail.com,
Arthur Grillo <arthurgrillo@riseup.net>,
=?utf-8?q?Micha=C5=82_Winiarski?= <michal.winiarski@intel.com>
Subject: [PATCH] drm/tests: Add back seed value information
Date: Wed, 26 Oct 2022 18:14:58 -0300
Message-Id: <20221026211458.68432-1-arthurgrillo@riseup.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,
URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1747786475674720095?=
X-GMAIL-MSGID: =?utf-8?q?1747786475674720095?=
|
| Series |
drm/tests: Add back seed value information
|
|
Commit Message
Arthur Grillo
Oct. 26, 2022, 9:14 p.m. UTC
As reported by Michał the drm_mm and drm_buddy unit tests lost the
printk with seed value after they being refactored into kunit. This
patch adds back this important information to assure reproducibility
converting them to use the kunit api.
Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>
Reported-by: Michał Winiarski <michal.winiarski@intel.com>
---
drivers/gpu/drm/tests/drm_buddy_test.c | 3 +++
drivers/gpu/drm/tests/drm_mm_test.c | 4 +++-
2 files changed, 6 insertions(+), 1 deletion(-)
Comments
Hi Arthur, On 10/26/22 18:14, Arthur Grillo wrote: > As reported by Michał the drm_mm and drm_buddy unit tests lost the > printk with seed value after they being refactored into kunit. This Some grammar nits: - s/being/were - s/kunit/KUnit > patch adds back this important information to assure reproducibility > converting them to use the kunit api. > > Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> > Reported-by: Michał Winiarski <michal.winiarski@intel.com> I believe that Michał's should come before your tag, as the SoB chain should reflect the real route a patch took as it was propagated to the maintainers [1]. > --- > drivers/gpu/drm/tests/drm_buddy_test.c | 3 +++ > drivers/gpu/drm/tests/drm_mm_test.c | 4 +++- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c > index 62f69589a72d..83c8863bc643 100644 > --- a/drivers/gpu/drm/tests/drm_buddy_test.c > +++ b/drivers/gpu/drm/tests/drm_buddy_test.c > @@ -731,6 +731,9 @@ static int drm_buddy_init_test(struct kunit *test) > while (!random_seed) > random_seed = get_random_u32(); > > + kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n", > + random_seed); I'm getting some compiling errors here: ERROR:root:../drivers/gpu/drm/tests/drm_buddy_test.c:735:3: error: expected ')' random_seed); ^ ../drivers/gpu/drm/tests/drm_buddy_test.c:734:2: note: to match this '(' kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n", ^ You can reproduce it by running: $ ./tools/testing/kunit/kunit.py --kunitconfig=drivers/gpu/drm/tests Moreover, could you address the checkpatch issues? There are some misaligned parenthesis and the line are too big. > + > return 0; > } > > diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c > index c4b66eeae203..492347069d58 100644 > --- a/drivers/gpu/drm/tests/drm_mm_test.c > +++ b/drivers/gpu/drm/tests/drm_mm_test.c > @@ -2214,6 +2214,9 @@ static int drm_mm_init_test(struct kunit *test) > while (!random_seed) > random_seed = get_random_u32(); > > + kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n", > + random_seed, max_iterations, max_prime); > + Same here. > return 0; > } > > @@ -2251,6 +2254,5 @@ static struct kunit_suite drm_mm_test_suite = { > }; > > kunit_test_suite(drm_mm_test_suite); > - There is no need to change this line. Thanks for your patch! [1] https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin Best Regards, - Maíra Canal > MODULE_AUTHOR("Intel Corporation"); > MODULE_LICENSE("GPL");
Hi Grillo :) On 10/26/22 18:14, Arthur Grillo wrote: > As reported by Michał the drm_mm and drm_buddy unit tests lost the > printk with seed value after they being refactored into kunit. This > patch adds back this important information to assure reproducibility > converting them to use the kunit api. > You should write you commit message in imperative form, like "Add back this important [...]" > Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> > Reported-by: Michał Winiarski <michal.winiarski@intel.com> > --- > drivers/gpu/drm/tests/drm_buddy_test.c | 3 +++ > drivers/gpu/drm/tests/drm_mm_test.c | 4 +++- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c > index 62f69589a72d..83c8863bc643 100644 > --- a/drivers/gpu/drm/tests/drm_buddy_test.c > +++ b/drivers/gpu/drm/tests/drm_buddy_test.c > @@ -731,6 +731,9 @@ static int drm_buddy_init_test(struct kunit *test) > while (!random_seed) > random_seed = get_random_u32(); > > + kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n", DRM buddy manager (struct drm_buddy) seems a bit redundant to me. > + random_seed); > + > return 0; > } > > diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c > index c4b66eeae203..492347069d58 100644 > --- a/drivers/gpu/drm/tests/drm_mm_test.c > +++ b/drivers/gpu/drm/tests/drm_mm_test.c > @@ -2214,6 +2214,9 @@ static int drm_mm_init_test(struct kunit *test) > while (!random_seed) > random_seed = get_random_u32(); > > + kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n", > + random_seed, max_iterations, max_prime); > + > return 0; > } > > @@ -2251,6 +2254,5 @@ static struct kunit_suite drm_mm_test_suite = { > }; > > kunit_test_suite(drm_mm_test_suite); > - > MODULE_AUTHOR("Intel Corporation"); > MODULE_LICENSE("GPL");
Hi Arthur,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip linus/master v6.1-rc2 next-20221026]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Arthur-Grillo/drm-tests-Add-back-seed-value-information/20221027-051625
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20221026211458.68432-1-arthurgrillo%40riseup.net
patch subject: [PATCH] drm/tests: Add back seed value information
config: ia64-allmodconfig
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/d4760e93f908692ad7af618d17c07aa709e6e3ca
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Arthur-Grillo/drm-tests-Add-back-seed-value-information/20221027-051625
git checkout d4760e93f908692ad7af618d17c07aa709e6e3ca
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/gpu/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from include/kunit/assert.h:13,
from include/kunit/test.h:12,
from drivers/gpu/drm/tests/drm_buddy_test.c:7:
drivers/gpu/drm/tests/drm_buddy_test.c: In function 'drm_buddy_init_test':
>> drivers/gpu/drm/tests/drm_buddy_test.c:735:17: error: expected ')' before 'random_seed'
735 | random_seed);
| ^~~~~~~~~~~
include/linux/printk.h:381:42: note: in definition of macro '__printk_index_emit'
381 | if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
| ^~~~
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:734:9: note: in expansion of macro 'kunit_info'
734 | kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
| ^~~~~~~~~~
include/linux/printk.h:381:41: note: to match this '('
381 | if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
| ^
include/linux/printk.h:428:17: note: in expansion of macro '__printk_index_emit'
428 | __printk_index_emit(_fmt, NULL, NULL); \
| ^~~~~~~~~~~~~~~~~~~
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:734:9: note: in expansion of macro 'kunit_info'
734 | kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
| ^~~~~~~~~~
>> drivers/gpu/drm/tests/drm_buddy_test.c:735:17: error: expected ')' before 'random_seed'
735 | random_seed);
| ^~~~~~~~~~~
include/linux/printk.h:390:61: note: in definition of macro '__printk_index_emit'
390 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^~~~
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:734:9: note: in expansion of macro 'kunit_info'
734 | kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
| ^~~~~~~~~~
include/linux/printk.h:390:60: note: to match this '('
390 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^
include/linux/printk.h:428:17: note: in expansion of macro '__printk_index_emit'
428 | __printk_index_emit(_fmt, NULL, NULL); \
| ^~~~~~~~~~~~~~~~~~~
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:734:9: note: in expansion of macro 'kunit_info'
734 | kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
| ^~~~~~~~~~
>> drivers/gpu/drm/tests/drm_buddy_test.c:735:17: error: expected ')' before 'random_seed'
735 | random_seed);
| ^~~~~~~~~~~
include/linux/printk.h:390:70: note: in definition of macro '__printk_index_emit'
390 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^~~~
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:734:9: note: in expansion of macro 'kunit_info'
734 | kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
| ^~~~~~~~~~
include/linux/printk.h:390:69: note: to match this '('
390 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^
include/linux/printk.h:428:17: note: in expansion of macro '__printk_index_emit'
428 | __printk_index_emit(_fmt, NULL, NULL); \
| ^~~~~~~~~~~~~~~~~~~
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:734:9: note: in expansion of macro 'kunit_info'
734 | kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
| ^~~~~~~~~~
>> drivers/gpu/drm/tests/drm_buddy_test.c:735:17: error: expected ')' before 'random_seed'
735 | random_seed);
| ^~~~~~~~~~~
include/linux/printk.h:429:25: note: in definition of macro 'printk_index_wrap'
429 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:734:9: note: in expansion of macro 'kunit_info'
734 | kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
| ^~~~~~~~~~
include/linux/printk.h:429:24: note: to match this '('
429 | _p_func(_fmt, ##__VA_ARGS__); \
| ^
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:734:9: note: in expansion of macro 'kunit_info'
734 | kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
| ^~~~~~~~~~
>> include/linux/kern_levels.h:5:25: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/printk.h:429:25: note: in definition of macro 'printk_index_wrap'
429 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
include/linux/kern_levels.h:14:25: note: in expansion of macro 'KERN_SOH'
14 | #define KERN_INFO KERN_SOH "6" /* informational */
| ^~~~~~~~
include/kunit/test.h:438:22: note: in expansion of macro 'KERN_INFO'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:734:9: note: in expansion of macro 'kunit_info'
734 | kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
| ^~~~~~~~~~
>> include/kunit/test.h:420:49: error: request for member 'log' in something not a structure or union
420 | kunit_log_append((test_or_suite)->log, fmt "\n", \
| ^~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:734:9: note: in expansion of macro 'kunit_info'
734 | kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
| ^~~~~~~~~~
>> drivers/gpu/drm/tests/drm_buddy_test.c:735:17: error: expected ')' before 'random_seed'
735 | random_seed);
| ^~~~~~~~~~~
include/kunit/test.h:420:57: note: in definition of macro 'kunit_log'
420 | kunit_log_append((test_or_suite)->log, fmt "\n", \
| ^~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:734:9: note: in expansion of macro 'kunit_info'
734 | kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
| ^~~~~~~~~~
include/kunit/test.h:420:33: note: to match this '('
420 | kunit_log_append((test_or_suite)->log, fmt "\n", \
| ^
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_buddy_test.c:734:9: note: in expansion of macro 'kunit_info'
734 | kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
| ^~~~~~~~~~
--
In file included from include/kunit/assert.h:13,
from include/kunit/test.h:12,
from drivers/gpu/drm/tests/drm_mm_test.c:8:
drivers/gpu/drm/tests/drm_mm_test.c: In function 'drm_mm_init_test':
>> drivers/gpu/drm/tests/drm_mm_test.c:2218:9: error: expected ')' before 'random_seed'
2218 | random_seed, max_iterations, max_prime);
| ^~~~~~~~~~~
include/linux/printk.h:381:42: note: in definition of macro '__printk_index_emit'
381 | if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
| ^~~~
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:2217:9: note: in expansion of macro 'kunit_info'
2217 | kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
| ^~~~~~~~~~
include/linux/printk.h:381:41: note: to match this '('
381 | if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
| ^
include/linux/printk.h:428:17: note: in expansion of macro '__printk_index_emit'
428 | __printk_index_emit(_fmt, NULL, NULL); \
| ^~~~~~~~~~~~~~~~~~~
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:2217:9: note: in expansion of macro 'kunit_info'
2217 | kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
| ^~~~~~~~~~
>> drivers/gpu/drm/tests/drm_mm_test.c:2218:9: error: expected ')' before 'random_seed'
2218 | random_seed, max_iterations, max_prime);
| ^~~~~~~~~~~
include/linux/printk.h:390:61: note: in definition of macro '__printk_index_emit'
390 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^~~~
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:2217:9: note: in expansion of macro 'kunit_info'
2217 | kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
| ^~~~~~~~~~
include/linux/printk.h:390:60: note: to match this '('
390 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^
include/linux/printk.h:428:17: note: in expansion of macro '__printk_index_emit'
428 | __printk_index_emit(_fmt, NULL, NULL); \
| ^~~~~~~~~~~~~~~~~~~
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:2217:9: note: in expansion of macro 'kunit_info'
2217 | kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
| ^~~~~~~~~~
>> drivers/gpu/drm/tests/drm_mm_test.c:2218:9: error: expected ')' before 'random_seed'
2218 | random_seed, max_iterations, max_prime);
| ^~~~~~~~~~~
include/linux/printk.h:390:70: note: in definition of macro '__printk_index_emit'
390 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^~~~
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:2217:9: note: in expansion of macro 'kunit_info'
2217 | kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
| ^~~~~~~~~~
include/linux/printk.h:390:69: note: to match this '('
390 | .fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
| ^
include/linux/printk.h:428:17: note: in expansion of macro '__printk_index_emit'
428 | __printk_index_emit(_fmt, NULL, NULL); \
| ^~~~~~~~~~~~~~~~~~~
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:2217:9: note: in expansion of macro 'kunit_info'
2217 | kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
| ^~~~~~~~~~
>> drivers/gpu/drm/tests/drm_mm_test.c:2218:9: error: expected ')' before 'random_seed'
2218 | random_seed, max_iterations, max_prime);
| ^~~~~~~~~~~
include/linux/printk.h:429:25: note: in definition of macro 'printk_index_wrap'
429 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:2217:9: note: in expansion of macro 'kunit_info'
2217 | kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
| ^~~~~~~~~~
include/linux/printk.h:429:24: note: to match this '('
429 | _p_func(_fmt, ##__VA_ARGS__); \
| ^
include/linux/printk.h:457:26: note: in expansion of macro 'printk_index_wrap'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:2217:9: note: in expansion of macro 'kunit_info'
2217 | kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
| ^~~~~~~~~~
>> include/linux/kern_levels.h:5:25: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/printk.h:429:25: note: in definition of macro 'printk_index_wrap'
429 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~
include/kunit/test.h:419:17: note: in expansion of macro 'printk'
419 | printk(lvl fmt, ##__VA_ARGS__); \
| ^~~~~~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
include/linux/kern_levels.h:14:25: note: in expansion of macro 'KERN_SOH'
14 | #define KERN_INFO KERN_SOH "6" /* informational */
| ^~~~~~~~
include/kunit/test.h:438:22: note: in expansion of macro 'KERN_INFO'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:2217:9: note: in expansion of macro 'kunit_info'
2217 | kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
| ^~~~~~~~~~
>> include/kunit/test.h:420:49: error: request for member 'log' in something not a structure or union
420 | kunit_log_append((test_or_suite)->log, fmt "\n", \
| ^~
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:2217:9: note: in expansion of macro 'kunit_info'
2217 | kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
| ^~~~~~~~~~
>> drivers/gpu/drm/tests/drm_mm_test.c:2218:9: error: expected ')' before 'random_seed'
2218 | random_seed, max_iterations, max_prime);
| ^~~~~~~~~~~
include/kunit/test.h:420:57: note: in definition of macro 'kunit_log'
420 | kunit_log_append((test_or_suite)->log, fmt "\n", \
| ^~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:2217:9: note: in expansion of macro 'kunit_info'
2217 | kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
| ^~~~~~~~~~
include/kunit/test.h:420:33: note: to match this '('
420 | kunit_log_append((test_or_suite)->log, fmt "\n", \
| ^
include/kunit/test.h:425:9: note: in expansion of macro 'kunit_log'
425 | kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
| ^~~~~~~~~
include/kunit/test.h:438:9: note: in expansion of macro 'kunit_printk'
438 | kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~
drivers/gpu/drm/tests/drm_mm_test.c:2217:9: note: in expansion of macro 'kunit_info'
2217 | kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
| ^~~~~~~~~~
vim +735 drivers/gpu/drm/tests/drm_buddy_test.c
728
729 static int drm_buddy_init_test(struct kunit *test)
730 {
731 while (!random_seed)
732 random_seed = get_random_u32();
733
734 kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
> 735 random_seed);
736
737 return 0;
738 }
739
Hi Arthur,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip linus/master v6.1-rc2 next-20221027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Arthur-Grillo/drm-tests-Add-back-seed-value-information/20221027-051625
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20221026211458.68432-1-arthurgrillo%40riseup.net
patch subject: [PATCH] drm/tests: Add back seed value information
config: arm64-randconfig-r002-20221026
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/d4760e93f908692ad7af618d17c07aa709e6e3ca
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Arthur-Grillo/drm-tests-Add-back-seed-value-information/20221027-051625
git checkout d4760e93f908692ad7af618d17c07aa709e6e3ca
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/gpu/drm/tests/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/tests/drm_buddy_test.c:735:3: error: expected ')'
random_seed);
^
drivers/gpu/drm/tests/drm_buddy_test.c:734:2: note: to match this '('
kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
^
include/kunit/test.h:438:2: note: expanded from macro 'kunit_info'
kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
^
include/kunit/test.h:425:2: note: expanded from macro 'kunit_printk'
kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
^
include/kunit/test.h:419:3: note: expanded from macro 'kunit_log'
printk(lvl fmt, ##__VA_ARGS__); \
^
include/linux/printk.h:457:26: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
^
include/linux/printk.h:428:3: note: expanded from macro 'printk_index_wrap'
__printk_index_emit(_fmt, NULL, NULL); \
^
include/linux/printk.h:381:27: note: expanded from macro '__printk_index_emit'
if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
^
>> drivers/gpu/drm/tests/drm_buddy_test.c:735:3: error: expected ')'
random_seed);
^
drivers/gpu/drm/tests/drm_buddy_test.c:734:2: note: to match this '('
kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
^
include/kunit/test.h:438:2: note: expanded from macro 'kunit_info'
kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
^
include/kunit/test.h:425:2: note: expanded from macro 'kunit_printk'
kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
^
include/kunit/test.h:419:3: note: expanded from macro 'kunit_log'
printk(lvl fmt, ##__VA_ARGS__); \
^
include/linux/printk.h:457:26: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
^
include/linux/printk.h:428:3: note: expanded from macro 'printk_index_wrap'
__printk_index_emit(_fmt, NULL, NULL); \
^
include/linux/printk.h:390:32: note: expanded from macro '__printk_index_emit'
.fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
^
>> drivers/gpu/drm/tests/drm_buddy_test.c:735:3: error: expected ')'
random_seed);
^
drivers/gpu/drm/tests/drm_buddy_test.c:734:2: note: to match this '('
kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
^
include/kunit/test.h:438:2: note: expanded from macro 'kunit_info'
kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
^
include/kunit/test.h:425:2: note: expanded from macro 'kunit_printk'
kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
^
include/kunit/test.h:419:3: note: expanded from macro 'kunit_log'
printk(lvl fmt, ##__VA_ARGS__); \
^
include/linux/printk.h:457:26: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
^
include/linux/printk.h:428:3: note: expanded from macro 'printk_index_wrap'
__printk_index_emit(_fmt, NULL, NULL); \
^
include/linux/printk.h:390:41: note: expanded from macro '__printk_index_emit'
.fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
^
>> drivers/gpu/drm/tests/drm_buddy_test.c:735:3: error: expected ')'
random_seed);
^
drivers/gpu/drm/tests/drm_buddy_test.c:734:2: note: to match this '('
kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
^
include/kunit/test.h:438:2: note: expanded from macro 'kunit_info'
kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
^
include/kunit/test.h:425:2: note: expanded from macro 'kunit_printk'
kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
^
include/kunit/test.h:419:3: note: expanded from macro 'kunit_log'
printk(lvl fmt, ##__VA_ARGS__); \
^
include/linux/printk.h:457:26: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
^
include/linux/printk.h:429:10: note: expanded from macro 'printk_index_wrap'
_p_func(_fmt, ##__VA_ARGS__); \
^
>> drivers/gpu/drm/tests/drm_buddy_test.c:734:2: error: member reference base type 'char' is not a structure or union
kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:438:2: note: expanded from macro 'kunit_info'
kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:425:2: note: expanded from macro 'kunit_printk'
kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:420:35: note: expanded from macro 'kunit_log'
kunit_log_append((test_or_suite)->log, fmt "\n", \
~~~~~~~~~~~~~~~^ ~~~
>> drivers/gpu/drm/tests/drm_buddy_test.c:735:3: error: expected ')'
random_seed);
^
drivers/gpu/drm/tests/drm_buddy_test.c:734:2: note: to match this '('
kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
^
include/kunit/test.h:438:2: note: expanded from macro 'kunit_info'
kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
^
include/kunit/test.h:425:2: note: expanded from macro 'kunit_printk'
kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
^
include/kunit/test.h:420:19: note: expanded from macro 'kunit_log'
kunit_log_append((test_or_suite)->log, fmt "\n", \
^
6 errors generated.
--
>> drivers/gpu/drm/tests/drm_mm_test.c:2218:2: error: expected ')'
random_seed, max_iterations, max_prime);
^
drivers/gpu/drm/tests/drm_mm_test.c:2217:2: note: to match this '('
kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
^
include/kunit/test.h:438:2: note: expanded from macro 'kunit_info'
kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
^
include/kunit/test.h:425:2: note: expanded from macro 'kunit_printk'
kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
^
include/kunit/test.h:419:3: note: expanded from macro 'kunit_log'
printk(lvl fmt, ##__VA_ARGS__); \
^
include/linux/printk.h:457:26: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
^
include/linux/printk.h:428:3: note: expanded from macro 'printk_index_wrap'
__printk_index_emit(_fmt, NULL, NULL); \
^
include/linux/printk.h:381:27: note: expanded from macro '__printk_index_emit'
if (__builtin_constant_p(_fmt) && __builtin_constant_p(_level)) { \
^
>> drivers/gpu/drm/tests/drm_mm_test.c:2218:2: error: expected ')'
random_seed, max_iterations, max_prime);
^
drivers/gpu/drm/tests/drm_mm_test.c:2217:2: note: to match this '('
kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
^
include/kunit/test.h:438:2: note: expanded from macro 'kunit_info'
kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
^
include/kunit/test.h:425:2: note: expanded from macro 'kunit_printk'
kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
^
include/kunit/test.h:419:3: note: expanded from macro 'kunit_log'
printk(lvl fmt, ##__VA_ARGS__); \
^
include/linux/printk.h:457:26: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
^
include/linux/printk.h:428:3: note: expanded from macro 'printk_index_wrap'
__printk_index_emit(_fmt, NULL, NULL); \
^
include/linux/printk.h:390:32: note: expanded from macro '__printk_index_emit'
.fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
^
>> drivers/gpu/drm/tests/drm_mm_test.c:2218:2: error: expected ')'
random_seed, max_iterations, max_prime);
^
drivers/gpu/drm/tests/drm_mm_test.c:2217:2: note: to match this '('
kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
^
include/kunit/test.h:438:2: note: expanded from macro 'kunit_info'
kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
^
include/kunit/test.h:425:2: note: expanded from macro 'kunit_printk'
kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
^
include/kunit/test.h:419:3: note: expanded from macro 'kunit_log'
printk(lvl fmt, ##__VA_ARGS__); \
^
include/linux/printk.h:457:26: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
^
include/linux/printk.h:428:3: note: expanded from macro 'printk_index_wrap'
__printk_index_emit(_fmt, NULL, NULL); \
^
include/linux/printk.h:390:41: note: expanded from macro '__printk_index_emit'
.fmt = __builtin_constant_p(_fmt) ? (_fmt) : NULL, \
^
>> drivers/gpu/drm/tests/drm_mm_test.c:2218:2: error: expected ')'
random_seed, max_iterations, max_prime);
^
drivers/gpu/drm/tests/drm_mm_test.c:2217:2: note: to match this '('
kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
^
include/kunit/test.h:438:2: note: expanded from macro 'kunit_info'
kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
^
include/kunit/test.h:425:2: note: expanded from macro 'kunit_printk'
kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
^
include/kunit/test.h:419:3: note: expanded from macro 'kunit_log'
printk(lvl fmt, ##__VA_ARGS__); \
^
include/linux/printk.h:457:26: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
^
include/linux/printk.h:429:10: note: expanded from macro 'printk_index_wrap'
_p_func(_fmt, ##__VA_ARGS__); \
^
>> drivers/gpu/drm/tests/drm_mm_test.c:2217:2: error: member reference base type 'char' is not a structure or union
kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:438:2: note: expanded from macro 'kunit_info'
kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:425:2: note: expanded from macro 'kunit_printk'
kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:420:35: note: expanded from macro 'kunit_log'
kunit_log_append((test_or_suite)->log, fmt "\n", \
~~~~~~~~~~~~~~~^ ~~~
>> drivers/gpu/drm/tests/drm_mm_test.c:2218:2: error: expected ')'
random_seed, max_iterations, max_prime);
^
drivers/gpu/drm/tests/drm_mm_test.c:2217:2: note: to match this '('
kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
^
include/kunit/test.h:438:2: note: expanded from macro 'kunit_info'
kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
^
include/kunit/test.h:425:2: note: expanded from macro 'kunit_printk'
kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt, \
^
include/kunit/test.h:420:19: note: expanded from macro 'kunit_log'
kunit_log_append((test_or_suite)->log, fmt "\n", \
^
6 errors generated.
vim +735 drivers/gpu/drm/tests/drm_buddy_test.c
728
729 static int drm_buddy_init_test(struct kunit *test)
730 {
731 while (!random_seed)
732 random_seed = get_random_u32();
733
> 734 kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
> 735 random_seed);
736
737 return 0;
738 }
739
diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c index 62f69589a72d..83c8863bc643 100644 --- a/drivers/gpu/drm/tests/drm_buddy_test.c +++ b/drivers/gpu/drm/tests/drm_buddy_test.c @@ -731,6 +731,9 @@ static int drm_buddy_init_test(struct kunit *test) while (!random_seed) random_seed = get_random_u32(); + kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n", + random_seed); + return 0; } diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c index c4b66eeae203..492347069d58 100644 --- a/drivers/gpu/drm/tests/drm_mm_test.c +++ b/drivers/gpu/drm/tests/drm_mm_test.c @@ -2214,6 +2214,9 @@ static int drm_mm_init_test(struct kunit *test) while (!random_seed) random_seed = get_random_u32(); + kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n", + random_seed, max_iterations, max_prime); + return 0; } @@ -2251,6 +2254,5 @@ static struct kunit_suite drm_mm_test_suite = { }; kunit_test_suite(drm_mm_test_suite); - MODULE_AUTHOR("Intel Corporation"); MODULE_LICENSE("GPL");