| Message ID | 20230316120113.86421-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp450703wrt;
Thu, 16 Mar 2023 05:25:44 -0700 (PDT)
X-Google-Smtp-Source:
AK7set/yMToEUn4KyC/QwcwzA8QLAcBqFpa4xuFf5hjLh2qhpLaQ+Zd0V665QixyCXgAmFiM9Vlu
X-Received: by 2002:a62:79c1:0:b0:61d:f243:e817 with SMTP id
u184-20020a6279c1000000b0061df243e817mr3827857pfc.16.1678969544010;
Thu, 16 Mar 2023 05:25:44 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1678969543; cv=none;
d=google.com; s=arc-20160816;
b=D944yF4+PcpfpUmymoIaRyQm83h2djL/c2mq9VYLUv9aTK+RxmC6gtWM7kVlzKk99k
3UMlP0LPfsru8pWjHRQcCZRl6GlrR8CnlUVz+fOjOiWy/yKoKwT9hsiXZir5m2fp+Qzd
gKwjVf9sPgzY7VPesPN9YZPRl+vI5SHikGHnFUXSiMnarjIlXMCoBOg3MRr5e6a5DcV2
Vj3cL3r4sLC3bfBM5QRPwOM537ecnsJ17F0DGCacLLyKzMkBOtivkWTHDRI8EJJuKcqS
10UA/7IELfrMm1/f2/E66u5jgV3jC5NnJKeEeoUPjLn/YWwb+AN0jKyT0RMM0VkUp4iz
/VEg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=eYYWW+Hl62wuqbtVg/w3adqnq/5VYoNwPUCmR6t12nI=;
b=jEtj0nx1me/djVCuFK4PdMwH6sv/ikr8V6M+iT8MXlgGEmRcltSGQ2+485Vgk4Rxdw
358jPZ0KuvvsRVyV5VTlQNdpys0aANlRN1r5EgkcPaEwldGAjEfXeXfvBEckELVh63oi
m082kSjxC748TxmlXJ2ZRlzdLQyj6Z8uKfYXnDdFXTVkX9Ryg/tngrSdYEuwd0EWjc+m
3ChaGfggt7FnPzVhqnYvN9PpsZdcatqcNf6cQuocl4ZjePXqcc2S3w+S8bh3YDdLvBfg
JB+HPLoRCNIsf/XrQzh0TGnD7HRw4L3GZSqR7pBqlx95ljQFir7QTII84B0ZATk4I0od
ZoQQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=joS2Gp4D;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
68-20020a620447000000b00592548f4433si7616881pfe.61.2023.03.16.05.25.31;
Thu, 16 Mar 2023 05:25:43 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=joS2Gp4D;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230071AbjCPMAz (ORCPT <rfc822;ruipengqi7@gmail.com> + 99 others);
Thu, 16 Mar 2023 08:00:55 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39710 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229543AbjCPMAy (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 16 Mar 2023 08:00:54 -0400
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 436FF59C1;
Thu, 16 Mar 2023 05:00:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1678968053; x=1710504053;
h=from:to:cc:subject:date:message-id:mime-version:
content-transfer-encoding;
bh=Ocsjhp370mXJgmzlds9QF9+bkkBao99B4P43WAeuJeU=;
b=joS2Gp4DCS4gliVyu4TrpLyNV/KQKDmC9uMNDRW2OLLPfgeBFoaxolP7
dTc6tzb0FwhduFVjIAxko7/J5clqK61/8aHQEtgefr4d2gidP9sj++RdL
DjjoAzvb0mZHN9i8iUKk98sNl8jKVhcYx8AZ300sco3nFkz1+/ie/HiHx
QDhRyk9zRkZEnRilRybPGiwfgOzjKkEThlJG+tCBNLjNtsfwQHcz33xcm
tVLzh+aZ3VF4aL0YL9HgoRmsuQ3WaYOFfx8MRDSF48Jdz1Zo9QHIhqjLm
M8/YbiV0Ylev4KtmezA/2rF2v8Pdge9cWa1NKONNH7mQm2RN8sZyJFSne
g==;
X-IronPort-AV: E=McAfee;i="6500,9779,10650"; a="317617755"
X-IronPort-AV: E=Sophos;i="5.98,265,1673942400";
d="scan'208";a="317617755"
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
16 Mar 2023 05:00:49 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6500,9779,10650"; a="823212876"
X-IronPort-AV: E=Sophos;i="5.98,265,1673942400";
d="scan'208";a="823212876"
Received: from black.fi.intel.com ([10.237.72.28])
by fmsmga001.fm.intel.com with ESMTP; 16 Mar 2023 05:00:33 -0700
Received: by black.fi.intel.com (Postfix, from userid 1003)
id E64DB3DD; Thu, 16 Mar 2023 14:01:17 +0200 (EET)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rob Herring <robh@kernel.org>, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 1/1] regulator: s5m8767: Replace of_gpio.h with what indeed
is used
Date: Thu, 16 Mar 2023 14:01:13 +0200
Message-Id: <20230316120113.86421-1-andriy.shevchenko@linux.intel.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1760527168424212725?=
X-GMAIL-MSGID: =?utf-8?q?1760527168424212725?=
|
| Series |
[v1,1/1] regulator: s5m8767: Replace of_gpio.h with what indeed is used
|
|
Commit Message
Andy Shevchenko
March 16, 2023, 12:01 p.m. UTC
of_gpio.h in this driver is solely used as a proxy to other headers.
This is incorrect usage of the of_gpio.h. Replace it .h with what
indeed is used in the code.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/regulator/s5m8767.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Thu, Mar 16, 2023 at 02:01:13PM +0200, Andy Shevchenko wrote: > of_gpio.h in this driver is solely used as a proxy to other headers. > This is incorrect usage of the of_gpio.h. Replace it .h with what > indeed is used in the code. This breaks an x86 allmodconfig build: /build/stage/linux/drivers/regulator/s5m8767.c: In function ‘s5m8767_pmic_dt_parse_dvs_gpio’: /build/stage/linux/drivers/regulator/s5m8767.c:492:24: error: implicit declaration of function ‘of_get_named_gpio’ [-Werror=implicit-function-declaration] 492 | gpio = of_get_named_gpio(pmic_np, | ^~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors
On Thu, Mar 16, 2023 at 01:10:46PM +0000, Mark Brown wrote: > On Thu, Mar 16, 2023 at 02:01:13PM +0200, Andy Shevchenko wrote: > > of_gpio.h in this driver is solely used as a proxy to other headers. > > This is incorrect usage of the of_gpio.h. Replace it .h with what > > indeed is used in the code. > > This breaks an x86 allmodconfig build: > > /build/stage/linux/drivers/regulator/s5m8767.c: In function ‘s5m8767_pmic_dt_parse_dvs_gpio’: > /build/stage/linux/drivers/regulator/s5m8767.c:492:24: error: implicit declaration of function ‘of_get_named_gpio’ [-Werror=implicit-function-declaration] > 492 | gpio = of_get_named_gpio(pmic_np, > | ^~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors Oh, sorry for that. I missed something. Please, ignore this one, it should be different one.
diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c index 3122ca7de8f5..b4a699701a81 100644 --- a/drivers/regulator/s5m8767.c +++ b/drivers/regulator/s5m8767.c @@ -4,9 +4,10 @@ // http://www.samsung.com #include <linux/err.h> -#include <linux/of_gpio.h> +#include <linux/gpio.h> #include <linux/gpio/consumer.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/regulator/driver.h> #include <linux/regulator/machine.h>