diff mbox series

[net-next] net: ethernet: ave: Remove duplicate phy_resume() calls

Message ID 20221024072314.24969-1-hayashi.kunihiko@socionext.com
State New
Headers
Series [net-next] net: ethernet: ave: Remove duplicate phy_resume() calls |

Commit Message

Kunihiko Hayashi Oct. 24, 2022, 7:23 a.m. UTC 
  ave_open() in ave_resume() executes __phy_resume() via phy_start(), so no
need to call phy_resume() explicitly. Remove it.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 drivers/net/ethernet/socionext/sni_ave.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 27, 2022, 3:30 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 24 Oct 2022 16:23:14 +0900 you wrote:
> ave_open() in ave_resume() executes __phy_resume() via phy_start(), so no
> need to call phy_resume() explicitly. Remove it.
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>  drivers/net/ethernet/socionext/sni_ave.c | 6 ------
>  1 file changed, 6 deletions(-)

Here is the summary with links:
  - [net-next] net: ethernet: ave: Remove duplicate phy_resume() calls
    https://git.kernel.org/netdev/net-next/c/3a6573b7a218

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c
index d2c6a5dfdc0e..c6a6c9ed5365 100644
--- a/drivers/net/ethernet/socionext/sni_ave.c
+++ b/drivers/net/ethernet/socionext/sni_ave.c
@@ -1766,12 +1766,6 @@  static int ave_resume(struct device *dev)
 	wol.wolopts = priv->wolopts;
 	__ave_ethtool_set_wol(ndev, &wol);
 
-	if (ndev->phydev) {
-		ret = phy_resume(ndev->phydev);
-		if (ret)
-			return ret;
-	}
-
 	if (netif_running(ndev)) {
 		ret = ave_open(ndev);
 		netif_device_attach(ndev);