Message ID | 20230315142446.27040-1-vbabka@suse.cz |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2383735wrd; Wed, 15 Mar 2023 08:11:16 -0700 (PDT) X-Google-Smtp-Source: AK7set8QffRAZ/4+td0GM8PO0IoWUV/IiRwYd9cHcIhDead/iMnGVRw6IfBz4a4LqWGrbp+XRHSo X-Received: by 2002:a17:90b:3841:b0:233:f7a5:9940 with SMTP id nl1-20020a17090b384100b00233f7a59940mr229774pjb.1.1678893075905; Wed, 15 Mar 2023 08:11:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678893075; cv=none; d=google.com; s=arc-20160816; b=pgFeX65fSELhSS+zc7dBfDtuEjU4epoRwBeiH/SmH/fn+1mXeL5YKX61+sDWw9n7ND WUUZDIQRzV9sozaNJq+WtZG0k/N4xu5zD1kvbVAFawu+DWiNj03Q6RtYPkzzC12UcETs rIKh1kdoMYa6/RqVkdFl4TX07661h+DRXK52Vp42tK9b3CK0VrRXZuv05aW5uTNv/add pA4qQTdpr/Wqea3Wczt3UkcotTFG3XCSXH5rLWcI78DrT1yzJxskgbfXLRsQam5Htu2e Thz2wEP2S768MzpZRxBMS5SD+nvnq8RF1Jvx0Fxvme5QUwYpJYKleyAquhtFXWqMiH3K lr0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=a+KmZa22ry4Mgykdv6ds4+NZZU+jJdD3ovXoAnBercU=; b=yotJKplNJojdXXyYxMBrWJpNcVuE5BeQ8bFI9UQQsImWG6GQ6K47a554p6ak7XPAvN cQlY3bYTg9ibhU+kY7l/a2V8TI/eUsuPz8KJx1P3/4EeUTyKd9KeuvbzbOr1tX4bIDx9 aVfKRC05Q+Y33Og0WUUt6dsw7jh+tuF9lzXs/yr61w7a4PTm6Y6gzD0jx5kZQ49vEKe6 QFL3zMpgBzXZbaBxxVG1AA3JM1We+PAEBcInoQozoHAa0/z3cAEeTAUMAG81OaEgPyAi +I0McvKkA1vAZ2wCMGWowwBlOYNj7p75v/uQ1PCrF2bkkyJcI+1Tzk/PHvpf9fgCCNGy 763A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=fk+lviOJ; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=PKcHYVjH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w1-20020a17090aad4100b00233ce76f19dsi1899120pjv.11.2023.03.15.08.11.02; Wed, 15 Mar 2023 08:11:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=fk+lviOJ; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=PKcHYVjH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230176AbjCOOZM (ORCPT <rfc822;ruipengqi7@gmail.com> + 99 others); Wed, 15 Mar 2023 10:25:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233204AbjCOOY4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 15 Mar 2023 10:24:56 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9004126BA; Wed, 15 Mar 2023 07:24:53 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 46B3D219B6; Wed, 15 Mar 2023 14:24:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678890292; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=a+KmZa22ry4Mgykdv6ds4+NZZU+jJdD3ovXoAnBercU=; b=fk+lviOJUYNIIWxZOQhBR3LYVKPlSO9Q7aIZlYx+5Pqh+c8/whk6rzTCZ0lz+4kEWpcKes mGAIJV8WYHa9uLpVrFRSWralgJptO3m9XhZotPURxqBh7xCYEMxy4fW7iahXQwyLGKiDhO f6MrDxPvgubph7iVYP2ODp1BgAZ/eyg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678890292; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=a+KmZa22ry4Mgykdv6ds4+NZZU+jJdD3ovXoAnBercU=; b=PKcHYVjHTS3FQPTGcYiDe8udkvAtI9bmDIT8yZfNAEK1cRYJJFKSqBfoGSaTRmG8uUprMn 4NPv5OFsvmDfgjCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2732213A2F; Wed, 15 Mar 2023 14:24:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dV3kCDTVEWTaRwAAMHmgww (envelope-from <vbabka@suse.cz>); Wed, 15 Mar 2023 14:24:52 +0000 From: Vlastimil Babka <vbabka@suse.cz> To: Steven Rostedt <rostedt@goodmis.org>, Masami Hiramatsu <mhiramat@kernel.org>, Ingo Molnar <mingo@elte.hu> Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <mike.rapoport@gmail.com> Subject: [PATCH] ring-buffer: remove obsolete comment for free_buffer_page() Date: Wed, 15 Mar 2023 15:24:46 +0100 Message-Id: <20230315142446.27040-1-vbabka@suse.cz> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_SOFTFAIL,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760446985827305865?= X-GMAIL-MSGID: =?utf-8?q?1760446985827305865?= |
Series |
ring-buffer: remove obsolete comment for free_buffer_page()
|
|
Commit Message
Vlastimil Babka
March 15, 2023, 2:24 p.m. UTC
The comment refers to mm/slob.o which is being removed. It comes from
commit ed56829cb319 ("ring_buffer: reset buffer page when freeing") and
according to Steven the borrowed code was a page mapcount and mapping
reset, which was later removed by commit e4c2ce82ca27 ("ring_buffer:
allocate buffer page pointer"). Thus the comment is not accurate anyway,
remove it.
Reported-by: Mike Rapoport <mike.rapoport@gmail.com>
Suggested-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Fixes: e4c2ce82ca27 ("ring_buffer: allocate buffer page pointer")
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
---
kernel/trace/ring_buffer.c | 4 ----
1 file changed, 4 deletions(-)
Comments
On 3/15/2023 7:54 PM, Vlastimil Babka wrote: > The comment refers to mm/slob.o which is being removed. It comes from > commit ed56829cb319 ("ring_buffer: reset buffer page when freeing") and > according to Steven the borrowed code was a page mapcount and mapping > reset, which was later removed by commit e4c2ce82ca27 ("ring_buffer: > allocate buffer page pointer"). Thus the comment is not accurate anyway, > remove it. > > Reported-by: Mike Rapoport <mike.rapoport@gmail.com> > Suggested-by: Steven Rostedt (Google) <rostedt@goodmis.org> > Fixes: e4c2ce82ca27 ("ring_buffer: allocate buffer page pointer") > Signed-off-by: Vlastimil Babka <vbabka@suse.cz> > --- > kernel/trace/ring_buffer.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c > index af50d931b020..c6f47b6cfd5f 100644 > --- a/kernel/trace/ring_buffer.c > +++ b/kernel/trace/ring_buffer.c > @@ -354,10 +354,6 @@ static void rb_init_page(struct buffer_data_page *bpage) > local_set(&bpage->commit, 0); > } > > -/* > - * Also stolen from mm/slob.c. Thanks to Mathieu Desnoyers for pointing > - * this issue out. > - */ Thanks for the clean up. Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com> -- Mukesh > static void free_buffer_page(struct buffer_page *bpage) > { > free_page((unsigned long)bpage->page);
On 3/15/2023 9:21 PM, Mukesh Ojha wrote: > > > On 3/15/2023 7:54 PM, Vlastimil Babka wrote: >> The comment refers to mm/slob.o which is being removed. It comes from nit: mm/slob.c -- Mukesh > > >> commit ed56829cb319 ("ring_buffer: reset buffer page when freeing") and >> according to Steven the borrowed code was a page mapcount and mapping >> reset, which was later removed by commit e4c2ce82ca27 ("ring_buffer: >> allocate buffer page pointer"). Thus the comment is not accurate anyway, >> remove it. >> >> Reported-by: Mike Rapoport <mike.rapoport@gmail.com> >> Suggested-by: Steven Rostedt (Google) <rostedt@goodmis.org> >> Fixes: e4c2ce82ca27 ("ring_buffer: allocate buffer page pointer") >> Signed-off-by: Vlastimil Babka <vbabka@suse.cz> >> --- >> kernel/trace/ring_buffer.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c >> index af50d931b020..c6f47b6cfd5f 100644 >> --- a/kernel/trace/ring_buffer.c >> +++ b/kernel/trace/ring_buffer.c >> @@ -354,10 +354,6 @@ static void rb_init_page(struct buffer_data_page >> *bpage) >> local_set(&bpage->commit, 0); >> } >> -/* >> - * Also stolen from mm/slob.c. Thanks to Mathieu Desnoyers for pointing >> - * this issue out. >> - */ > > Thanks for the clean up. > > Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com> > > -- Mukesh > >> static void free_buffer_page(struct buffer_page *bpage) >> { >> free_page((unsigned long)bpage->page);
On 3/15/23 16:53, Mukesh Ojha wrote: > > > On 3/15/2023 9:21 PM, Mukesh Ojha wrote: >> >> >> On 3/15/2023 7:54 PM, Vlastimil Babka wrote: >>> The comment refers to mm/slob.o which is being removed. It comes from > > nit: mm/slob.c Thanks, Steven can you fix that up while picking the patch, or need v2? > -- Mukesh > >> >> >>> commit ed56829cb319 ("ring_buffer: reset buffer page when freeing") and >>> according to Steven the borrowed code was a page mapcount and mapping >>> reset, which was later removed by commit e4c2ce82ca27 ("ring_buffer: >>> allocate buffer page pointer"). Thus the comment is not accurate anyway, >>> remove it. >>> >>> Reported-by: Mike Rapoport <mike.rapoport@gmail.com> >>> Suggested-by: Steven Rostedt (Google) <rostedt@goodmis.org> >>> Fixes: e4c2ce82ca27 ("ring_buffer: allocate buffer page pointer") >>> Signed-off-by: Vlastimil Babka <vbabka@suse.cz> >>> --- >>> kernel/trace/ring_buffer.c | 4 ---- >>> 1 file changed, 4 deletions(-) >>> >>> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c >>> index af50d931b020..c6f47b6cfd5f 100644 >>> --- a/kernel/trace/ring_buffer.c >>> +++ b/kernel/trace/ring_buffer.c >>> @@ -354,10 +354,6 @@ static void rb_init_page(struct buffer_data_page >>> *bpage) >>> local_set(&bpage->commit, 0); >>> } >>> -/* >>> - * Also stolen from mm/slob.c. Thanks to Mathieu Desnoyers for pointing >>> - * this issue out. >>> - */ >> >> Thanks for the clean up. >> >> Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com> Thanks. >> >> -- Mukesh >> >>> static void free_buffer_page(struct buffer_page *bpage) >>> { >>> free_page((unsigned long)bpage->page);
On Thu, 16 Mar 2023 09:29:30 +0100 Vlastimil Babka <vbabka@suse.cz> wrote: > On 3/15/23 16:53, Mukesh Ojha wrote: > > > > > > On 3/15/2023 9:21 PM, Mukesh Ojha wrote: > >> > >> > >> On 3/15/2023 7:54 PM, Vlastimil Babka wrote: > >>> The comment refers to mm/slob.o which is being removed. It comes from > > > > nit: mm/slob.c > > Thanks, Steven can you fix that up while picking the patch, or need v2? I'll fix it up. -- Steve
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index af50d931b020..c6f47b6cfd5f 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ -354,10 +354,6 @@ static void rb_init_page(struct buffer_data_page *bpage) local_set(&bpage->commit, 0); } -/* - * Also stolen from mm/slob.c. Thanks to Mathieu Desnoyers for pointing - * this issue out. - */ static void free_buffer_page(struct buffer_page *bpage) { free_page((unsigned long)bpage->page);