diff mbox series

[2/2] soc: qcom: socinfo: Add IDs for QCM2290/QRB2210

Message ID 20230314-topic-scuba_socinfo-v1-2-acd7a7ab9d46@linaro.org
State New
Headers
Series QCM2290 socinfo |

Commit Message

Konrad Dybcio March 14, 2023, 9:41 p.m. UTC 
  Add the missing IDs for scuba and its QRB variant.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/soc/qcom/socinfo.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski March 15, 2023, 6:43 a.m. UTC | #1 
On 14/03/2023 22:41, Konrad Dybcio wrote:
> Add the missing IDs for scuba and its QRB variant.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  drivers/soc/qcom/socinfo.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index e9012ca1a87b..dfc0fc3e90ca 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -424,11 +424,13 @@ static const struct soc_id soc_id[] = {
>  	{ qcom_board_id(SC7180) },
>  	{ qcom_board_id(SM6350) },
>  	{ qcom_board_id(QCM2150) },
> +	{ qcom_board_id(QCM2290) },
>  	{ qcom_board_id(SDA429W) },
>  	{ qcom_board_id(SM8350) },
>  	{ qcom_board_id(SM6115) },
>  	{ qcom_board_id(SC8280XP) },
>  	{ qcom_board_id(IPQ6005) },
> +	{ qcom_board_id(QRB2210) },

These should have the same order as defines, so something is here incorrect.

Best regards,
Krzysztof
Konrad Dybcio March 15, 2023, 10:14 a.m. UTC | #2 
On 15.03.2023 07:43, Krzysztof Kozlowski wrote:
> On 14/03/2023 22:41, Konrad Dybcio wrote:
>> Add the missing IDs for scuba and its QRB variant.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>  drivers/soc/qcom/socinfo.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
>> index e9012ca1a87b..dfc0fc3e90ca 100644
>> --- a/drivers/soc/qcom/socinfo.c
>> +++ b/drivers/soc/qcom/socinfo.c
>> @@ -424,11 +424,13 @@ static const struct soc_id soc_id[] = {
>>  	{ qcom_board_id(SC7180) },
>>  	{ qcom_board_id(SM6350) },
>>  	{ qcom_board_id(QCM2150) },
>> +	{ qcom_board_id(QCM2290) },
>>  	{ qcom_board_id(SDA429W) },
>>  	{ qcom_board_id(SM8350) },
>>  	{ qcom_board_id(SM6115) },
>>  	{ qcom_board_id(SC8280XP) },
>>  	{ qcom_board_id(IPQ6005) },
>> +	{ qcom_board_id(QRB2210) },
> 
> These should have the same order as defines, so something is here incorrect.
Right, I didn't give it much thought and just added them alphabetically-ish.
I'll fix it right away!

Konrad
> 
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index e9012ca1a87b..dfc0fc3e90ca 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -424,11 +424,13 @@  static const struct soc_id soc_id[] = {
 	{ qcom_board_id(SC7180) },
 	{ qcom_board_id(SM6350) },
 	{ qcom_board_id(QCM2150) },
+	{ qcom_board_id(QCM2290) },
 	{ qcom_board_id(SDA429W) },
 	{ qcom_board_id(SM8350) },
 	{ qcom_board_id(SM6115) },
 	{ qcom_board_id(SC8280XP) },
 	{ qcom_board_id(IPQ6005) },
+	{ qcom_board_id(QRB2210) },
 	{ qcom_board_id(QRB5165) },
 	{ qcom_board_id(SM8450) },
 	{ qcom_board_id(SM7225) },