Message ID | 20230310214632.275648-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1119525wrd; Fri, 10 Mar 2023 14:02:14 -0800 (PST) X-Google-Smtp-Source: AK7set8jes8JA0ukpRmmwhBikIA8upaGgaSYhnoth4kHl6n5ATKCuMDl92ey6SYdUY1WLsaAlD11 X-Received: by 2002:a17:902:bc42:b0:19e:6a4c:9fa0 with SMTP id t2-20020a170902bc4200b0019e6a4c9fa0mr23626960plz.49.1678485734178; Fri, 10 Mar 2023 14:02:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678485734; cv=none; d=google.com; s=arc-20160816; b=JAnUI0ZB54AeJ5/qKyiIs6HCTebPQFW8UG33psgGVfO3/NZQQNdvWN6qtTj1bKRwwd Wjht7FtkGyI9hug32YKUgz8ZqzL/MzEHdiTaId0UBlWmWFSh7l4XxhE2js8nAQsENrUL RhKVseUnyJBgOj9AhZ4/QC96PoqyRqyoI1RXO1XATh05pZ1KL17WmxEmiCJYDLeHVSjx F+4Dz++nMq0kyX3GMdaaLkQ06w57pn/AnjlT83DGxBCBNGdRMfDXiGnx3i72Cc1vNR2z B2Jl+/tkzpU23/MsmRm22FasbKfz2yLIPp1ERnVRjamy/RSt0E2xMPRFrtRHRcwQSzwj sVCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=SeJX9lSGwZbRGOASyeKJInBHWHmDyRL8Oo8/OupUB9Q=; b=zW51OpLlXbD2lMWjcUm33+QThMg6mAtWKHyvFOa4vnrV+5T8oELYbBnDwKjuSTlPtH u4Qp8LkP/gwOnhDv92BDK6vMRa9AWtKL3GYoH31HEvxjDOUggnyGOtQYwy+P/fNcnpcn 0MjPXV9iwx5HQ48UNx6n+F2ZGc4pv78Hx68VRGGFyM8XWNnadlzRY6h9xcO4WGqLqrz0 +z9DC62lmP++OcrAFvmRHnr5whCRDmdMMCkP8HAGj+2xkhFszwuDeb7fS6gj92VYTOwB TlJIaX6wf3AoN4SwWOzeUnIun5+YlOBjvBjYtmMgCvxkZpOOW0/S3sFJEuX8gIAZXyc0 lhsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I4VhGR8B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ki8-20020a170903068800b0019ccffb3fd3si831285plb.509.2023.03.10.14.01.59; Fri, 10 Mar 2023 14:02:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I4VhGR8B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231967AbjCJVvH (ORCPT <rfc822;carlos.wei.hk@gmail.com> + 99 others); Fri, 10 Mar 2023 16:51:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232541AbjCJVuj (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 10 Mar 2023 16:50:39 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ADF213EBA7 for <linux-kernel@vger.kernel.org>; Fri, 10 Mar 2023 13:47:50 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id ec29so26108047edb.6 for <linux-kernel@vger.kernel.org>; Fri, 10 Mar 2023 13:47:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678484797; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SeJX9lSGwZbRGOASyeKJInBHWHmDyRL8Oo8/OupUB9Q=; b=I4VhGR8BarZ8ZUC/EPGtBWoticWk4MDuo0tG3Tg1iNkyklQ2Ur0SuiqcPODtE2eMBf PyeDV5OcJpdUHGd0wHSGqBEZB7YeXs9mEOxD3htiyMPdbfO2dAPkaOJsB+Kr6WWn9Z2s 8Jl4R5WOgnBRXbpBKvAa0kEOAHXE9/7qfcblWSrM0YZbuJi6EqOK4NitnHKNs4cC+3/4 7hjMaA4G9lfyHpVebanLvVFUMkYNajOyIg6C33wTk/rGYaR+zfx5s9neSPUZ4CrX7w9a 8o+Mdt+mzzNn7Cvv4pxDZHRchsZWOOmGTSFXDGk/q8Jrf3q/9lsgLKvERaYG9NyaLVKc vB1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678484797; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SeJX9lSGwZbRGOASyeKJInBHWHmDyRL8Oo8/OupUB9Q=; b=mCpl2h0YTDcFaITQ9evjoNmQE/wHDqW7bXFl4Kr+CggFvbHgjxDKV6k881uPbFaMFn gsjD20uAmGqQte/LVzQdB5gi39JSnbyA2qkD6iBCpWHO3y0ZIOaGCBuy++QG+8etVdjX 9vSLoh/MQrdee4yJk8Lle+MViOu0qCDKXtWeOYIOxnhqSEnyOpLGSi1bivc7R+JBjhLG HDkBCLYGtntDRnzyWu937tXpEHYjK+uCW1TVgMd/VWzlNBWABXWLCbPtNm1uYKOL+QIS Ydt//DDG6OMnhDW8nnFf4rPGI7xq8kjnBdEzl4ADn6XOT4rGgU4e/BkItxGncTW22vcZ 0X6A== X-Gm-Message-State: AO0yUKX5b5tJluhcnrxUbDr2q//lG0ZJcqrd6Upka8+2uGuunRn5B/hv FLxf6hkxrEllRvCQtSVC/f5hlw== X-Received: by 2002:a05:6402:1608:b0:4bf:da1a:2be3 with SMTP id f8-20020a056402160800b004bfda1a2be3mr22977290edv.34.1678484796905; Fri, 10 Mar 2023 13:46:36 -0800 (PST) Received: from krzk-bin.. ([2a02:810d:15c0:828:34:52e3:a77e:cac5]) by smtp.gmail.com with ESMTPSA id t5-20020a50ab45000000b004bf7905559asm488088edc.44.2023.03.10.13.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 13:46:36 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Byungho An <bh74.an@samsung.com>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Vinod Koul <vkoul@kernel.org>, Bhupesh Sharma <bhupesh.sharma@linaro.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 1/5] net: stmmac: qcom: drop of_match_ptr for ID table Date: Fri, 10 Mar 2023 22:46:28 +0100 Message-Id: <20230310214632.275648-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760019857183115605?= X-GMAIL-MSGID: =?utf-8?q?1760019857183115605?= |
Series |
[1/5] net: stmmac: qcom: drop of_match_ptr for ID table
|
|
Commit Message
Krzysztof Kozlowski
March 10, 2023, 9:46 p.m. UTC
The driver is specific to ARCH_QCOM which depends on OF thus the driver
is OF-only. Its of_device_id table is built unconditionally, thus
of_match_ptr() for ID table does not make sense.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Mar 10, 2023 at 10:46:28PM +0100, Krzysztof Kozlowski wrote: > The driver is specific to ARCH_QCOM which depends on OF thus the driver > is OF-only. Its of_device_id table is built unconditionally, thus > of_match_ptr() for ID table does not make sense. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 10 Mar 2023 22:46:28 +0100 you wrote: > The driver is specific to ARCH_QCOM which depends on OF thus the driver > is OF-only. Its of_device_id table is built unconditionally, thus > of_match_ptr() for ID table does not make sense. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [1/5] net: stmmac: qcom: drop of_match_ptr for ID table https://git.kernel.org/netdev/net-next/c/dc54e450a5dd - [2/5] net: stmmac: generic: drop of_match_ptr for ID table https://git.kernel.org/netdev/net-next/c/e6512465838b - [3/5] net: marvell: pxa168_eth: drop of_match_ptr for ID table https://git.kernel.org/netdev/net-next/c/69df36d524db - [4/5] net: samsung: sxgbe: drop of_match_ptr for ID table https://git.kernel.org/netdev/net-next/c/7f319fe4363c - [5/5] net: ni: drop of_match_ptr for ID table https://git.kernel.org/netdev/net-next/c/7e9aa8cad084 You are awesome, thank you!
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 732774645c1a..32763566c214 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -606,7 +606,7 @@ static struct platform_driver qcom_ethqos_driver = { .driver = { .name = "qcom-ethqos", .pm = &stmmac_pltfr_pm_ops, - .of_match_table = of_match_ptr(qcom_ethqos_match), + .of_match_table = qcom_ethqos_match, }, }; module_platform_driver(qcom_ethqos_driver);