diff mbox series

[1/1] clk: mxl: Fix smatch static checker warning

Message ID 49e339d4739e4ae4c92b00c1b2918af0755d4122.1666695221.git.rtanwar@maxlinear.com
State New
Headers
Series clk: mxl: Fix smatch static checker warning |

Commit Message

Rahul Tanwar Oct. 25, 2022, 11:03 a.m. UTC 
  Commit 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO to
regmap based IO") introduced code resulting in below warning issued by the
smatch static checker.

        drivers/clk/x86/clk-lgm.c:441 lgm_cgu_probe()
        warn: passing zero to 'PTR_ERR'

Fix the warning by replacing incorrect IS_ERR_OR_NULL() with IS_ERR().

Fixes: 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO to
regmap based IO")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rahul Tanwar <rtanwar@maxlinear.com>
---
 drivers/clk/x86/clk-lgm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Boyd Oct. 27, 2022, 1:05 a.m. UTC | #1 
Quoting Rahul Tanwar (2022-10-25 04:03:57)
> Commit 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO to
> regmap based IO") introduced code resulting in below warning issued by the
> smatch static checker.
> 
>         drivers/clk/x86/clk-lgm.c:441 lgm_cgu_probe()
>         warn: passing zero to 'PTR_ERR'
> 
> Fix the warning by replacing incorrect IS_ERR_OR_NULL() with IS_ERR().
> 
> Fixes: 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO to
> regmap based IO")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Rahul Tanwar <rtanwar@maxlinear.com>
> ---

Applied to clk-next

BTW, please don't send a cover letter for single patches.
diff mbox series

Patch

diff --git a/drivers/clk/x86/clk-lgm.c b/drivers/clk/x86/clk-lgm.c
index 4de77b2c750d..f69455dd1c98 100644
--- a/drivers/clk/x86/clk-lgm.c
+++ b/drivers/clk/x86/clk-lgm.c
@@ -436,7 +436,7 @@  static int lgm_cgu_probe(struct platform_device *pdev)
 	ctx->clk_data.num = CLK_NR_CLKS;
 
 	ctx->membase = syscon_node_to_regmap(np);
-	if (IS_ERR_OR_NULL(ctx->membase)) {
+	if (IS_ERR(ctx->membase)) {
 		dev_err(dev, "Failed to get clk CGU iomem\n");
 		return PTR_ERR(ctx->membase);
 	}