diff mbox series

arm64: dts: marvell: armada-ap810: Fix GICv3 ITS node name

Message ID 20230207234735.201812-1-robh@kernel.org
State New
Headers
Series arm64: dts: marvell: armada-ap810: Fix GICv3 ITS node name |

Commit Message

Rob Herring Feb. 7, 2023, 11:47 p.m. UTC 
  The GICv3 ITS is an MSI controller, therefore its node name should be
'msi-controller'.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring March 14, 2023, 3:22 p.m. UTC | #1 
On Tue, Feb 7, 2023 at 5:47 PM Rob Herring <robh@kernel.org> wrote:
>
> The GICv3 ITS is an MSI controller, therefore its node name should be
> 'msi-controller'.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ping!

If not maintained, should I send a patch removing this platform instead?

>
> diff --git a/arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi b/arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi
> index 8107d120a8a7..2f9ab6b4a2c9 100644
> --- a/arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi
> @@ -54,7 +54,7 @@ gic: interrupt-controller@3000000 {
>                                       <0x00d0000 0x1000>,       /* GICH */
>                                       <0x00e0000 0x2000>;       /* GICV */
>
> -                               gic_its_ap0: interrupt-controller@3040000 {
> +                               gic_its_ap0: msi-controller@3040000 {
>                                         compatible = "arm,gic-v3-its";
>                                         msi-controller;
>                                         #msi-cells = <1>;
> --
> 2.39.1
>
Krzysztof Kozlowski March 14, 2023, 3:34 p.m. UTC | #2 
On 14/03/2023 16:22, Rob Herring wrote:
> On Tue, Feb 7, 2023 at 5:47 PM Rob Herring <robh@kernel.org> wrote:
>>
>> The GICv3 ITS is an MSI controller, therefore its node name should be
>> 'msi-controller'.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>>  arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Ping!
> 
> If not maintained, should I send a patch removing this platform instead?

I am not the maintainer but I produce (and take) such stuff, so I can
take this one.

Best regards,
Krzysztof
Krzysztof Kozlowski March 14, 2023, 3:35 p.m. UTC | #3 
On Tue, 7 Feb 2023 17:47:35 -0600, Rob Herring wrote:
> The GICv3 ITS is an MSI controller, therefore its node name should be
> 'msi-controller'.
> 
> 

Applied, thanks! Let me know if anyone else wants to take it instead.

[1/1] arm64: dts: marvell: armada-ap810: Fix GICv3 ITS node name
      https://git.kernel.org/krzk/linux-dt/c/fce7defb8a46c31cf9384fee6e4b1e4920c46ff7

Best regards,
Andrew Lunn March 14, 2023, 4:21 p.m. UTC | #4 
On Tue, Mar 14, 2023 at 10:22:40AM -0500, Rob Herring wrote:
> On Tue, Feb 7, 2023 at 5:47 PM Rob Herring <robh@kernel.org> wrote:
> >
> > The GICv3 ITS is an MSI controller, therefore its node name should be
> > 'msi-controller'.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Ping!
> 
> If not maintained, should I send a patch removing this platform instead?

Gregory usually picks these up around -rc6.

	Andrew
Krzysztof Kozlowski March 14, 2023, 4:41 p.m. UTC | #5 
On 14/03/2023 17:21, Andrew Lunn wrote:
> On Tue, Mar 14, 2023 at 10:22:40AM -0500, Rob Herring wrote:
>> On Tue, Feb 7, 2023 at 5:47 PM Rob Herring <robh@kernel.org> wrote:
>>>
>>> The GICv3 ITS is an MSI controller, therefore its node name should be
>>> 'msi-controller'.
>>>
>>> Signed-off-by: Rob Herring <robh@kernel.org>
>>> ---
>>>  arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Ping!
>>
>> If not maintained, should I send a patch removing this platform instead?
> 
> Gregory usually picks these up around -rc6.

Hm, so they stay in next for just one or two weeks before sending to
arm-soc? Why? They should be in the next as fast as possible, why waiting?

Second question, shall I drop it?

Best regards,
Krzysztof
Rob Herring March 14, 2023, 6:23 p.m. UTC | #6 
On Tue, Mar 14, 2023 at 11:22 AM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Tue, Mar 14, 2023 at 10:22:40AM -0500, Rob Herring wrote:
> > On Tue, Feb 7, 2023 at 5:47 PM Rob Herring <robh@kernel.org> wrote:
> > >
> > > The GICv3 ITS is an MSI controller, therefore its node name should be
> > > 'msi-controller'.
> > >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > ---
> > >  arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Ping!
> >
> > If not maintained, should I send a patch removing this platform instead?
>
> Gregory usually picks these up around -rc6.

Ignoring patches for up to 2 months is not a great experience for submitters.

Rob
Gregory CLEMENT April 7, 2023, 3:11 p.m. UTC | #7 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:

> On Tue, 7 Feb 2023 17:47:35 -0600, Rob Herring wrote:
>> The GICv3 ITS is an MSI controller, therefore its node name should be
>> 'msi-controller'.
>> 
>> 
>
> Applied, thanks! Let me know if anyone else wants to take it instead.
>
> [1/1] arm64: dts: marvell: armada-ap810: Fix GICv3 ITS node name
>       https://git.kernel.org/krzk/linux-dt/c/fce7defb8a46c31cf9384fee6e4b1e4920c46ff7

Let's hope it won't cause merge issue.

Gregory

>
> Best regards,
> -- 
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi b/arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi
index 8107d120a8a7..2f9ab6b4a2c9 100644
--- a/arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-ap810-ap0.dtsi
@@ -54,7 +54,7 @@  gic: interrupt-controller@3000000 {
 				      <0x00d0000 0x1000>,	/* GICH */
 				      <0x00e0000 0x2000>;	/* GICV */
 
-				gic_its_ap0: interrupt-controller@3040000 {
+				gic_its_ap0: msi-controller@3040000 {
 					compatible = "arm,gic-v3-its";
 					msi-controller;
 					#msi-cells = <1>;