Message ID | 167865351393.5837.17719714572303479044.tip-bot2@tip-bot2 |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp875222wrd; Sun, 12 Mar 2023 14:07:44 -0700 (PDT) X-Google-Smtp-Source: AK7set8r099be13oTwgidcNT9Fi0OZOiyrJy9yd3bC7C9HM587DWY42wTE4iN/WwtcnnnVpuqTMf X-Received: by 2002:a05:6a20:7351:b0:cc:8360:8cd2 with SMTP id v17-20020a056a20735100b000cc83608cd2mr7143731pzc.25.1678655263950; Sun, 12 Mar 2023 14:07:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678655263; cv=none; d=google.com; s=arc-20160816; b=fhgked5dUN3H9K84YFrjFWgpdHMjF1Wx74HFo2QifPFNlotw441yXsTCoyLI8o6BvC evogJ/1WzfJ+gX5TcHrXKWUikBGuAGDJNXCw4gkQKNePkUr5JbOVf4qbo8scZRZABTkv 2IjcojMcXxXpWlrT+2dSz5q/d+7UMypmmVdr0YigUeorcr+BGoUg3xi/O1BFGgfWz9nC 0akAh+hEw1bOch2QXU7URXcL1RkydgqG7sp5gXMhS61Oen4rgdZxRM1TLXAxplGQEE7a WPHNncBZiGNtXiARTHthbfXn51SMWKsyiZY1oXuv5YfduzADk5kxO24E/jniuFzOV1qo qz5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=S8phezYGkV4ZFxG7GBTMyfW74H5g3ySQBRmXlT502Xs=; b=GIxC1v8mbAKHWMStHv5919eXQ/1JhGlVkJSoAMtcO7kmDXR1YO9uyN250jiTEWGekT W3SgE9B0fh0osFHiNlCURswTddu098zj/o73IybJPz+0GVA//T5Ua7QT+r9eB+kTYBjw 9AUM5ExZG7phH1/IBBp48Axu6WMIq6q5Kqlljg+LWy9krfCfALlXy8n8NKuq+oglLmmm s0Yl/EjDpN8EqWYhSvrqxWXmiMdX2PJR8G7dE+8VzViHx1cSTwfuYpnIInaNhOzYdHxD 7O2IONw/83aOSW3KlLM2siYx1Qieko/ECS2KyFwuDospJ7cUa5o788YJ+HH72wHvNYTW 1bmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="d/rRk4Uk"; dkim=neutral (no key) header.i=@linutronix.de header.b=JXzPiDfY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q66-20020a632a45000000b00502efdcf735si4973792pgq.539.2023.03.12.14.07.31; Sun, 12 Mar 2023 14:07:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="d/rRk4Uk"; dkim=neutral (no key) header.i=@linutronix.de header.b=JXzPiDfY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231224AbjCLUin (ORCPT <rfc822;realc9580@gmail.com> + 99 others); Sun, 12 Mar 2023 16:38:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230233AbjCLUil (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 12 Mar 2023 16:38:41 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39106241CB; Sun, 12 Mar 2023 13:38:37 -0700 (PDT) Date: Sun, 12 Mar 2023 20:38:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1678653515; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S8phezYGkV4ZFxG7GBTMyfW74H5g3ySQBRmXlT502Xs=; b=d/rRk4Uk7vsF1DgIlNSMRjyFl0PdtHlENZl3UhP0e5tOJTBJyhQpH0yZUSQiq8Kc/0D6kq pr1B5MoDvU4cHzvXtaZPFIbrlcg2H6rfujJShlYLIh1Zh+76I1CY3X9GUrQVstlRha+ysi eovjkQCC/wLWqgHO/4GP+UdJIK+FoFk8rC5mGiOtifcF5cWiNrg22sjo6tWf4j5bK8J8bC cO8cWe+TQ78LWdOdA0FsvF30rfPYOoY7qRPZ7sS4BXkDDqQUueSndeEsE2PP8CzsS1xWP/ /eOeoGuUTtG0lVNvML4o5v1VVkh+XFn+tf1pDgiQcmoGHLdiNhMdjDjfOJ8Q2g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1678653515; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S8phezYGkV4ZFxG7GBTMyfW74H5g3ySQBRmXlT502Xs=; b=JXzPiDfYhO+5BWfNMFyUyTKUkBcUZzUPgOZIx8bgdqaPgIZ2NfEtjYXcC0CZBtAV2ZRyHM 45tB3uoETAJL1iDg== From: "tip-bot2 for Yazen Ghannam" <tip-bot2@linutronix.de> Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: ras/urgent] x86/mce: Make sure logged MCEs are processed after sysfs update Cc: Yazen Ghannam <yazen.ghannam@amd.com>, "Borislav Petkov (AMD)" <bp@alien8.de>, Tony Luck <tony.luck@intel.com>, stable@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230301221420.2203184-1-yazen.ghannam@amd.com> References: <20230301221420.2203184-1-yazen.ghannam@amd.com> MIME-Version: 1.0 Message-ID: <167865351393.5837.17719714572303479044.tip-bot2@tip-bot2> Robot-ID: <tip-bot2@linutronix.de> Robot-Unsubscribe: Contact <mailto:tglx@linutronix.de> to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760197622143359477?= X-GMAIL-MSGID: =?utf-8?q?1760197622143359477?= |
Series |
[tip:,ras/urgent] x86/mce: Make sure logged MCEs are processed after sysfs update
|
|
Commit Message
tip-bot2 for Thomas Gleixner
March 12, 2023, 8:38 p.m. UTC
The following commit has been merged into the ras/urgent branch of tip: Commit-ID: 4783b9cb374af02d49740e00e2da19fd4ed6dec4 Gitweb: https://git.kernel.org/tip/4783b9cb374af02d49740e00e2da19fd4ed6dec4 Author: Yazen Ghannam <yazen.ghannam@amd.com> AuthorDate: Wed, 01 Mar 2023 22:14:20 Committer: Borislav Petkov (AMD) <bp@alien8.de> CommitterDate: Sun, 12 Mar 2023 21:12:21 +01:00 x86/mce: Make sure logged MCEs are processed after sysfs update A recent change introduced a flag to queue up errors found during boot-time polling. These errors will be processed during late init once the MCE subsystem is fully set up. A number of sysfs updates call mce_restart() which goes through a subset of the CPU init flow. This includes polling MCA banks and logging any errors found. Since the same function is used as boot-time polling, errors will be queued. However, the system is now past late init, so the errors will remain queued until another error is found and the workqueue is triggered. Call mce_schedule_work() at the end of mce_restart() so that queued errors are processed. Fixes: 3bff147b187d ("x86/mce: Defer processing of early errors") Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Reviewed-by: Tony Luck <tony.luck@intel.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20230301221420.2203184-1-yazen.ghannam@amd.com --- arch/x86/kernel/cpu/mce/core.c | 1 + 1 file changed, 1 insertion(+)
Comments
On Sun, Mar 12, 2023 at 08:38:33PM -0000, tip-bot2 for Yazen Ghannam wrote: > The following commit has been merged into the ras/urgent branch of tip: > > Commit-ID: 4783b9cb374af02d49740e00e2da19fd4ed6dec4 > Gitweb: https://git.kernel.org/tip/4783b9cb374af02d49740e00e2da19fd4ed6dec4 > Author: Yazen Ghannam <yazen.ghannam@amd.com> > AuthorDate: Wed, 01 Mar 2023 22:14:20 > Committer: Borislav Petkov (AMD) <bp@alien8.de> > CommitterDate: Sun, 12 Mar 2023 21:12:21 +01:00 > > x86/mce: Make sure logged MCEs are processed after sysfs update > > A recent change introduced a flag to queue up errors found during > boot-time polling. These errors will be processed during late init once > the MCE subsystem is fully set up. > > A number of sysfs updates call mce_restart() which goes through a subset > of the CPU init flow. This includes polling MCA banks and logging any > errors found. Since the same function is used as boot-time polling, > errors will be queued. However, the system is now past late init, so the > errors will remain queued until another error is found and the workqueue > is triggered. > > Call mce_schedule_work() at the end of mce_restart() so that queued > errors are processed. > > Fixes: 3bff147b187d ("x86/mce: Defer processing of early errors") > Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com> > Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> > Reviewed-by: Tony Luck <tony.luck@intel.com> Thank you! -Yazen
diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index 7832a69..2eec60f 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -2355,6 +2355,7 @@ static void mce_restart(void) { mce_timer_delete_all(); on_each_cpu(mce_cpu_restart, NULL, 1); + mce_schedule_work(); } /* Toggle features for corrected errors */