Message ID | 20230312233613.303408-2-andi.shyti@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp922539wrd; Sun, 12 Mar 2023 16:43:14 -0700 (PDT) X-Google-Smtp-Source: AK7set/Jm1qFGj10KqUd4tF0UofU8TmkZmtQ+WnlW5rOATxeusPvExOaoVptZfjGU7+IKTA/fSJa X-Received: by 2002:a05:6a20:258c:b0:cd:5334:e25e with SMTP id k12-20020a056a20258c00b000cd5334e25emr32005174pzd.17.1678664593773; Sun, 12 Mar 2023 16:43:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678664593; cv=none; d=google.com; s=arc-20160816; b=hoHLWJ0ICwVNnQt0FyW3YY4MGOQDroDADcq/LQ3YfYcRerildLz8J4VoKokFitEdFB U+4Cmqai2YG3fgnjmq17yrAXkJQ61bgX8RlLpIMotA8XyObbfhQRvCrZ2wKiixjRMibH oo+xMbzmHsN9yCZ9+uMo3TZ18F5C4skE0b545OUJf9rqO0WGAdJTvjs7jOsEvW8odu3R JIjyOQrhGhsyXMlgIElxpFqN92AHCvdr5rzV+9ag7jr/c+dKM8brisEAI6jXBhdjpm7O ycoAYKj1XYQ+z2bzlsqFwV+1WqZWeoLbfZgoiYBLqQbMAdTqr7MrtLxV/8eu94a5HEvX rqmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gZX/r07zqm6x8cVaeyJ06MnlM5jhS1OGF2q8AaUXyO0=; b=tQGeju9fpGhpHJPP63Eiu3gIAT53xTFgRskExPW+rJhmCuAKp7cpCn8yeqfLCCOhNe ZkfwMlrHcGIWLVjEhs25ElhbP5ttwBmuoTNrDDVhbT1KoH5kjXWfos+Oh6q5PjwW5p8o ODJOn52JtSWO/C+kf4+XUianxxw2oCYDbXtckuQFnFAR1mM3qZXlZZARjHQdtMm2zPSK ELXIB4Nh9DJequYdHQtN5xXtF2N/MziTwR62eDlU6QgWwAdmBZA6SmCu2LMuTklOAYI4 ftunN1MH27tg0G7nmHZR1A0xGq2A/lJNxMNlUjEBlPfVcD0RpFgEowfz1IJxvZxSjmAq pslQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OiKY7bhz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 19-20020a630413000000b004fb99dd149fsi5268241pge.239.2023.03.12.16.42.59; Sun, 12 Mar 2023 16:43:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OiKY7bhz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbjCLXgt (ORCPT <rfc822;realc9580@gmail.com> + 99 others); Sun, 12 Mar 2023 19:36:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbjCLXgr (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 12 Mar 2023 19:36:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCCB0298F1; Sun, 12 Mar 2023 16:36:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 68A53B80DC6; Sun, 12 Mar 2023 23:36:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9B47C433EF; Sun, 12 Mar 2023 23:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678664204; bh=Y/oVmiKiguf3cH10Ap6pc0Y9scvYwzwdpgy/O2vWpoM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OiKY7bhz5JfsdqQGnaLzn4lPwE3dWcasXhee3Jjp86A/X40Qh1vyJwsdduQvyM97i pk2VM+olfwjS7CPP8kS822Ei3+rSyipOshtlXzmrYBI9AcmnLryZZwWCPIr5jbYiOf t+0SMRxae+h61a1G44zKwRLj3B5yLvxh1jbO9JvT5fIOW1DxwWXr9stp5D841G9xg6 NljkhhKIZb6P64GPW+TdFfX6HxJGOE+dUiyZGB0NS3EP4ePEux1lOeb0OnxyVXOnfl BDKv/x6AYTbtd+FLaSHbJW68z5pgYVyxTQJrtJ6Zq3gbnP/HqfOZt8hleASL7H+1/i Opq1d8/VpQVHw== From: Andi Shyti <andi.shyti@kernel.org> To: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Wolfram Sang <wsa@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Chris Packham <chris.packham@alliedtelesis.co.nz>, Ryan Chen <ryan_chen@aspeedtech.com>, Andi Shyti <andi.shyti@kernel.org> Subject: [PATCH v3 1/3] dt-bindings: i2c: mpc: Mark "fsl,timeout" as deprecated Date: Mon, 13 Mar 2023 00:36:11 +0100 Message-Id: <20230312233613.303408-2-andi.shyti@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230312233613.303408-1-andi.shyti@kernel.org> References: <20230312233613.303408-1-andi.shyti@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760207405166621673?= X-GMAIL-MSGID: =?utf-8?q?1760207405166621673?= |
Series |
Add the clock stretching i2c property
|
|
Commit Message
Andi Shyti
March 12, 2023, 11:36 p.m. UTC
Now we have the i2c-scl-clk-low-timeout-ms property defined in
the i2c schema.
Mark "fsl,timeout" as deprecated and update the example.
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
---
Documentation/devicetree/bindings/i2c/i2c-mpc.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Mon, 13 Mar 2023 00:36:11 +0100, Andi Shyti wrote: > Now we have the i2c-scl-clk-low-timeout-ms property defined in > the i2c schema. > > Mark "fsl,timeout" as deprecated and update the example. > > Signed-off-by: Andi Shyti <andi.shyti@kernel.org> > --- > Documentation/devicetree/bindings/i2c/i2c-mpc.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/i2c-mpc.example.dtb: i2c@3100: Unevaluated properties are not allowed ('i2c-scl-clk-low-timeout-ms' was unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/i2c-mpc.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230312233613.303408-2-andi.shyti@kernel.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 14/03/2023 15:10, Rob Herring wrote: > > On Mon, 13 Mar 2023 00:36:11 +0100, Andi Shyti wrote: >> Now we have the i2c-scl-clk-low-timeout-ms property defined in >> the i2c schema. >> >> Mark "fsl,timeout" as deprecated and update the example. >> >> Signed-off-by: Andi Shyti <andi.shyti@kernel.org> >> --- >> Documentation/devicetree/bindings/i2c/i2c-mpc.yaml | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/i2c-mpc.example.dtb: i2c@3100: Unevaluated properties are not allowed ('i2c-scl-clk-low-timeout-ms' was unexpected) That's expected as it depends on: https://github.com/devicetree-org/dt-schema/pull/102 Best regards, Krzysztof
On 13/03/2023 00:36, Andi Shyti wrote: > Now we have the i2c-scl-clk-low-timeout-ms property defined in > the i2c schema. > > Mark "fsl,timeout" as deprecated and update the example. > > Signed-off-by: Andi Shyti <andi.shyti@kernel.org> > --- > Documentation/devicetree/bindings/i2c/i2c-mpc.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 14/03/2023 15:21, Krzysztof Kozlowski wrote: > On 13/03/2023 00:36, Andi Shyti wrote: >> Now we have the i2c-scl-clk-low-timeout-ms property defined in >> the i2c schema. >> >> Mark "fsl,timeout" as deprecated and update the example. >> >> Signed-off-by: Andi Shyti <andi.shyti@kernel.org> >> --- >> Documentation/devicetree/bindings/i2c/i2c-mpc.yaml | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> ... and unreviewed. Are you sure these are using same units? Old code used us. Your example: i2c-scl-clk-low-timeout-ms = <10000>; 10s timeout? Best regards, Krzysztof
On Tue, Mar 14, 2023 at 03:22:19PM +0100, Krzysztof Kozlowski wrote: > On 14/03/2023 15:21, Krzysztof Kozlowski wrote: > > On 13/03/2023 00:36, Andi Shyti wrote: > >> Now we have the i2c-scl-clk-low-timeout-ms property defined in > >> the i2c schema. > >> > >> Mark "fsl,timeout" as deprecated and update the example. > >> > >> Signed-off-by: Andi Shyti <andi.shyti@kernel.org> > >> --- > >> Documentation/devicetree/bindings/i2c/i2c-mpc.yaml | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > ... > > and unreviewed. Are you sure these are using same units? Old code used us. > > Your example: > i2c-scl-clk-low-timeout-ms = <10000>; > > 10s timeout? ops! I will keep it ms, if anyone doesn't have anything against. The clock stretching goes in order of milliseconds and in any case doesn't need to be precisely that, as long as it's longer. I don't see any need for it to be us... if it 12500us, let it be 13ms. I will update the example. Can I keep your r-b with: i2c-scl-clk-low-timeout-ms = <10>; ? Thanks for noticing it, it would have been a wacky mistake, Andi
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mpc.yaml b/Documentation/devicetree/bindings/i2c/i2c-mpc.yaml index 018e1b944424..bd2dd82471c1 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-mpc.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-mpc.yaml @@ -43,6 +43,7 @@ properties: fsl,timeout: $ref: /schemas/types.yaml#/definitions/uint32 + deprecated: true description: | I2C bus timeout in microseconds @@ -95,6 +96,6 @@ examples: interrupts = <43 2>; interrupt-parent = <&mpic>; clock-frequency = <400000>; - fsl,timeout = <10000>; + i2c-scl-clk-low-timeout-ms = <10000>; }; ...