diff mbox series

[V2,1/3] dt-bindings: mailbox: qcom: use fallback for IPQ8074 SoC

Message ID 20230314050005.10409-2-quic_kathirav@quicinc.com
State New
Headers
Series rework mailbox compatibles for Qualcomm IPQ SoCs |

Commit Message

Kathiravan Thirumoorthy March 14, 2023, 5 a.m. UTC 
  Since the IPQ8074 mailbox is compatible with the IPQ6018, lets create
the fallback to ipq6018 compatible, so that we don't bloat the of_device_id
table in the driver.

Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
	- Fixed the dtbs_check warning for IPQ6018

 .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml    | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Krzysztof Kozlowski March 14, 2023, 8:14 a.m. UTC | #1 
On 14/03/2023 06:00, Kathiravan T wrote:
> Since the IPQ8074 mailbox is compatible with the IPQ6018, lets create
> the fallback to ipq6018 compatible, so that we don't bloat the of_device_id
> table in the driver.
> 
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
> Changes in V2:
> 	- Fixed the dtbs_check warning for IPQ6018
> 

I responded to v1, so for formality: NAK.

Best regards,
Krzysztof
Kathiravan Thirumoorthy March 14, 2023, 8:38 a.m. UTC | #2 
On 3/14/2023 1:44 PM, Krzysztof Kozlowski wrote:
> On 14/03/2023 06:00, Kathiravan T wrote:
>> Since the IPQ8074 mailbox is compatible with the IPQ6018, lets create
>> the fallback to ipq6018 compatible, so that we don't bloat the of_device_id
>> table in the driver.
>>
>> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>> ---
>> Changes in V2:
>> 	- Fixed the dtbs_check warning for IPQ6018
>>
> I responded to v1, so for formality: NAK.

Thanks, I should have waited for some more time.. I see the V2 of your 
series. I'll drop this series.

Thanks, Kathiravan T.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
index d888ead09282..9598471d537f 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
@@ -19,11 +19,11 @@  properties:
       - items:
           - enum:
               - qcom,ipq5332-apcs-apps-global
+              - qcom,ipq8074-apcs-apps-global
           - const: qcom,ipq6018-apcs-apps-global
       - items:
           - enum:
               - qcom,ipq6018-apcs-apps-global
-              - qcom,ipq8074-apcs-apps-global
               - qcom,msm8996-apcs-hmss-global
               - qcom,msm8998-apcs-hmss-global
               - qcom,qcm2290-apcs-hmss-global
@@ -111,7 +111,6 @@  allOf:
           contains:
             enum:
               - qcom,ipq6018-apcs-apps-global
-              - qcom,ipq8074-apcs-apps-global
     then:
       properties:
         clocks:
@@ -152,7 +151,6 @@  allOf:
           contains:
             enum:
               - qcom,ipq6018-apcs-apps-global
-              - qcom,ipq8074-apcs-apps-global
     then:
       properties:
         '#clock-cells':