arm64: dts: qcom: sc7280: Villager doesn't have NVME

Message ID 20221025164915.1.I38e2545eda2b3bd3fef6b41c98f451e32851ae70@changeid
State New
Headers
Series arm64: dts: qcom: sc7280: Villager doesn't have NVME |

Commit Message

Doug Anderson Oct. 25, 2022, 11:52 p.m. UTC
  The sc7280-herobrine-villager derivative doesn't have NVME enabled so
we shouldn't mark the PCIe nodes as "okay" since they're just for
boards that have NVME.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 .../arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi | 10 ----------
 1 file changed, 10 deletions(-)
  

Comments

Krzysztof Kozlowski Oct. 26, 2022, 2:48 p.m. UTC | #1
On 25/10/2022 19:52, Douglas Anderson wrote:
> The sc7280-herobrine-villager derivative doesn't have NVME enabled so
> we shouldn't mark the PCIe nodes as "okay" since they're just for
> boards that have NVME.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
  
Stephen Boyd Oct. 26, 2022, 7:48 p.m. UTC | #2
Quoting Douglas Anderson (2022-10-25 16:52:39)
> The sc7280-herobrine-villager derivative doesn't have NVME enabled so
> we shouldn't mark the PCIe nodes as "okay" since they're just for
> boards that have NVME.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
  
Bjorn Andersson Nov. 8, 2022, 1:27 a.m. UTC | #3
On Tue, 25 Oct 2022 16:52:39 -0700, Douglas Anderson wrote:
> The sc7280-herobrine-villager derivative doesn't have NVME enabled so
> we shouldn't mark the PCIe nodes as "okay" since they're just for
> boards that have NVME.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sc7280: Villager doesn't have NVME
      commit: bcfefc98c5781ee97f1b7a8063870830d9e42b30

Best regards,
  

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi
index 3dff610fb946..17553e0fd6fd 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi
@@ -78,16 +78,6 @@  &mdss_edp_phy {
 	status = "okay";
 };
 
-/* For nvme */
-&pcie1 {
-	status = "okay";
-};
-
-/* For nvme */
-&pcie1_phy {
-	status = "okay";
-};
-
 &pwmleds {
 	status = "okay";
 };