diff mbox series

[3/3] arm64: dts: qcom: ipq8074: add compatible fallback to mailbox

Message ID 20230314041515.15883-4-quic_kathirav@quicinc.com
State New
Headers
Series rework mailbox compatibles for Qualcomm IPQ SoCs |

Commit Message

Kathiravan Thirumoorthy March 14, 2023, 4:15 a.m. UTC 
  From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

IPQ8074 mailbox is compatible with IPQ6018.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski March 14, 2023, 6:45 a.m. UTC | #1 
On 14/03/2023 05:15, Kathiravan T wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> IPQ8074 mailbox is compatible with IPQ6018.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq8074.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

What's this? Not even a dependency for something as it is last patch in
the series. What's the point?

Best regards,
Krzysztof
Krzysztof Kozlowski March 14, 2023, 7:08 a.m. UTC | #2 
On 14/03/2023 07:45, Krzysztof Kozlowski wrote:
> On 14/03/2023 05:15, Kathiravan T wrote:
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> IPQ8074 mailbox is compatible with IPQ6018.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/ipq8074.dtsi | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> What's this? Not even a dependency for something as it is last patch in
> the series. What's the point?

To be clear - that's a NAK.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
index 62d05d740646..3fa7a63db74e 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
@@ -687,7 +687,8 @@ 
 		};
 
 		apcs_glb: mailbox@b111000 {
-			compatible = "qcom,ipq8074-apcs-apps-global";
+			compatible = "qcom,ipq8074-apcs-apps-global",
+				     "qcom,ipq6018-apcs-apps-global";
 			reg = <0x0b111000 0x1000>;
 			clocks = <&a53pll>, <&xo>;
 			clock-names = "pll", "xo";