| Message ID | 20230312183622.460488-3-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp831537wrd;
Sun, 12 Mar 2023 11:42:57 -0700 (PDT)
X-Google-Smtp-Source:
AK7set8WF2G/Cnmajlpo6Hv6t9cOx6VmYqqsPLYWIE0iJH2hgQdjUqoj/Trb+WWLUFX/Sd5qvytd
X-Received: by 2002:a17:90b:4ac5:b0:237:dd21:c1e7 with SMTP id
mh5-20020a17090b4ac500b00237dd21c1e7mr33039812pjb.35.1678646576925;
Sun, 12 Mar 2023 11:42:56 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1678646576; cv=none;
d=google.com; s=arc-20160816;
b=ODQjCjZDRMMXPDhdmlSCRkgo0hJUH2c0vwCkJJKM8xGE02GrZTxoiYK6wkiJCHHv6b
+BXZnZp3BpQigVNTQ/hgfnDpSs2+mpOo6ItsVbKQX5LmxIh4UkxS4LRfVAcbTdVVJjDe
GfUedfyY46l4ty8ITlR7jYq7dAhMt6qB13jjLpfbO5Rd/QlHsJNM/aLiMgOttTqW/5fz
9+IbekTSWxzg+o+pG0pmoA8dzEEjtESxllKtV+6F4wkrvWiAZnIjIaZ8aGcEZw/Jxp9j
z0Ru+f0euL5CR3XJrtKrUKr5KoNhzTLq2i1ysrwEG3wublGJScezhYCLWEyoFl6zeTAD
u/Hw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=rTqyBeC+GZ8uw4WwDSFI+iV/rvPQQcy5WBfVxYcXc7E=;
b=azRCjXJ7Tr3a08fkGOSFXuOr3AmbSVqrn8yUTBvnqW33JpnNWGRLzn0uSP+Mmzktnt
uy+Wa30aJ2wShQLOKOixVbHKLOOemkEU9HbV+yX2sZPfw9EmsS/pfdyqD97bAYRBBt+S
yPvluVPiYcO3E+5tOawFD9fL2lrwUlMaM4ZZ+ZnXLanIWy6LrESgQKZs/m2d6iRccW0c
8h66t3o0p+l53lzpNltjXmByWsBa8glEd0vDtVY2riYkue1ipOlI1z62UaigHvT64G1A
tMVzLCnXPChgKBeLtAz+sTnYpdEsIoZZjFkYfbq1up1ycLAH8iYmw3pN1QRdBqt9F09r
jceg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=OpTC8Q5T;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
i14-20020a63e90e000000b00502d7cd012csi4712902pgh.378.2023.03.12.11.42.44;
Sun, 12 Mar 2023 11:42:56 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=OpTC8Q5T;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231326AbjCLSiH (ORCPT <rfc822;realc9580@gmail.com> + 99 others);
Sun, 12 Mar 2023 14:38:07 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60566 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229782AbjCLSh7 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sun, 12 Mar 2023 14:37:59 -0400
Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com
[IPv6:2a00:1450:4864:20::530])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC62D72B7
for <linux-kernel@vger.kernel.org>;
Sun, 12 Mar 2023 11:37:22 -0700 (PDT)
Received: by mail-ed1-x530.google.com with SMTP id o12so40252086edb.9
for <linux-kernel@vger.kernel.org>;
Sun, 12 Mar 2023 11:37:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1678646189;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=rTqyBeC+GZ8uw4WwDSFI+iV/rvPQQcy5WBfVxYcXc7E=;
b=OpTC8Q5T09t1iGZiX0pMkyqfrXQaWE+X15nT2Z5rDXDFuTPpn9s6hbUDrLrm4Ux6xT
cwiqHHTjZnbGZnQtFB4DD6OB2OAfnwclqbHzMWjyTSSrV4HCo0S1p47FXJN7IgZkIoU3
jydT/DBSTxtYUGW8RDvxtGP7jghIDEaH7k7SvRas6C7Wz1jiMJ7QP1B8RwzxxCJfNrhX
tv7HftJpEtyVkLvXZliWHYBgrSZbG+QxFg3kdeK3lFDzXSLhpMY3P2GKawmarkQjVEy7
8IDaQKWu0hX6OAettMkDpa1xPj9mkEafZxZNRiOjVopNdFnJVFqKn2esfugtwk0rEjDx
J7Zg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112; t=1678646189;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=rTqyBeC+GZ8uw4WwDSFI+iV/rvPQQcy5WBfVxYcXc7E=;
b=ZNggKq2Tgc4FOsg1Tz5JuM1/Avusf1oWuZX6M5MdR8D7wVYB0ZLJ3tIfhpYNDWKyyJ
LJ0j8pSzij3DegsMAU6U+y7OghHF68I6YsLhH/MjAs5BLUvvesSK+CtwVTTeIsDyHIfM
YxassDrTd9bw2/WwBcjnVznf87S0GyVLiBV+GO5+uqJWv68KNJalTUVgu0Lf1DMgjR2F
gDLkpywTJa7j7VLWzQwor3fODeOuEtyUrsX+dAi+gDb8aF+GgIzjUw95EExreQ2M01Mp
cB/y5uGytML7Z30i4AKDFRkOCrJM8bNkjiLDNxxObaebXlF8bnRA+MlAxFMFURcIFtap
njeg==
X-Gm-Message-State: AO0yUKW8uU3g4dM/e2F6imppqfFD+E/WjJ7Whb7tzlCS6sOi+HFJstvG
hr/jhSUuO+bNv3JTMa9ESN0zXA==
X-Received: by 2002:a17:906:3e52:b0:91e:fcea:f25f with SMTP id
t18-20020a1709063e5200b0091efceaf25fmr6891687eji.32.1678646188958;
Sun, 12 Mar 2023 11:36:28 -0700 (PDT)
Received: from krzk-bin.. ([2a02:810d:15c0:828:d9f6:3e61:beeb:295a])
by smtp.gmail.com with ESMTPSA id
p14-20020a1709060dce00b0092669fb4ba1sm893806eji.130.2023.03.12.11.36.28
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 12 Mar 2023 11:36:28 -0700 (PDT)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Douglas Anderson <dianders@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
"Joseph S. Barrera III" <joebar@chromium.org>,
Gustave Monce <gustave.monce@outlook.com>,
Vinod Koul <vkoul@kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 3/8] arm64: dts: qcom: sc7180-trogdor-lazor: correct trackpad
supply
Date: Sun, 12 Mar 2023 19:36:17 +0100
Message-Id: <20230312183622.460488-3-krzysztof.kozlowski@linaro.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20230312183622.460488-1-krzysztof.kozlowski@linaro.org>
References: <20230312183622.460488-1-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1760188512822380425?=
X-GMAIL-MSGID: =?utf-8?q?1760188512822380425?=
|
| Series |
[1/8] arm64: dts: qcom: sda660-inforce: correct key node name
|
|
Commit Message
Krzysztof Kozlowski
March 12, 2023, 6:36 p.m. UTC
The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other
boards which use elan,ekth3000 with valid VCC:
sc7180-trogdor-lazor-limozeen-nots-r4.dtb: trackpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
Fixes: 2c26adb8dbab ("arm64: dts: qcom: Add sc7180-lazor-limozeen skus")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 12.03.2023 19:36, Krzysztof Kozlowski wrote: > The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other > boards which use elan,ekth3000 with valid VCC: > > sc7180-trogdor-lazor-limozeen-nots-r4.dtb: trackpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+' > > Fixes: 2c26adb8dbab ("arm64: dts: qcom: Add sc7180-lazor-limozeen skus") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > .../boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts > index 850776c5323d..70d5a7aa8873 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts > @@ -26,7 +26,7 @@ trackpad: trackpad@2c { > interrupt-parent = <&tlmm>; > interrupts = <58 IRQ_TYPE_EDGE_FALLING>; > > - vcc-supply = <&pp3300_fp_tp>; > + vdd-supply = <&pp3300_fp_tp>; > hid-descr-addr = <0x20>; > > wakeup-source;
Hi, On Sun, Mar 12, 2023 at 11:36 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other > boards which use elan,ekth3000 with valid VCC: > > sc7180-trogdor-lazor-limozeen-nots-r4.dtb: trackpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+' > > Fixes: 2c26adb8dbab ("arm64: dts: qcom: Add sc7180-lazor-limozeen skus") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts > index 850776c5323d..70d5a7aa8873 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts > @@ -26,7 +26,7 @@ trackpad: trackpad@2c { > interrupt-parent = <&tlmm>; > interrupts = <58 IRQ_TYPE_EDGE_FALLING>; > > - vcc-supply = <&pp3300_fp_tp>; > + vdd-supply = <&pp3300_fp_tp>; Luckily it didn't matter since this regulator is always on, but good to have things described properly. Reviewed-by: Douglas Anderson <dianders@chromium.org>
Quoting Krzysztof Kozlowski (2023-03-12 11:36:17) > The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other > boards which use elan,ekth3000 with valid VCC: > > sc7180-trogdor-lazor-limozeen-nots-r4.dtb: trackpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+' > > Fixes: 2c26adb8dbab ("arm64: dts: qcom: Add sc7180-lazor-limozeen skus") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts index 850776c5323d..70d5a7aa8873 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts @@ -26,7 +26,7 @@ trackpad: trackpad@2c { interrupt-parent = <&tlmm>; interrupts = <58 IRQ_TYPE_EDGE_FALLING>; - vcc-supply = <&pp3300_fp_tp>; + vdd-supply = <&pp3300_fp_tp>; hid-descr-addr = <0x20>; wakeup-source;