diff mbox series

[1/5] net: stmmac: qcom: drop of_match_ptr for ID table

Message ID 20230310214632.275648-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series [1/5] net: stmmac: qcom: drop of_match_ptr for ID table |

Commit Message

Krzysztof Kozlowski March 10, 2023, 9:46 p.m. UTC 
  The driver is specific to ARCH_QCOM which depends on OF thus the driver
is OF-only.  Its of_device_id table is built unconditionally, thus
of_match_ptr() for ID table does not make sense.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Horman March 13, 2023, 4:26 p.m. UTC | #1 
On Fri, Mar 10, 2023 at 10:46:28PM +0100, Krzysztof Kozlowski wrote:
> The driver is specific to ARCH_QCOM which depends on OF thus the driver
> is OF-only.  Its of_device_id table is built unconditionally, thus
> of_match_ptr() for ID table does not make sense.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
patchwork-bot+netdevbpf@kernel.org March 15, 2023, 8:10 a.m. UTC | #2 
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri, 10 Mar 2023 22:46:28 +0100 you wrote:
> The driver is specific to ARCH_QCOM which depends on OF thus the driver
> is OF-only.  Its of_device_id table is built unconditionally, thus
> of_match_ptr() for ID table does not make sense.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [1/5] net: stmmac: qcom: drop of_match_ptr for ID table
    https://git.kernel.org/netdev/net-next/c/dc54e450a5dd
  - [2/5] net: stmmac: generic: drop of_match_ptr for ID table
    https://git.kernel.org/netdev/net-next/c/e6512465838b
  - [3/5] net: marvell: pxa168_eth: drop of_match_ptr for ID table
    https://git.kernel.org/netdev/net-next/c/69df36d524db
  - [4/5] net: samsung: sxgbe: drop of_match_ptr for ID table
    https://git.kernel.org/netdev/net-next/c/7f319fe4363c
  - [5/5] net: ni: drop of_match_ptr for ID table
    https://git.kernel.org/netdev/net-next/c/7e9aa8cad084

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
index 732774645c1a..32763566c214 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
@@ -606,7 +606,7 @@  static struct platform_driver qcom_ethqos_driver = {
 	.driver = {
 		.name           = "qcom-ethqos",
 		.pm		= &stmmac_pltfr_pm_ops,
-		.of_match_table = of_match_ptr(qcom_ethqos_match),
+		.of_match_table = qcom_ethqos_match,
 	},
 };
 module_platform_driver(qcom_ethqos_driver);